staging: rtl8723bs: remove redundant return in report_join_res()

[PATCH] staging: rtl8723bs: remove redundant return in report_join_res()

Posted by Hungyu Lin 2 months, 1 week ago

The return statement at the end of this void function is redundant
and can be removed.

No functional change.

Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
index b1f20aa81efb..dad1d95bc325 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
@@ -4508,9 +4508,6 @@ void report_join_res(struct adapter *padapter, int res)
 
 
 	rtw_enqueue_cmd(pcmdpriv, pcmd_obj);
-
-	return;
-
 }
 
 void report_wmm_edca_update(struct adapter *padapter)
-- 
2.34.1

Re: [PATCH] staging: rtl8723bs: remove redundant return in report_join_res()

Posted by Luka Gejak 2 months, 1 week ago

On Sat Apr 4, 2026 at 1:03 PM CEST, Hungyu Lin wrote:
> The return statement at the end of this void function is redundant
> and can be removed.
>
> No functional change.
>
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> index b1f20aa81efb..dad1d95bc325 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> @@ -4508,9 +4508,6 @@ void report_join_res(struct adapter *padapter, int res)
>  
>  
>  	rtw_enqueue_cmd(pcmdpriv, pcmd_obj);
> -
> -	return;
> -
>  }
>  
>  void report_wmm_edca_update(struct adapter *padapter)

LGTM
Reviewed-by: Luka Gejak <luka.gejak@linux.dev>

Best regards,
Luka Gejak

Re: [PATCH] staging: rtl8723bs: remove redundant return in report_join_res()

Posted by Ethan Tidmore 2 months, 1 week ago

On Sat Apr 4, 2026 at 6:03 AM CDT, Hungyu Lin wrote:
> The return statement at the end of this void function is redundant
> and can be removed.
>
> No functional change.
>
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> ---

LGTM.

Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>

Thanks,

ET