platform/chrome: cros_kbd_led_backlight: Some cleanups

[PATCH 0/5] platform/chrome: cros_kbd_led_backlight: Some cleanups

Posted by Thomas Weißschuh 2 months, 1 week ago

Some cleanups for the cros_kbd_led_backlight driver.

Patches 1-3 should go through platform-chrome.
Patch 4 and 5 should go either through platform-chrome or MFD.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
Thomas Weißschuh (5):
      platform/chrome: cros_kbd_led_backlight: Drop max_brightness from driver data
      platform/chrome: cros_kbd_led_backlight: Pass keyboard_led as parameter
      platform/chrome: cros_kbd_led_backlight: Drop CONFIG_MFD_CROS_EC_DEV ifdeffery
      mfd: cros_ec: Add a helper to retrieve the EC device from the MFD parent
      platform/chrome: cros_kbd_led_backlight: Use cros_ec_mfd_get_ec_dev()

 drivers/platform/chrome/cros_kbd_led_backlight.c | 31 +++++++-----------------
 include/linux/mfd/cros_ec.h                      | 16 ++++++++++++
 2 files changed, 25 insertions(+), 22 deletions(-)
---
base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f
change-id: 20260228-cros_kbd_led-cleanup-f0a13282b58d

Best regards,
--  
Thomas Weißschuh <linux@weissschuh.net>

Re: [PATCH 0/5] platform/chrome: cros_kbd_led_backlight: Some cleanups

Posted by Tzung-Bi Shih 2 months, 1 week ago

On Sat, Apr 04, 2026 at 09:55:25AM +0200, Thomas Weißschuh wrote:
> Some cleanups for the cros_kbd_led_backlight driver.
> 
> Patches 1-3 should go through platform-chrome.
> Patch 4 and 5 should go either through platform-chrome or MFD.

The series looks good to me.  I plan to apply at least patches 1-3 after
v7.1-rc1.

Re: (subset) [PATCH 0/5] platform/chrome: cros_kbd_led_backlight: Some cleanups

Posted by Tzung-Bi Shih 1 month, 2 weeks ago

On Sat, Apr 04, 2026 at 09:55:25AM +0200, Thomas Weißschuh wrote:
> Some cleanups for the cros_kbd_led_backlight driver.
> 
> Patches 1-3 should go through platform-chrome.
> Patch 4 and 5 should go either through platform-chrome or MFD.
> 
> 

Applied to

    https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next

[1/5] platform/chrome: cros_kbd_led_backlight: Drop max_brightness from driver data
      commit: d572049e6f4c46868d4d98c459618ed32bd93b2d
[2/5] platform/chrome: cros_kbd_led_backlight: Pass keyboard_led as parameter
      commit: 094a473e5dd6e02da5c09bf2c184c59c10a7b70c
[3/5] platform/chrome: cros_kbd_led_backlight: Drop CONFIG_MFD_CROS_EC_DEV ifdeffery
      commit: 0fd0fea2525d979c6de4ae546ac2ea1801849ae5

Thanks!