Correct Xiaomi Poco F1 compatible strings and evaluation.

[PATCH 1/2] dt-bindings: arm: qcom: Add Xiaomi Poco F1 Tianma variant bindings

Posted by David Heidelberg via B4 Relay 3 days, 19 hours ago

From: David Heidelberg <david@ixit.cz>

Add documentation for Tianma display and touchscreen variant.

While at it, correct binding documentation expectation.

Fixes: 341fdef8ea49 ("dt-bindings: arm: qcom: Add Xiaomi Poco F1 EBBG variant bindings")
Signed-off-by: David Heidelberg <david@ixit.cz>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 8c5fdd320cfcf..b412543f0afb8 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -822,6 +822,14 @@ properties:
           - const: google,zombie-sku514
           - const: qcom,sc7280
 
+      - description: Xiaomi Poco F1
+        items:
+          - enum:
+              - xiaomi,beryllium-ebbg
+              - xiaomi,beryllium-tianma
+          - const: xiaomi,beryllium
+          - const: qcom,sdm845
+
       - items:
           - enum:
               - lenovo,flex-5g
@@ -971,8 +979,6 @@ properties:
               - sony,akatsuki-row
               - sony,apollo-row
               - thundercomm,db845c
-              - xiaomi,beryllium
-              - xiaomi,beryllium-ebbg
               - xiaomi,polaris
           - const: qcom,sdm845
 

-- 
2.53.0

Re: [PATCH 1/2] dt-bindings: arm: qcom: Add Xiaomi Poco F1 Tianma variant bindings

Posted by Krzysztof Kozlowski 2 days, 4 hours ago

On Fri, Apr 03, 2026 at 06:55:33PM +0200, David Heidelberg wrote:
> Add documentation for Tianma display and touchscreen variant.
> 
> While at it, correct binding documentation expectation.

What expectation? What exactly did you corrected that you claim this is
a fix?

> 
> Fixes: 341fdef8ea49 ("dt-bindings: arm: qcom: Add Xiaomi Poco F1 EBBG variant bindings")


Best regards,
Krzysztof

Re: [PATCH 1/2] dt-bindings: arm: qcom: Add Xiaomi Poco F1 Tianma variant bindings

Posted by David Heidelberg 2 days, 4 hours ago

On 05/04/2026 09:55, Krzysztof Kozlowski wrote:
> On Fri, Apr 03, 2026 at 06:55:33PM +0200, David Heidelberg wrote:
>> Add documentation for Tianma display and touchscreen variant.
>>
>> While at it, correct binding documentation expectation.
> 
> What expectation? What exactly did you corrected that you claim this is
> a fix?

I would say the missing Tianma variant, which been with us for some time. The 
follow up commit fixes the missing compatible and order, thus it would make 
sense to me have also the dt-bindings part backported and fixed.

I agree I don't have strong case here. Should I drop the tag, keep it or replace 
it with Cc: stable@vger.kernel.org?

David

> 
>>
>> Fixes: 341fdef8ea49 ("dt-bindings: arm: qcom: Add Xiaomi Poco F1 EBBG variant bindings")
> 
> 
> Best regards,
> Krzysztof
> 

-- 
David Heidelberg

Re: [PATCH 1/2] dt-bindings: arm: qcom: Add Xiaomi Poco F1 Tianma variant bindings

Posted by Krzysztof Kozlowski 2 days, 3 hours ago

On 05/04/2026 10:01, David Heidelberg wrote:
> On 05/04/2026 09:55, Krzysztof Kozlowski wrote:
>> On Fri, Apr 03, 2026 at 06:55:33PM +0200, David Heidelberg wrote:
>>> Add documentation for Tianma display and touchscreen variant.
>>>
>>> While at it, correct binding documentation expectation.
>>
>> What expectation? What exactly did you corrected that you claim this is
>> a fix?
> 
> I would say the missing Tianma variant, which been with us for some time. The 

Expectation of missing Tianma? We don't have such expectations...

> follow up commit fixes the missing compatible and order, thus it would make 
> sense to me have also the dt-bindings part backported and fixed.

You probably should read original discussion why this ended up like that.

> 
> I agree I don't have strong case here. Should I drop the tag, keep it or replace 
> it with Cc: stable@vger.kernel.org?

If you cannot explain what you are fixing, then this is not a fix.

Best regards,
Krzysztof

Re: [PATCH 1/2] dt-bindings: arm: qcom: Add Xiaomi Poco F1 Tianma variant bindings

Posted by David Heidelberg 2 days, 3 hours ago


On 05/04/2026 10:55, Krzysztof Kozlowski wrote:
> On 05/04/2026 10:01, David Heidelberg wrote:
>> On 05/04/2026 09:55, Krzysztof Kozlowski wrote:
>>> On Fri, Apr 03, 2026 at 06:55:33PM +0200, David Heidelberg wrote:
>>>> Add documentation for Tianma display and touchscreen variant.
>>>>
>>>> While at it, correct binding documentation expectation.
>>>
>>> What expectation? What exactly did you corrected that you claim this is
>>> a fix?
>>
>> I would say the missing Tianma variant, which been with us for some time. The
> 
> Expectation of missing Tianma? We don't have such expectations...

Ok.

> 
>> follow up commit fixes the missing compatible and order, thus it would make
>> sense to me have also the dt-bindings part backported and fixed.
> 
> You probably should read original discussion why this ended up like that.

All I found is

  The compatibility property is
  moved to the tianma variant, but it is not updated to avoid any
  further conflict with other projects/users that might depend on it.

> 
>>
>> I agree I don't have strong case here. Should I drop the tag, keep it or replace
>> it with Cc: stable@vger.kernel.org?
> 
> If you cannot explain what you are fixing, then this is not a fix.

Sure, I'll drop the tag.

> 
> Best regards,
> Krzysztof

-- 
David Heidelberg