This series replaces pr_*() logging calls with dev_*() and netdev_*()
in the octeon ethernet staging driver to include device context in
log messages, as requested by Greg Kroah-Hartman.
Changes since v2:
- Use netdev_err() instead of dev_err() in ethernet-spi.c
- Pass the netdev pointer directly to request_irq/free_irq
  instead of dev->dev.parent
- Move the device pointer to be the first argument in helper
  functions
- Fix checkpatch alignment and line-length warnings
- Add missing @dev kernel-doc parameter descriptions
- Wrap commit message body to 75 characters
- Fix author name formatting

Ayush Mukkanwar (2):
  staging: octeon: ethernet-spi: replace pr_err with dev_err
  staging: octeon: ethernet: replace pr_* with dev_* and netdev_*

 drivers/staging/octeon/ethernet-mem.c | 39 +++++++-------
 drivers/staging/octeon/ethernet-mem.h |  4 +-
 drivers/staging/octeon/ethernet-rx.c  |  6 ++-
 drivers/staging/octeon/ethernet-rx.h  |  6 +--
 drivers/staging/octeon/ethernet-spi.c | 78 +++++++++++++--------------
 drivers/staging/octeon/ethernet.c     | 63 +++++++++++++---------
 6 files changed, 105 insertions(+), 91 deletions(-)

-- 
2.53.0

Last week I spent some time reviewing how bugs are introduced in staging
and the number one cause is complicated changes from the maintainers.
It's hard to avoid that because the kernel is complicated and complicated
things are hard.

But another major cause of bugs was pr_warn() to dev_warn() transitions.
I'm not sure what to do about that either really...

Anyway, I'm glad I don't have to review this patch until v4.

regards,
dan carpenter

On Thu, Apr 02, 2026 at 05:12:40PM +0530, Ayush Mukkanwar wrote:
> This series replaces pr_*() logging calls with dev_*() and netdev_*()
> in the octeon ethernet staging driver to include device context in
> log messages, as requested by Greg Kroah-Hartman.
> Changes since v2:
> - Use netdev_err() instead of dev_err() in ethernet-spi.c
> - Pass the netdev pointer directly to request_irq/free_irq
>   instead of dev->dev.parent
> - Move the device pointer to be the first argument in helper
>   functions

I don't see this happening, and I see other comments that I made were
not followed :(

Please, take some time, break this up into much smaller pieces, and
re-read my previous review comments and apply them everywhere.

thanks,

greg k-h