ata: pata_arasan_cf: fix missing newline in dev_err messages

[PATCH] ata: pata_arasan_cf: fix missing newline in dev_err messages

Posted by Haoyu Lu 2 months, 1 week ago

Add missing trailing newlines to dev_err() messages in pata_arasan_cf.c.

This keeps the error output as properly terminated log lines.

Signed-off-by: Haoyu Lu <hechushiguitu666@gmail.com>
---
 drivers/ata/pata_arasan_cf.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/ata/pata_arasan_cf.c b/drivers/ata/pata_arasan_cf.c
index 514d549286b5..abcdef123456 100644
--- a/drivers/ata/pata_arasan_cf.c
+++ b/drivers/ata/pata_arasan_cf.c
@@ -380,7 +380,7 @@ static int arasan_cf_xfer(struct arasan_cf_dev *acdev, struct ata_queued_cmd *qc
 	if (!wait_for_completion_timeout(&acdev->cf_completion, TIMEOUT)) {
 		u32 rw = acdev->qc->tf.flags & ATA_TFLAG_WRITE;

-		dev_err(acdev->host->dev, "%s TimeOut", rw ? "write" : "read");
+		dev_err(acdev->host->dev, "%s TimeOut\n", rw ? "write" : "read");
 		return -ETIMEDOUT;
 	}

@@ -474,7 +474,7 @@ static int arasan_cf_xfer(struct arasan_cf_dev *acdev, struct ata_queued_cmd *qc
 			dma_len = min(xfer_cnt, FIFO_SIZE);
 			ret = dma_xfer(acdev, src, dest, dma_len);
 			if (ret) {
-				dev_err(acdev->host->dev, "dma failed");
+				dev_err(acdev->host->dev, "dma failed\n");
 				goto fail;
 			}

--
2.17.1

Re: [PATCH] ata: pata_arasan_cf: fix missing newline in dev_err messages

Posted by Damien Le Moal 2 months, 1 week ago

On 2026/04/02 11:10, Haoyu Lu wrote:
> Add missing trailing newlines to dev_err() messages in pata_arasan_cf.c.
> 
> This keeps the error output as properly terminated log lines.
> 
> Signed-off-by: Haoyu Lu <hechushiguitu666@gmail.com>
> ---
>  drivers/ata/pata_arasan_cf.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/ata/pata_arasan_cf.c b/drivers/ata/pata_arasan_cf.c
> index 514d549286b5..abcdef123456 100644
> --- a/drivers/ata/pata_arasan_cf.c
> +++ b/drivers/ata/pata_arasan_cf.c
> @@ -380,7 +380,7 @@ static int arasan_cf_xfer(struct arasan_cf_dev *acdev, struct ata_queued_cmd *qc

There is no such function, and yet your patch applies. I am confused...
Which tree is this patch against ?

>  	if (!wait_for_completion_timeout(&acdev->cf_completion, TIMEOUT)) {
>  		u32 rw = acdev->qc->tf.flags & ATA_TFLAG_WRITE;
> 
> -		dev_err(acdev->host->dev, "%s TimeOut", rw ? "write" : "read");
> +		dev_err(acdev->host->dev, "%s TimeOut\n", rw ? "write" : "read");
>  		return -ETIMEDOUT;
>  	}
> 
> @@ -474,7 +474,7 @@ static int arasan_cf_xfer(struct arasan_cf_dev *acdev, struct ata_queued_cmd *qc
>  			dma_len = min(xfer_cnt, FIFO_SIZE);
>  			ret = dma_xfer(acdev, src, dest, dma_len);
>  			if (ret) {
> -				dev_err(acdev->host->dev, "dma failed");
> +				dev_err(acdev->host->dev, "dma failed\n");
>  				goto fail;
>  			}
> 
> --
> 2.17.1


-- 
Damien Le Moal
Western Digital Research

Re: [PATCH] ata: pata_arasan_cf: fix missing newline in dev_err messages

Posted by Owens James 2 months, 1 week ago

Hi Damien,

Thank you for checking!
The function arasan_cf_xfer() does exist in the mainline kernel at
drivers/ata/pata_arasan_cf.c around line 380.
This patch is based on the latest upstream mainline branch.
Please let me know if you need anything else.

Best regards, Haoyu Lu

Damien Le Moal <dlemoal@kernel.org> 于2026年4月2日周四 13:35写道：
>
> On 2026/04/02 11:10, Haoyu Lu wrote:
> > Add missing trailing newlines to dev_err() messages in pata_arasan_cf.c.
> >
> > This keeps the error output as properly terminated log lines.
> >
> > Signed-off-by: Haoyu Lu <hechushiguitu666@gmail.com>
> > ---
> >  drivers/ata/pata_arasan_cf.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/ata/pata_arasan_cf.c b/drivers/ata/pata_arasan_cf.c
> > index 514d549286b5..abcdef123456 100644
> > --- a/drivers/ata/pata_arasan_cf.c
> > +++ b/drivers/ata/pata_arasan_cf.c
> > @@ -380,7 +380,7 @@ static int arasan_cf_xfer(struct arasan_cf_dev *acdev, struct ata_queued_cmd *qc
>
> There is no such function, and yet your patch applies. I am confused...
> Which tree is this patch against ?
>
> >       if (!wait_for_completion_timeout(&acdev->cf_completion, TIMEOUT)) {
> >               u32 rw = acdev->qc->tf.flags & ATA_TFLAG_WRITE;
> >
> > -             dev_err(acdev->host->dev, "%s TimeOut", rw ? "write" : "read");
> > +             dev_err(acdev->host->dev, "%s TimeOut\n", rw ? "write" : "read");
> >               return -ETIMEDOUT;
> >       }
> >
> > @@ -474,7 +474,7 @@ static int arasan_cf_xfer(struct arasan_cf_dev *acdev, struct ata_queued_cmd *qc
> >                       dma_len = min(xfer_cnt, FIFO_SIZE);
> >                       ret = dma_xfer(acdev, src, dest, dma_len);
> >                       if (ret) {
> > -                             dev_err(acdev->host->dev, "dma failed");
> > +                             dev_err(acdev->host->dev, "dma failed\n");
> >                               goto fail;
> >                       }
> >
> > --
> > 2.17.1
>
>
> --
> Damien Le Moal
> Western Digital Research

Re: [PATCH] ata: pata_arasan_cf: fix missing newline in dev_err messages

Posted by Damien Le Moal 2 months, 1 week ago

On 2026/04/02 16:11, Owens James wrote:
> Hi Damien,
> 
> Thank you for checking!
> The function arasan_cf_xfer() does exist in the mainline kernel at
> drivers/ata/pata_arasan_cf.c around line 380.

Nope...

378 static inline int wait4buf(struct arasan_cf_dev *acdev)
379 {
380         if (!wait_for_completion_timeout(&acdev->cf_completion, TIMEOUT)) {
381                 u32 rw = acdev->qc->tf.flags & ATA_TFLAG_WRITE;
382
383                 dev_err(acdev->host->dev, "%s TimeOut\n", rw ? "write" :
"read");
384                 return -ETIMEDOUT;
385         }
386
387         /* Check if PIO Error interrupt has occurred */
388         if (acdev->dma_status & ATA_DMA_ERR)
389                 return -EAGAIN;
390
391         return 0;
392 }

And "git grep arasan_cf_xfer" gives nothing.

So still not sure which kernel you are looking at.

> This patch is based on the latest upstream mainline branch.
> Please let me know if you need anything else.

Patches for libata should be based off libata/for-next or libata/for-7.1.


-- 
Damien Le Moal
Western Digital Research

Re: [PATCH] ata: pata_arasan_cf: fix missing newline in dev_err messages

Posted by Haoyu Lu 2 months, 1 week ago

Hi Damien,

Sorry for the mistake!
I didn't realize libata patches need to be based on libata/for-next,
not mainline.
I see the driver has been refactored and the newlines are already fixed.
I'll drop this patch and follow the correct branch for future changes.
Thanks for the clarification!

Best regards, Haoyu Lu

On Thu, Apr 2, 2026 at 3:38 PM Damien Le Moal <dlemoal@kernel.org> wrote:
>
> On 2026/04/02 16:11, Owens James wrote:
> > Hi Damien,
> >
> > Thank you for checking!
> > The function arasan_cf_xfer() does exist in the mainline kernel at
> > drivers/ata/pata_arasan_cf.c around line 380.
>
> Nope...
>
> 378 static inline int wait4buf(struct arasan_cf_dev *acdev)
> 379 {
> 380         if (!wait_for_completion_timeout(&acdev->cf_completion, TIMEOUT)) {
> 381                 u32 rw = acdev->qc->tf.flags & ATA_TFLAG_WRITE;
> 382
> 383                 dev_err(acdev->host->dev, "%s TimeOut\n", rw ? "write" :
> "read");
> 384                 return -ETIMEDOUT;
> 385         }
> 386
> 387         /* Check if PIO Error interrupt has occurred */
> 388         if (acdev->dma_status & ATA_DMA_ERR)
> 389                 return -EAGAIN;
> 390
> 391         return 0;
> 392 }
>
> And "git grep arasan_cf_xfer" gives nothing.
>
> So still not sure which kernel you are looking at.
>
> > This patch is based on the latest upstream mainline branch.
> > Please let me know if you need anything else.
>
> Patches for libata should be based off libata/for-next or libata/for-7.1.
>
>
> --
> Damien Le Moal
> Western Digital Research

Re: [PATCH] ata: pata_arasan_cf: fix missing newline in dev_err messages

Posted by Niklas Cassel 2 months, 1 week ago

Hello Haoyu,

On Thu, Apr 02, 2026 at 03:48:42PM +0800, Haoyu Lu wrote:
> Hi Damien,
> 
> Sorry for the mistake!
> I didn't realize libata patches need to be based on libata/for-next,
> not mainline.

This patch was not based on either libata/for-next or Linus's tree.

> I see the driver has been refactored and the newlines are already fixed.
> I'll drop this patch and follow the correct branch for future changes.
> Thanks for the clarification!

There has not been any newlines added upstream, your fix is still valid.

However, the function has not been refactored, you must have based your
patch on some downstream kernel.

While the patch does apply, and I could theoretically apply it, please:

-Send a V2 based on libata/for-next or Linus's tree
-Pick up the tag from Viresh
-Change the subject from
 ata: pata_arasan_cf: fix missing newline in dev_err messages
 to
 ata: pata_arasan_cf: fix missing newline in dev_err() messages

If only to give you experience working with upstream kernels.

Kind regards,
Niklas

Re: [PATCH] ata: pata_arasan_cf: fix missing newline in dev_err messages

Posted by Viresh Kumar 2 months, 1 week ago

On 02-04-26, 10:10, Haoyu Lu wrote:
> Add missing trailing newlines to dev_err() messages in pata_arasan_cf.c.
> 
> This keeps the error output as properly terminated log lines.
> 
> Signed-off-by: Haoyu Lu <hechushiguitu666@gmail.com>
> ---
>  drivers/ata/pata_arasan_cf.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/ata/pata_arasan_cf.c b/drivers/ata/pata_arasan_cf.c
> index 514d549286b5..abcdef123456 100644
> --- a/drivers/ata/pata_arasan_cf.c
> +++ b/drivers/ata/pata_arasan_cf.c
> @@ -380,7 +380,7 @@ static int arasan_cf_xfer(struct arasan_cf_dev *acdev, struct ata_queued_cmd *qc
>  	if (!wait_for_completion_timeout(&acdev->cf_completion, TIMEOUT)) {
>  		u32 rw = acdev->qc->tf.flags & ATA_TFLAG_WRITE;
> 
> -		dev_err(acdev->host->dev, "%s TimeOut", rw ? "write" : "read");
> +		dev_err(acdev->host->dev, "%s TimeOut\n", rw ? "write" : "read");
>  		return -ETIMEDOUT;
>  	}
> 
> @@ -474,7 +474,7 @@ static int arasan_cf_xfer(struct arasan_cf_dev *acdev, struct ata_queued_cmd *qc
>  			dma_len = min(xfer_cnt, FIFO_SIZE);
>  			ret = dma_xfer(acdev, src, dest, dma_len);
>  			if (ret) {
> -				dev_err(acdev->host->dev, "dma failed");
> +				dev_err(acdev->host->dev, "dma failed\n");
>  				goto fail;
>  			}
> 

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh