[PATCH net-next v3 0/7] Decouple receive and transmit enablement in team driver

Marc Harvey posted 7 patches 2 months, 1 week ago
There is a newer version of this series
drivers/net/team/team_core.c                       | 241 +++++++++++++++++---
drivers/net/team/team_mode_loadbalance.c           |   8 +-
drivers/net/team/team_mode_random.c                |   4 +-
drivers/net/team/team_mode_roundrobin.c            |   2 +-
include/linux/if_team.h                            |  63 +++---
tools/testing/selftests/drivers/net/team/Makefile  |   4 +
tools/testing/selftests/drivers/net/team/config    |   4 +
.../drivers/net/team/decoupled_enablement.sh       | 249 +++++++++++++++++++++
.../testing/selftests/drivers/net/team/options.sh  |  99 +++++++-
.../testing/selftests/drivers/net/team/team_lib.sh | 115 ++++++++++
.../drivers/net/team/teamd_activebackup.sh         | 217 ++++++++++++++++++
.../drivers/net/team/transmit_failover.sh          | 151 +++++++++++++
tools/testing/selftests/net/lib.sh                 |  13 ++
13 files changed, 1100 insertions(+), 70 deletions(-)
[PATCH net-next v3 0/7] Decouple receive and transmit enablement in team driver
Posted by Marc Harvey 2 months, 1 week ago
Allow independent control over receive and transmit enablement states
for aggregated ports in the team driver.

The motivation is that IEE 802.3ad LACP "independent control" can't
be implemented for the team driver currently. This was added to the
bonding driver in commit 240fd405528b ("bonding: Add independent
control state machine").

This series also has a few patches that add tests to show that the old
coupled enablement still works and that the new decoupled enablement
works as intended (4, 5, and 7).

There are three patches with small fixes as well, with the goal of
making the final decouplement patch clearer (1, 2, and 3).

Signed-off-by: Marc Harvey <marcharvey@google.com>
---
Changes in v3:
- Patch 5: In test cleanup, kill teamd to fix timeout.
- Link to v2: https://lore.kernel.org/r/20260401-teaming-driver-internal-v2-0-f80c1291727b@google.com

Changes in v2:
- Patch 4 and 5: Fix shellcheck errors and warnings, use iperf3
  instead of netcat+pv, fix dependency checking.
- Patch 7: Fix shellcheck errors and warnings, fix dependency
  checking.
- Link to v1: https://lore.kernel.org/all/20260331053353.2504254-1-marcharvey@google.com/

---
Marc Harvey (7):
      net: team: Annotate reads and writes for mixed lock accessed values
      net: team: Remove unused team_mode_op, port_enabled
      net: team: Rename port_disabled team mode op to port_tx_disabled
      selftests: net: Add tests for failover of team-aggregated ports
      selftests: net: Add test for enablement of ports with teamd
      net: team: Decouple rx and tx enablement in the team driver
      selftests: net: Add tests for team driver decoupled tx and rx control

 drivers/net/team/team_core.c                       | 241 +++++++++++++++++---
 drivers/net/team/team_mode_loadbalance.c           |   8 +-
 drivers/net/team/team_mode_random.c                |   4 +-
 drivers/net/team/team_mode_roundrobin.c            |   2 +-
 include/linux/if_team.h                            |  63 +++---
 tools/testing/selftests/drivers/net/team/Makefile  |   4 +
 tools/testing/selftests/drivers/net/team/config    |   4 +
 .../drivers/net/team/decoupled_enablement.sh       | 249 +++++++++++++++++++++
 .../testing/selftests/drivers/net/team/options.sh  |  99 +++++++-
 .../testing/selftests/drivers/net/team/team_lib.sh | 115 ++++++++++
 .../drivers/net/team/teamd_activebackup.sh         | 217 ++++++++++++++++++
 .../drivers/net/team/transmit_failover.sh          | 151 +++++++++++++
 tools/testing/selftests/net/lib.sh                 |  13 ++
 13 files changed, 1100 insertions(+), 70 deletions(-)
---
base-commit: cee10a01e286e88e0949979e91231270ca9fdb8e
change-id: 20260401-teaming-driver-internal-83f2f0074d68

Best regards,
-- 
Marc Harvey <marcharvey@google.com>
Re: [PATCH net-next v3 0/7] Decouple receive and transmit enablement in team driver
Posted by Jakub Kicinski 2 months, 1 week ago
On Thu, 02 Apr 2026 06:24:13 +0000 Marc Harvey wrote:
> Allow independent control over receive and transmit enablement states
> for aggregated ports in the team driver.
> 
> The motivation is that IEE 802.3ad LACP "independent control" can't
> be implemented for the team driver currently. This was added to the
> bonding driver in commit 240fd405528b ("bonding: Add independent
> control state machine").
> 
> This series also has a few patches that add tests to show that the old
> coupled enablement still works and that the new decoupled enablement
> works as intended (4, 5, and 7).
> 
> There are three patches with small fixes as well, with the goal of
> making the final decouplement patch clearer (1, 2, and 3).

Sounds like Jiri asked for changes, when you respin could you run
shellcheck and clean up the warnings? We ignore SC2317 SC2329 FWIW
selftests confuse the checker.
Re: [PATCH net-next v3 0/7] Decouple receive and transmit enablement in team driver
Posted by Marc Harvey 2 months, 1 week ago
On Thu, Apr 2, 2026 at 7:45 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> Sounds like Jiri asked for changes, when you respin could you run
> shellcheck and clean up the warnings? We ignore SC2317 SC2329 FWIW
> selftests confuse the checker.

I will send v4 soon after splitting up the main functional patch, as
Jiri requested. It appears all of the shellcheck errors are from
SC2329. I see a bunch of other warnings in patch 5 (from
tools/testing/selftests/net/lib.sh), but they are unrelated to the
changes from that patch.