[v1] vsock/virtio: fix MSG_PEEK calculation on bytes to copy

[PATCH net 0/2] vsock/virtio: fix MSG_PEEK calculation on bytes to copy

Luigi Leonardi posted 2 patches 2 months, 1 week ago

Diff against v2 v3 v4
Download series mbox

There is a newer version of this series

net/vmw_vsock/virtio_transport_common.c |  5 ++-
tools/testing/vsock/vsock_test.c        | 64 +++++++++++++++++++++++++++++++++
2 files changed, 66 insertions(+), 3 deletions(-)

Expand all Fold all

[PATCH net 0/2] vsock/virtio: fix MSG_PEEK calculation on bytes to copy

Posted by Luigi Leonardi 2 months, 1 week ago

`virtio_transport_stream_do_peek`, when calculating the number of bytes to copy,
didn't consider the `offset`, caused by partial reads that happend before.
This might cause out-of-bounds read that lead to an EFAULT.
More details in the commit.

Commit 1 introduces the fix
Commit 2 introduces a test that checks for this bug to avoid future
regressions.

Signed-off-by: Luigi Leonardi <leonardi@redhat.com>
---
Luigi Leonardi (2):
      vsock/virtio: fix MSG_PEEK ignoring skb offset when calculating bytes to copy
      vsock/test: add MSG_PEEK after partial recv test

 net/vmw_vsock/virtio_transport_common.c |  5 ++-
 tools/testing/vsock/vsock_test.c        | 64 +++++++++++++++++++++++++++++++++
 2 files changed, 66 insertions(+), 3 deletions(-)
---
base-commit: 9147566d801602c9e7fc7f85e989735735bf38ba
change-id: 20260401-fix_peek-6837b83469e3

Best regards,
-- 
Luigi Leonardi <leonardi@redhat.com>