[PATCH v4 1/5] dt-bindings: media: qcom,sm8550-iris: Add X1P42100 compatible

Wangao Wang posted 5 patches 11 hours ago
[PATCH v4 1/5] dt-bindings: media: qcom,sm8550-iris: Add X1P42100 compatible
Posted by Wangao Wang 11 hours ago
Document the new compatible string "qcom,x1p42100-iris".

The x1p42100 SoC integrates the same IRIS video hardware block as SM8550,
but represents a distinct hardware instance and therefore uses its own
compatible string.

The x1p42100 variant includes an additional Bitstream Engine (BSE) clock
that is not present on SM8550. This clock is described explicitly in the
binding.

Signed-off-by: Wangao Wang <wangao.wang@oss.qualcomm.com>
---
 .../bindings/media/qcom,sm8550-iris.yaml           | 23 +++++++++++++++++++++-
 1 file changed, 22 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
index 9c4b760508b50251ac467ad44a366689260bfc0d..0400ca1bff05dcef6b742c3fbf77e38adca9f280 100644
--- a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
@@ -26,6 +26,7 @@ properties:
           - qcom,qcs8300-iris
           - qcom,sm8550-iris
           - qcom,sm8650-iris
+          - qcom,x1p42100-iris
 
   reg:
     maxItems: 1
@@ -41,13 +42,16 @@ properties:
       - const: mmcx
 
   clocks:
-    maxItems: 3
+    minItems: 3
+    maxItems: 4
 
   clock-names:
+    minItems: 3
     items:
       - const: iface
       - const: core
       - const: vcodec0_core
+      - const: vcodec0_bse
 
   firmware-name:
     maxItems: 1
@@ -115,6 +119,23 @@ allOf:
           maxItems: 1
         reset-names:
           maxItems: 1
+  - if:
+      properties:
+        compatible:
+          enum:
+            - qcom,x1p42100-iris
+    then:
+      properties:
+        clocks:
+          minItems: 4
+        clock-names:
+          minItems: 4
+    else:
+      properties:
+        clocks:
+          maxItems: 3
+        clock-names:
+          maxItems: 3
 
 unevaluatedProperties: false
 

-- 
2.43.0
Re: [PATCH v4 1/5] dt-bindings: media: qcom,sm8550-iris: Add X1P42100 compatible
Posted by Bryan O'Donoghue 11 hours ago
On 01/04/2026 11:24, Wangao Wang wrote:
> Document the new compatible string "qcom,x1p42100-iris".
> 
> The x1p42100 SoC integrates the same IRIS video hardware block as SM8550,
> but represents a distinct hardware instance and therefore uses its own
> compatible string.
> 
> The x1p42100 variant includes an additional Bitstream Engine (BSE) clock
> that is not present on SM8550. This clock is described explicitly in the
> binding.
> 
> Signed-off-by: Wangao Wang <wangao.wang@oss.qualcomm.com>
> ---
>   .../bindings/media/qcom,sm8550-iris.yaml           | 23 +++++++++++++++++++++-
>   1 file changed, 22 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
> index 9c4b760508b50251ac467ad44a366689260bfc0d..0400ca1bff05dcef6b742c3fbf77e38adca9f280 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
> @@ -26,6 +26,7 @@ properties:
>             - qcom,qcs8300-iris
>             - qcom,sm8550-iris
>             - qcom,sm8650-iris
> +          - qcom,x1p42100-iris
> 
>     reg:
>       maxItems: 1
> @@ -41,13 +42,16 @@ properties:
>         - const: mmcx
> 
>     clocks:
> -    maxItems: 3
> +    minItems: 3
> +    maxItems: 4
> 
>     clock-names:
> +    minItems: 3
>       items:
>         - const: iface
>         - const: core
>         - const: vcodec0_core
> +      - const: vcodec0_bse
> 
>     firmware-name:
>       maxItems: 1
> @@ -115,6 +119,23 @@ allOf:
>             maxItems: 1
>           reset-names:
>             maxItems: 1
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - qcom,x1p42100-iris
> +    then:
> +      properties:
> +        clocks:
> +          minItems: 4
> +        clock-names:
> +          minItems: 4
> +    else:
> +      properties:
> +        clocks:
> +          maxItems: 3
> +        clock-names:
> +          maxItems: 3
> 
>   unevaluatedProperties: false
> 
> 
> --
> 2.43.0
> 

LGTM

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>