ALSA: hda/realtek: fix code style (ERROR: else should follow close brace '}')

[PATCH] ALSA: hda/realtek: fix code style (ERROR: else should follow close brace '}')

Posted by Lei Huang 1 day, 3 hours ago

From: Lei Huang <huanglei@kylinos.cn>

Fix checkpatch code style errors:

  ERROR: else should follow close brace '}'
  #2300: FILE: sound/hda/codecs/realtek/alc269.c:2300:
  +       }
  +       else

Fixes: 31278997add6 ("ALSA: hda/realtek - Add headset quirk for Dell DT")
Signed-off-by: Lei Huang <huanglei@kylinos.cn>
---
 sound/hda/codecs/realtek/alc269.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index 09af4d378b30..afe13a7f2673 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -2296,9 +2296,9 @@ static void alc_fixup_headset_mode_alc255_no_hp_mic(struct hda_codec *codec,
 		struct alc_spec *spec = codec->spec;
 		spec->parse_flags |= HDA_PINCFG_HEADSET_MIC;
 		alc255_set_default_jack_type(codec);
-	}
-	else
+	} else {
 		alc_fixup_headset_mode(codec, fix, action);
+	}
 }
 
 static void alc288_update_headset_jack_cb(struct hda_codec *codec,
-- 
2.25.1

Re: [PATCH] ALSA: hda/realtek: fix code style (ERROR: else should follow close brace '}')

Posted by Krzysztof Kozlowski 31 minutes ago

On 31/03/2026 09:54, Lei Huang wrote:
> From: Lei Huang <huanglei@kylinos.cn>
> 
> Fix checkpatch code style errors:
> 
>   ERROR: else should follow close brace '}'
>   #2300: FILE: sound/hda/codecs/realtek/alc269.c:2300:
>   +       }
>   +       else
> 
> Fixes: 31278997add6 ("ALSA: hda/realtek - Add headset quirk for Dell DT")

There is no bug to be fixed here. Don't add fake bug indications, it
unnecessarily gives stable team some work.

Drop the tag.

Best regards,
Krzysztof

Re: [PATCH] ALSA: hda/realtek: fix code style (ERROR: else should follow close brace '}')

Posted by Takashi Iwai 1 day, 2 hours ago

On Tue, 31 Mar 2026 09:54:05 +0200,
Lei Huang wrote:
> 
> From: Lei Huang <huanglei@kylinos.cn>
> 
> Fix checkpatch code style errors:
> 
>   ERROR: else should follow close brace '}'
>   #2300: FILE: sound/hda/codecs/realtek/alc269.c:2300:
>   +       }
>   +       else
> 
> Fixes: 31278997add6 ("ALSA: hda/realtek - Add headset quirk for Dell DT")
> Signed-off-by: Lei Huang <huanglei@kylinos.cn>

Thanks, applied to for-next branch.


Takashi

Re: [PATCH] ALSA: hda/realtek: fix code style (ERROR: else should follow close brace '}')

Posted by Krzysztof Kozlowski 29 minutes ago

On 31/03/2026 10:20, Takashi Iwai wrote:
> On Tue, 31 Mar 2026 09:54:05 +0200,
> Lei Huang wrote:
>>
>> From: Lei Huang <huanglei@kylinos.cn>
>>
>> Fix checkpatch code style errors:
>>
>>   ERROR: else should follow close brace '}'
>>   #2300: FILE: sound/hda/codecs/realtek/alc269.c:2300:
>>   +       }
>>   +       else
>>
>> Fixes: 31278997add6 ("ALSA: hda/realtek - Add headset quirk for Dell DT")
>> Signed-off-by: Lei Huang <huanglei@kylinos.cn>
> 
> Thanks, applied to for-next branch.

I hope you dropped the fake Fixes tag. Or at least give people chance to
review it.

Best regards,
Krzysztof