Rename the privacy LED type, struct member, and functions from "pled"
to "led" in preparation for supporting additional LED types beyond
just the privacy LED.
No functional change.
Signed-off-by: Marco Nenciarini <mnencia@kcore.it>
---
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/platform/x86/intel/int3472/discrete.c | 4 ++--
drivers/platform/x86/intel/int3472/led.c | 14 +++++++-------
include/linux/platform_data/x86/int3472.h | 8 ++++----
3 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/platform/x86/intel/int3472/discrete.c b/drivers/platform/x86/intel/int3472/discrete.c
index 1505fc3..cb24763 100644
--- a/drivers/platform/x86/intel/int3472/discrete.c
+++ b/drivers/platform/x86/intel/int3472/discrete.c
@@ -348,7 +348,7 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares,
break;
case INT3472_GPIO_TYPE_PRIVACY_LED:
- ret = skl_int3472_register_pled(int3472, gpio);
+ ret = skl_int3472_register_led(int3472, gpio);
if (ret)
err_msg = "Failed to register LED\n";
@@ -422,7 +422,7 @@ void int3472_discrete_cleanup(struct int3472_discrete_device *int3472)
gpiod_remove_lookup_table(&int3472->gpios);
skl_int3472_unregister_clock(int3472);
- skl_int3472_unregister_pled(int3472);
+ skl_int3472_unregister_led(int3472);
skl_int3472_unregister_regulator(int3472);
}
EXPORT_SYMBOL_NS_GPL(int3472_discrete_cleanup, "INTEL_INT3472_DISCRETE");
diff --git a/drivers/platform/x86/intel/int3472/led.c b/drivers/platform/x86/intel/int3472/led.c
index 86df81a..8bd4903 100644
--- a/drivers/platform/x86/intel/int3472/led.c
+++ b/drivers/platform/x86/intel/int3472/led.c
@@ -6,18 +6,18 @@
#include <linux/leds.h>
#include <linux/platform_data/x86/int3472.h>
-static int int3472_pled_set(struct led_classdev *led_cdev,
+static int int3472_led_set(struct led_classdev *led_cdev,
enum led_brightness brightness)
{
- struct int3472_pled *led = container_of(led_cdev, struct int3472_pled, classdev);
+ struct int3472_led *led = container_of(led_cdev, struct int3472_led, classdev);
gpiod_set_value_cansleep(led->gpio, brightness);
return 0;
}
-int skl_int3472_register_pled(struct int3472_discrete_device *int3472, struct gpio_desc *gpio)
+int skl_int3472_register_led(struct int3472_discrete_device *int3472, struct gpio_desc *gpio)
{
- struct int3472_pled *led = &int3472->pled;
+ struct int3472_led *led = &int3472->led;
char *p;
int ret;
@@ -35,7 +35,7 @@ int skl_int3472_register_pled(struct int3472_discrete_device *int3472, struct gp
led->classdev.name = led->name;
led->classdev.max_brightness = 1;
- led->classdev.brightness_set_blocking = int3472_pled_set;
+ led->classdev.brightness_set_blocking = int3472_led_set;
ret = led_classdev_register(int3472->dev, &led->classdev);
if (ret)
@@ -49,9 +49,9 @@ int skl_int3472_register_pled(struct int3472_discrete_device *int3472, struct gp
return 0;
}
-void skl_int3472_unregister_pled(struct int3472_discrete_device *int3472)
+void skl_int3472_unregister_led(struct int3472_discrete_device *int3472)
{
- struct int3472_pled *led = &int3472->pled;
+ struct int3472_led *led = &int3472->led;
if (IS_ERR_OR_NULL(led->classdev.dev))
return;
diff --git a/include/linux/platform_data/x86/int3472.h b/include/linux/platform_data/x86/int3472.h
index b1b8375..7af6731 100644
--- a/include/linux/platform_data/x86/int3472.h
+++ b/include/linux/platform_data/x86/int3472.h
@@ -121,12 +121,12 @@ struct int3472_discrete_device {
u8 imgclk_index;
} clock;
- struct int3472_pled {
+ struct int3472_led {
struct led_classdev classdev;
struct led_lookup_data lookup;
char name[INT3472_LED_MAX_NAME_LEN];
struct gpio_desc *gpio;
- } pled;
+ } led;
struct int3472_discrete_quirks quirks;
@@ -160,7 +160,7 @@ int skl_int3472_register_regulator(struct int3472_discrete_device *int3472,
const char *second_sensor);
void skl_int3472_unregister_regulator(struct int3472_discrete_device *int3472);
-int skl_int3472_register_pled(struct int3472_discrete_device *int3472, struct gpio_desc *gpio);
-void skl_int3472_unregister_pled(struct int3472_discrete_device *int3472);
+int skl_int3472_register_led(struct int3472_discrete_device *int3472, struct gpio_desc *gpio);
+void skl_int3472_unregister_led(struct int3472_discrete_device *int3472);
#endif
--
2.47.3
On Tue, Mar 31, 2026 at 09:52:02AM +0200, Marco Nenciarini wrote: > Rename the privacy LED type, struct member, and functions from "pled" > to "led" in preparation for supporting additional LED types beyond > just the privacy LED. > > No functional change. Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> ... > -static int int3472_pled_set(struct led_classdev *led_cdev, > +static int int3472_led_set(struct led_classdev *led_cdev, > enum led_brightness brightness) Second line needs to be fixed as well (indentation). -- With Best Regards, Andy Shevchenko
© 2016 - 2026 Red Hat, Inc.