[PATCH v3] staging: rtl8723bs: remove unused RTL8188E antenna selection macros

Mashiro Chen posted 1 patch 1 day, 6 hours ago
drivers/staging/rtl8723bs/hal/odm_types.h | 4 ----
1 file changed, 4 deletions(-)
[PATCH v3] staging: rtl8723bs: remove unused RTL8188E antenna selection macros
Posted by Mashiro Chen 1 day, 6 hours ago
Remove the SET_TX_DESC_ANTSEL_{A,B,C}_88E macros from odm_types.h.
These are leftover dead code for the RTL8188E chip and have no callers
in the rtl8723bs driver. The RTL8188E is a different chip family and
has its own driver at drivers/net/wireless/realtek/rtl8xxxu

This addresses the TODO item "find and remove any code for other chips
that is left over".

Signed-off-by: Mashiro Chen <mashiro.chen@mailbox.org>
---
Changes in v2: Removed incorrect reference to rtl8188eu driver path,
the RTL8188E support is in rtl8xxxu/8188e.c

Changes in v3: Fix incorrect To: Field in v2 (accidentally sent to
mailing list)

 drivers/staging/rtl8723bs/hal/odm_types.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/odm_types.h b/drivers/staging/rtl8723bs/hal/odm_types.h
index 8168dc14e8796..0da662e1493a6 100644
--- a/drivers/staging/rtl8723bs/hal/odm_types.h
+++ b/drivers/staging/rtl8723bs/hal/odm_types.h
@@ -36,10 +36,6 @@ enum hal_status {
 	#define	STA_INFO_T			struct sta_info
 	#define	PSTA_INFO_T		struct sta_info *
 
-	#define SET_TX_DESC_ANTSEL_A_88E(__pTxDesc, __Value) SET_BITS_TO_LE_4BYTE(__pTxDesc+8, 24, 1, __Value)
-	#define SET_TX_DESC_ANTSEL_B_88E(__pTxDesc, __Value) SET_BITS_TO_LE_4BYTE(__pTxDesc+8, 25, 1, __Value)
-	#define SET_TX_DESC_ANTSEL_C_88E(__pTxDesc, __Value) SET_BITS_TO_LE_4BYTE(__pTxDesc+28, 29, 1, __Value)
-
 	/* define useless flag to avoid compile warning */
 	#define	USE_WORKITEM 0
 	#define   FPGA_TWO_MAC_VERIFICATION	0
-- 
2.53.0