[v2] ALSA: hda/realtek: fix bad indentation for alc269

[PATCH v2] ALSA: hda/realtek: fix bad indentation for alc269

Posted by Lei Huang 1 day, 21 hours ago

From: Lei Huang <huanglei@kylinos.cn>

Mention complains about this coding style:

  ERROR: code indent should use tabs where possible
  #6640: FILE: sound/hda/codecs/realtek/alc269.c:6640:
  +        [ALC233_FIXUP_LENOVO_GPIO2_MIC_HOTKEY] = {$

fix it up.

Fixes: 5de5db35350d ("ALSA: hda/realtek - Enable Mute LED for Lenovo platform")
Signed-off-by: Lei Huang <huanglei@kylinos.cn>
---
 sound/hda/codecs/realtek/alc269.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index b6a58852752a..09af4d378b30 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -6637,10 +6637,10 @@ static const struct hda_fixup alc269_fixups[] = {
 		.type = HDA_FIXUP_FUNC,
 		.v.func = alc288_fixup_surface_swap_dacs,
 	},
-        [ALC233_FIXUP_LENOVO_GPIO2_MIC_HOTKEY] = {
-                .type = HDA_FIXUP_FUNC,
-                .v.func = alc233_fixup_lenovo_gpio2_mic_hotkey,
-        },
+	[ALC233_FIXUP_LENOVO_GPIO2_MIC_HOTKEY] = {
+		.type = HDA_FIXUP_FUNC,
+		.v.func = alc233_fixup_lenovo_gpio2_mic_hotkey,
+	},
 	[ALC245_FIXUP_BASS_HP_DAC] = {
 		.type = HDA_FIXUP_FUNC,
 		/* Borrow the DAC routing selected for those Thinkpads */
-- 
2.25.1

Re: [PATCH v2] ALSA: hda/realtek: fix bad indentation for alc269

Posted by Krzysztof Kozlowski 13 hours ago

On 31/03/2026 04:40, Lei Huang wrote:
> From: Lei Huang <huanglei@kylinos.cn>
> 
> Mention complains about this coding style:
> 
>   ERROR: code indent should use tabs where possible
>   #6640: FILE: sound/hda/codecs/realtek/alc269.c:6640:
>   +        [ALC233_FIXUP_LENOVO_GPIO2_MIC_HOTKEY] = {$
> 
> fix it up.
> 
> Fixes: 5de5db35350d ("ALSA: hda/realtek - Enable Mute LED for Lenovo platform")

Really, no. This is not a bug, otherwise explain user observable problem
here.

Best regards,
Krzysztof

Re: [PATCH v2] ALSA: hda/realtek: fix bad indentation for alc269

Posted by Takashi Iwai 1 day, 16 hours ago

On Tue, 31 Mar 2026 04:40:36 +0200,
Lei Huang wrote:
> 
> From: Lei Huang <huanglei@kylinos.cn>
> 
> Mention complains about this coding style:
> 
>   ERROR: code indent should use tabs where possible
>   #6640: FILE: sound/hda/codecs/realtek/alc269.c:6640:
>   +        [ALC233_FIXUP_LENOVO_GPIO2_MIC_HOTKEY] = {$
> 
> fix it up.
> 
> Fixes: 5de5db35350d ("ALSA: hda/realtek - Enable Mute LED for Lenovo platform")
> Signed-off-by: Lei Huang <huanglei@kylinos.cn>

Applied to for-next branch now.  Thanks.


Takashi