Add null pointer checking for ndev and remove unnecessay
rswitch_port_check() wrapper function.
Signed-off-by: Michael Dege <michael.dege@renesas.com>
---
drivers/net/ethernet/renesas/rswitch_l2.c | 15 +++++----------
drivers/net/ethernet/renesas/rswitch_main.c | 2 +-
2 files changed, 6 insertions(+), 11 deletions(-)
diff --git a/drivers/net/ethernet/renesas/rswitch_l2.c b/drivers/net/ethernet/renesas/rswitch_l2.c
index cabf1f92ad0c..ae3857ef9af6 100644
--- a/drivers/net/ethernet/renesas/rswitch_l2.c
+++ b/drivers/net/ethernet/renesas/rswitch_l2.c
@@ -158,11 +158,6 @@ static void rswitch_update_offload_brdev(struct rswitch_private *priv)
rswitch_update_l2_offload(priv);
}
-static bool rswitch_port_check(const struct net_device *ndev)
-{
- return is_rdev(ndev);
-}
-
static void rswitch_port_update_brdev(struct net_device *ndev,
struct net_device *brdev)
{
@@ -199,7 +194,7 @@ static int rswitch_netdevice_event(struct notifier_block *nb,
struct netdev_notifier_changeupper_info *info;
struct net_device *brdev;
- if (!rswitch_port_check(ndev))
+ if (!is_rdev(ndev))
return NOTIFY_DONE;
if (event != NETDEV_CHANGEUPPER)
return NOTIFY_DONE;
@@ -254,12 +249,12 @@ static int rswitch_switchdev_event(struct notifier_block *nb,
if (event == SWITCHDEV_PORT_ATTR_SET) {
ret = switchdev_handle_port_attr_set(ndev, ptr,
- rswitch_port_check,
+ is_rdev,
rswitch_port_attr_set);
return notifier_from_errno(ret);
}
- if (!rswitch_port_check(ndev))
+ if (!is_rdev(ndev))
return NOTIFY_DONE;
return notifier_from_errno(-EOPNOTSUPP);
@@ -278,11 +273,11 @@ static int rswitch_switchdev_blocking_event(struct notifier_block *nb,
return -EOPNOTSUPP;
case SWITCHDEV_PORT_ATTR_SET:
ret = switchdev_handle_port_attr_set(ndev, ptr,
- rswitch_port_check,
+ is_rdev,
rswitch_port_attr_set);
break;
default:
- if (!rswitch_port_check(ndev))
+ if (!is_rdev(ndev))
return NOTIFY_DONE;
ret = -EOPNOTSUPP;
}
diff --git a/drivers/net/ethernet/renesas/rswitch_main.c b/drivers/net/ethernet/renesas/rswitch_main.c
index 60bfa22cc412..fc2c9892aea0 100644
--- a/drivers/net/ethernet/renesas/rswitch_main.c
+++ b/drivers/net/ethernet/renesas/rswitch_main.c
@@ -1962,7 +1962,7 @@ static const struct net_device_ops rswitch_netdev_ops = {
bool is_rdev(const struct net_device *ndev)
{
- return (ndev->netdev_ops == &rswitch_netdev_ops);
+ return ndev && (ndev->netdev_ops == &rswitch_netdev_ops);
}
static int rswitch_get_ts_info(struct net_device *ndev, struct kernel_ethtool_ts_info *info)
--
2.43.0