[PATCH] remoteproc: dead code cleanup in Kconfig for STM32_RPROC

Julian Braha posted 1 patch 1 day, 9 hours ago
drivers/remoteproc/Kconfig | 1 -
1 file changed, 1 deletion(-)
[PATCH] remoteproc: dead code cleanup in Kconfig for STM32_RPROC
Posted by Julian Braha 1 day, 9 hours ago
There is already an 'if REMOTEPROC' condition wrapping this config option,
making the 'depends on PCI' statement a duplicate dependency (dead code).

I propose leaving the outer 'if REMOTEPROC...endif' and removing the
individual 'depends on REMOTEPROC' statement.

This dead code was found by kconfirm, a static analysis tool for Kconfig.

Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
 drivers/remoteproc/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
index ee54436fea5a..c78e431b7b2d 100644
--- a/drivers/remoteproc/Kconfig
+++ b/drivers/remoteproc/Kconfig
@@ -316,7 +316,6 @@ config ST_SLIM_REMOTEPROC
 config STM32_RPROC
 	tristate "STM32 remoteproc support"
 	depends on ARCH_STM32 || COMPILE_TEST
-	depends on REMOTEPROC
 	select MAILBOX
 	help
 	  Say y here to support STM32 MCU processors via the
-- 
2.51.2
Re: [PATCH] remoteproc: dead code cleanup in Kconfig for STM32_RPROC
Posted by Arnaud POULIQUEN 1 day, 1 hour ago
Hello,

On 3/31/26 00:45, Julian Braha wrote:
> There is already an 'if REMOTEPROC' condition wrapping this config option,
> making the 'depends on PCI' statement a duplicate dependency (dead code).
> 
> I propose leaving the outer 'if REMOTEPROC...endif' and removing the
> individual 'depends on REMOTEPROC' statement.
> 
> This dead code was found by kconfirm, a static analysis tool for Kconfig.
> 
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
> ---
>   drivers/remoteproc/Kconfig | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
> index ee54436fea5a..c78e431b7b2d 100644
> --- a/drivers/remoteproc/Kconfig
> +++ b/drivers/remoteproc/Kconfig
> @@ -316,7 +316,6 @@ config ST_SLIM_REMOTEPROC
>   config STM32_RPROC
>   	tristate "STM32 remoteproc support"
>   	depends on ARCH_STM32 || COMPILE_TEST
> -	depends on REMOTEPROC
>   	select MAILBOX
>   	help
>   	  Say y here to support STM32 MCU processors via the

Acked-by:  Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>

Thanks,
Arnaud