This series addresses issues in the basic_types.h header of the
rtl8723bs driver.

In v2, patch 1 now removes all unused WRITEEF/READEF macros entirely
rather than fixing the latent bug, as suggested by Dan Carpenter.
The do-while cleanup patch from v1 is dropped since those macros no
longer exist.

Mashiro Chen (3):
  staging: rtl8723bs: remove unused WRITEEF/READEF byte macros
  staging: rtl8723bs: wrap complex macros with parentheses
  staging: rtl8723bs: remove redundant blank lines in basic_types.h

 .../staging/rtl8723bs/include/basic_types.h   | 38 +++----------------
 1 file changed, 6 insertions(+), 32 deletions(-)

-- 
2.53.0

Hi Mashiro,
Thanks for the v2. This series is a solid improvement. Cleaning up the
basic_types.h header is a necessary step toward eventually getting 
qqthis driver out of staging and into the mainline networking tree.
Here is my formal review of the series.

Patch 1/3: Excellent catch by Dan Carpenter here. Removing the 
WRITEEF/READEF macros is far superior to fixing them. Specifically, 
the latent bug in WRITEEF4BYTE (which incorrectly used EF2BYTE) is now
gone without adding any binary bloat.

Patch 2/3: This correctly silences the COMPLEX_MACRO warnings from 
checkpatch.pl. While these macros are candidates for a full refactor 
into <linux/bitfield.h> eventually, your fix ensures operator 
precedence is respected in the meantime.

Patch 3/3: Clean and trivial.

So for the series:
Reviewed-by: Luka Gejak <luka.gejak@linux.dev>

Best regards,
Luka Gejak