[PATCH] ASoC: amd: ps: fix the pcm device numbering for acp pdm dmic

Syed Saba Kareem posted 1 patch 2 days, 17 hours ago
sound/soc/amd/ps/ps-pdm-dma.c | 1 +
1 file changed, 1 insertion(+)
[PATCH] ASoC: amd: ps: fix the pcm device numbering for acp pdm dmic
Posted by Syed Saba Kareem 2 days, 17 hours ago
Fixed PCM device numbering is required for acp pdm dmic pcm device
to have a common UCM changes.
Set the 'use_dai_pcm_id' flag true in acp pdm dma driver for acp 6.3
platform. To fix the pcm device numbering based on dai_link->id.

Signed-off-by: Syed Saba Kareem <syed.sabakareem@amd.com>
---
 sound/soc/amd/ps/ps-pdm-dma.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/amd/ps/ps-pdm-dma.c b/sound/soc/amd/ps/ps-pdm-dma.c
index c6cd844d458c..04c014349347 100644
--- a/sound/soc/amd/ps/ps-pdm-dma.c
+++ b/sound/soc/amd/ps/ps-pdm-dma.c
@@ -352,6 +352,7 @@ static const struct snd_soc_component_driver acp63_pdm_component = {
 	.hw_params	= acp63_pdm_dma_hw_params,
 	.pointer	= acp63_pdm_dma_pointer,
 	.pcm_new	= acp63_pdm_dma_new,
+	.use_dai_pcm_id = true,
 };
 
 static int acp63_pdm_audio_probe(struct platform_device *pdev)
-- 
2.43.0
Re: [PATCH] ASoC: amd: ps: fix the pcm device numbering for acp pdm dmic
Posted by Mario Limonciello 2 days, 12 hours ago

On 3/30/26 04:46, Syed Saba Kareem wrote:
> Fixed PCM device numbering is required for acp pdm dmic pcm device
> to have a common UCM changes.
> Set the 'use_dai_pcm_id' flag true in acp pdm dma driver for acp 6.3
> platform. To fix the pcm device numbering based on dai_link->id.
> 
> Signed-off-by: Syed Saba Kareem <syed.sabakareem@amd.com>

I suspect we want a stable tag on this too.  Maybe Mark can add when 
committing.

> ---
>   sound/soc/amd/ps/ps-pdm-dma.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/amd/ps/ps-pdm-dma.c b/sound/soc/amd/ps/ps-pdm-dma.c
> index c6cd844d458c..04c014349347 100644
> --- a/sound/soc/amd/ps/ps-pdm-dma.c
> +++ b/sound/soc/amd/ps/ps-pdm-dma.c
> @@ -352,6 +352,7 @@ static const struct snd_soc_component_driver acp63_pdm_component = {
>   	.hw_params	= acp63_pdm_dma_hw_params,
>   	.pointer	= acp63_pdm_dma_pointer,
>   	.pcm_new	= acp63_pdm_dma_new,
> +	.use_dai_pcm_id = true,
>   };
>   
>   static int acp63_pdm_audio_probe(struct platform_device *pdev)
Re: [PATCH] ASoC: amd: ps: fix the pcm device numbering for acp pdm dmic
Posted by Mark Brown 2 days, 12 hours ago
On Mon, Mar 30, 2026 at 09:15:53AM -0500, Mario Limonciello wrote:
> On 3/30/26 04:46, Syed Saba Kareem wrote:

> > Fixed PCM device numbering is required for acp pdm dmic pcm device
> > to have a common UCM changes.
> > Set the 'use_dai_pcm_id' flag true in acp pdm dma driver for acp 6.3
> > platform. To fix the pcm device numbering based on dai_link->id.

> > Signed-off-by: Syed Saba Kareem <syed.sabakareem@amd.com>

> I suspect we want a stable tag on this too.  Maybe Mark can add when
> committing.

It also doesn't have a Fixes:, and also doesn't apply to for-7.0 so if
you want it for stable I'd suggest rebasing and adding an appropriate
Fixes: tag.