[PATCH v4 3/4] staging: media: atomisp: reformat block comments

Serban-Pascu Robert posted 4 patches 3 days, 1 hour ago
[PATCH v4 3/4] staging: media: atomisp: reformat block comments
Posted by Serban-Pascu Robert 3 days, 1 hour ago
Add missing asterisks to block comments to conform with the
standard Linux kernel comment style.

Signed-off-by: Serban-Pascu Robert <robyserbanpascu06@gmail.com>
---
 drivers/staging/media/atomisp/pci/system_global.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/system_global.h b/drivers/staging/media/atomisp/pci/system_global.h
index 6420436d88f7..c65a5be8445a 100644
--- a/drivers/staging/media/atomisp/pci/system_global.h
+++ b/drivers/staging/media/atomisp/pci/system_global.h
@@ -100,8 +100,9 @@ typedef enum {
 	N_GDC_ID
 } gdc_ID_t;
 
-/* this extra define is needed because we want to use it also
-   in the preprocessor, and that doesn't work with enums.
+/*
+ * this extra define is needed because we want to use it also
+ * in the preprocessor, and that doesn't work with enums.
  */
 #define N_GDC_ID_CPP 2
 
-- 
2.43.0
Re: [PATCH v4 3/4] staging: media: atomisp: reformat block comments
Posted by Andy Shevchenko 3 days ago
On Mon, Mar 30, 2026 at 10:36 AM Serban-Pascu Robert
<robyserbanpascu06@gmail.com> wrote:
>
> Add missing asterisks to block comments to conform with the
> standard Linux kernel comment style.

I don't believe it's the only problem like this in the entire driver.
Fix more of them if not all.

...

> -/* this extra define is needed because we want to use it also
> -   in the preprocessor, and that doesn't work with enums.
> +/*
> + * this extra define is needed because we want to use it also
> + * in the preprocessor, and that doesn't work with enums.

You should also respect English grammar:
this --> This
define --> #define

>   */
>  #define N_GDC_ID_CPP 2

-- 
With Best Regards,
Andy Shevchenko