[PATCH v4 1/4] staging: media: atomisp: fix SPDX license identifier style

Serban-Pascu Robert posted 4 patches 3 days ago
[PATCH v4 1/4] staging: media: atomisp: fix SPDX license identifier style
Posted by Serban-Pascu Robert 3 days ago
Use the C-style block comment for the SPDX license identifier in the
header file as per Linux kernel coding standards.

Signed-off-by: Serban-Pascu Robert <robyserbanpascu06@gmail.com>
---
 drivers/staging/media/atomisp/pci/system_global.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/system_global.h b/drivers/staging/media/atomisp/pci/system_global.h
index e8a29f73d67a..c99fb649fb5f 100644
--- a/drivers/staging/media/atomisp/pci/system_global.h
+++ b/drivers/staging/media/atomisp/pci/system_global.h
@@ -1,5 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-// SPDX-License-Identifier: GPL-2.0-or-later
+/* SPDX-License-Identifier: GPL-2.0-or-later */
 /*
  *    (c) 2020 Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
  */
-- 
2.43.0
Re: [PATCH v4 1/4] staging: media: atomisp: fix SPDX license identifier style
Posted by Andy Shevchenko 2 days, 22 hours ago
On Mon, Mar 30, 2026 at 10:36 AM Serban-Pascu Robert
<robyserbanpascu06@gmail.com> wrote:
>
> Use the C-style block comment for the SPDX license identifier in the
> header file as per Linux kernel coding standards.

I am not sure about this. I believe this should be considered with an
additional thought. The thing is, AFAIU, that the header is a
combination of a few from original driver code where they have
different licensing. If Sakari thinks this is okay, the change is
good.

...

> --- a/drivers/staging/media/atomisp/pci/system_global.h
> +++ b/drivers/staging/media/atomisp/pci/system_global.h
> @@ -1,5 +1,4 @@
> -/* SPDX-License-Identifier: GPL-2.0 */
> -// SPDX-License-Identifier: GPL-2.0-or-later
> +/* SPDX-License-Identifier: GPL-2.0-or-later */


-- 
With Best Regards,
Andy Shevchenko