[PATCH] staging: axis-fifo: fix alignment in wait_event_interruptible()

Tanjim Kamal posted 1 patch 1 week ago
drivers/staging/axis-fifo/axis-fifo.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
[PATCH] staging: axis-fifo: fix alignment in wait_event_interruptible()
Posted by Tanjim Kamal 1 week ago
The line was misaligned. Align the arguments with the parenthesis above
and wrap the line to prevent crossing the 100-character limit.

Fix a CHECK issued by scripts/checkpatch.pl.

Signed-off-by: Tanjim Kamal <tanjimkamal1@gmail.com>
---
 drivers/staging/axis-fifo/axis-fifo.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
index 3aa2aa870..1c34de020 100644
--- a/drivers/staging/axis-fifo/axis-fifo.c
+++ b/drivers/staging/axis-fifo/axis-fifo.c
@@ -246,7 +246,8 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf,
 		mutex_lock(&fifo->write_lock);
 
 		ret = wait_event_interruptible(fifo->write_queue,
-			ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >= words_to_write);
+					       ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >=
+					       words_to_write);
 		if (ret)
 			goto end_unlock;
 	}
-- 
2.47.3
Re: [PATCH] staging: axis-fifo: fix alignment in wait_event_interruptible()
Posted by Greg Kroah-Hartman 6 days, 17 hours ago
On Sun, Mar 29, 2026 at 05:23:52PM +0600, Tanjim Kamal wrote:
> The line was misaligned. Align the arguments with the parenthesis above
> and wrap the line to prevent crossing the 100-character limit.
> 
> Fix a CHECK issued by scripts/checkpatch.pl.
> 
> Signed-off-by: Tanjim Kamal <tanjimkamal1@gmail.com>
> ---
>  drivers/staging/axis-fifo/axis-fifo.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
> index 3aa2aa870..1c34de020 100644
> --- a/drivers/staging/axis-fifo/axis-fifo.c
> +++ b/drivers/staging/axis-fifo/axis-fifo.c
> @@ -246,7 +246,8 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf,
>  		mutex_lock(&fifo->write_lock);
>  
>  		ret = wait_event_interruptible(fifo->write_queue,
> -			ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >= words_to_write);
> +					       ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >=
> +					       words_to_write);
>  		if (ret)
>  			goto end_unlock;
>  	}
> -- 
> 2.47.3
> 

No, the original code is fine here.

thanks,

greg k-h