drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +- drivers/staging/rtl8723bs/include/rtw_cmd.h | 2 +- drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
Rename the _Read_MACREG macro to READ_MACREG to resolve the
checkpatch.pl "Avoid CamelCase" warning.
Signed-off-by: Xiyuan Guo <tommyguo024@outlook.com>
---
drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
drivers/staging/rtl8723bs/include/rtw_cmd.h | 2 +-
drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
index c1185c25ed36..eb902c810ac8 100644
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
@@ -11,7 +11,7 @@
#include <linux/delay.h>
static struct _cmd_callback rtw_cmd_callback[] = {
- {GEN_CMD_CODE(_Read_MACREG), NULL}, /*0*/
+ {GEN_CMD_CODE(READ_MACREG), NULL}, /*0*/
{GEN_CMD_CODE(_Write_MACREG), NULL},
{GEN_CMD_CODE(_Read_BBREG), &rtw_getbbrfreg_cmdrsp_callback},
{GEN_CMD_CODE(_Write_BBREG), NULL},
diff --git a/drivers/staging/rtl8723bs/include/rtw_cmd.h b/drivers/staging/rtl8723bs/include/rtw_cmd.h
index c4c3edee809d..d204426799ef 100644
--- a/drivers/staging/rtl8723bs/include/rtw_cmd.h
+++ b/drivers/staging/rtl8723bs/include/rtw_cmd.h
@@ -630,7 +630,7 @@ struct _cmd_callback {
};
enum {
- GEN_CMD_CODE(_Read_MACREG), /*0*/
+ GEN_CMD_CODE(READ_MACREG), /*0*/
GEN_CMD_CODE(_Write_MACREG),
GEN_CMD_CODE(_Read_BBREG),
GEN_CMD_CODE(_Write_BBREG),
diff --git a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
index 95769f90d196..d14cabd5e47c 100644
--- a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
+++ b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h
@@ -679,7 +679,7 @@ void rtw_dummy_event_callback(struct adapter *adapter, u8 *pbuf);
void rtw_fwdbg_event_callback(struct adapter *adapter, u8 *pbuf);
enum {
- GEN_EVT_CODE(_Read_MACREG) = 0, /*0*/
+ GEN_EVT_CODE(READ_MACREG) = 0, /*0*/
GEN_EVT_CODE(_Read_BBREG),
GEN_EVT_CODE(_Read_RFREG),
GEN_EVT_CODE(_Read_EEPROM),
--
2.53.0
On Sun, 29 Mar 2026 03:59:41 -0400, Xiyuan Guo wrote: > Rename the _Read_MACREG macro to READ_MACREG to resolve the > checkpatch.pl "Avoid CamelCase" warning. > > Signed-off-by: Xiyuan Guo <tommyguo024@outlook.com> > --- You sent this patch with tommyguo039@gmail.com but signed with tommyguo024@outlook.com. Also add a changelog after the '---' and wait at least 24h before the next version. Thanks, Bera
On Sun, 29 Mar 2026 at 05:35, Bera Yüzlü <b9788213@gmail.com> wrote: > > On Sun, 29 Mar 2026 03:59:41 -0400, Xiyuan Guo wrote: > > Rename the _Read_MACREG macro to READ_MACREG to resolve the > > checkpatch.pl "Avoid CamelCase" warning. > > > > Signed-off-by: Xiyuan Guo <tommyguo024@outlook.com> > > --- > > You sent this patch with tommyguo039@gmail.com but signed with > tommyguo024@outlook.com. Also add a changelog after the '---' and wait > at least 24h before the next version. > > Thanks, > Bera Thanks for the feedback. I'll fix the email mismatch and add the changelog 24h before v3. Best, Tommy
© 2016 - 2026 Red Hat, Inc.