The WRITEEF4BYTE macro incorrectly used EF2BYTE for
4-byte memory writes. Fix it to use EF4BYTE instead.

Signed-off-by: Mashiro Chen <mashiro.chen@mailbox.org>
---
 drivers/staging/rtl8723bs/include/basic_types.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/include/basic_types.h b/drivers/staging/rtl8723bs/include/basic_types.h
index 8adb95f9f..99b12c724 100644
--- a/drivers/staging/rtl8723bs/include/basic_types.h
+++ b/drivers/staging/rtl8723bs/include/basic_types.h
@@ -64,7 +64,7 @@
 
 #define WRITEEF4BYTE(_ptr, _val)			\
 	do {						\
-		(*((u32 *)(_ptr))) = EF2BYTE(_val);	\
+		(*((u32 *)(_ptr))) = EF4BYTE(_val);	\
 	} while (0)
 
 /*
-- 
2.53.0

On Sat, Mar 28, 2026 at 10:27:06PM +0800, Mashiro Chen wrote:
> The WRITEEF4BYTE macro incorrectly used EF2BYTE for
> 4-byte memory writes. Fix it to use EF4BYTE instead.
> 
> Signed-off-by: Mashiro Chen <mashiro.chen@mailbox.org>
> ---
>  drivers/staging/rtl8723bs/include/basic_types.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/include/basic_types.h b/drivers/staging/rtl8723bs/include/basic_types.h
> index 8adb95f9f..99b12c724 100644
> --- a/drivers/staging/rtl8723bs/include/basic_types.h
> +++ b/drivers/staging/rtl8723bs/include/basic_types.h
> @@ -64,7 +64,7 @@
>  
>  #define WRITEEF4BYTE(_ptr, _val)			\


This macro is never used so just delete it instead.

regards,
dan carpenter

>  	do {						\
> -		(*((u32 *)(_ptr))) = EF2BYTE(_val);	\
> +		(*((u32 *)(_ptr))) = EF4BYTE(_val);	\
>  	} while (0)
>  
>  /*
> -- 
> 2.53.0
>

Hi Dan,

Thank you for the feedback. After further investigation,
WRITEEF2BYTE, WRITEEF1BYTE, READEF4BYTE, READEF2BYTE and
READEF1BYTE are also unused. I will delete all of them in v2.

Thanks,
Mashiro Chen