On Thu, Mar 26, 2026 at 09:42:55PM -0400, Zi Yan wrote:
> Any file system with large folio support and the supported orders include
> PMD_ORDER can be used.
>
> Signed-off-by: Zi Yan <ziy@nvidia.com>
Thanks :) Wondered if you'd fix these up :) So:
Reviewed-by: Lorenzo Stoakes (Oracle) <ljs@kernel.org>
Cheers, Lorenzo
> ---
> tools/testing/selftests/mm/guard-regions.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/tools/testing/selftests/mm/guard-regions.c b/tools/testing/selftests/mm/guard-regions.c
> index 48e8b1539be3..13e77e48b6ef 100644
> --- a/tools/testing/selftests/mm/guard-regions.c
> +++ b/tools/testing/selftests/mm/guard-regions.c
> @@ -2205,7 +2205,7 @@ TEST_F(guard_regions, collapse)
>
> /*
> * We must close and re-open local-file backed as read-only for
> - * CONFIG_READ_ONLY_THP_FOR_FS to work.
> + * MADV_COLLAPSE to work.
> */
> if (variant->backing == LOCAL_FILE_BACKED) {
> ASSERT_EQ(close(self->fd), 0);
> @@ -2237,9 +2237,10 @@ TEST_F(guard_regions, collapse)
> /*
> * Now collapse the entire region. This should fail in all cases.
> *
> - * The madvise() call will also fail if CONFIG_READ_ONLY_THP_FOR_FS is
> - * not set for the local file case, but we can't differentiate whether
> - * this occurred or if the collapse was rightly rejected.
> + * The madvise() call will also fail if the file system does not support
> + * large folio or the supported orders do not include PMD_ORDER for the
> + * local file case, but we can't differentiate whether this occurred or
> + * if the collapse was rightly rejected.
> */
> EXPECT_NE(madvise(ptr, size, MADV_COLLAPSE), 0);
>
> --
> 2.43.0
>