Remove modem related bindings from MSM8953 rpmpd because MSM8953 MSS
is using mss-supply as a regulator usually it is pm8953_s1.
Split SDM632 bindings from MSM8953 because SDM632 is using mss-supply
as a pm domain.
Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
---
.../devicetree/bindings/power/qcom,rpmpd.yaml | 1 +
include/dt-bindings/power/qcom-rpmpd.h | 20 +++++++++++++-------
2 files changed, 14 insertions(+), 7 deletions(-)
diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
index 8174ceeab572..659936d6a46e 100644
--- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
+++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
@@ -48,6 +48,7 @@ properties:
- qcom,sc7280-rpmhpd
- qcom,sc8180x-rpmhpd
- qcom,sc8280xp-rpmhpd
+ - qcom,sdm632-rpmpd
- qcom,sdm660-rpmpd
- qcom,sdm670-rpmhpd
- qcom,sdm845-rpmhpd
diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h
index 4371ac941f29..2d82434b993c 100644
--- a/include/dt-bindings/power/qcom-rpmpd.h
+++ b/include/dt-bindings/power/qcom-rpmpd.h
@@ -84,13 +84,11 @@
#define QM215_VDDMX_AO MSM8917_VDDMX_AO
/* MSM8953 Power Domain Indexes */
-#define MSM8953_VDDMD 0
-#define MSM8953_VDDMD_AO 1
-#define MSM8953_VDDCX 2
-#define MSM8953_VDDCX_AO 3
-#define MSM8953_VDDCX_VFL 4
-#define MSM8953_VDDMX 5
-#define MSM8953_VDDMX_AO 6
+#define MSM8953_VDDCX RPMPD_VDDCX
+#define MSM8953_VDDCX_AO RPMPD_VDDCX_AO
+#define MSM8953_VDDCX_VFL RPMPD_VDDCX_VFL
+#define MSM8953_VDDMX RPMPD_VDDMX
+#define MSM8953_VDDMX_AO RPMPD_VDDMX_AO
/* MSM8974 Power Domain Indexes */
#define MSM8974_VDDCX 0
@@ -156,6 +154,14 @@
#define QCS404_LPIMX 5
#define QCS404_LPIMX_VFL 6
+/* SDM632 Power Domain Indexes */
+#define SDM632_VDDMD 0
+#define SDM632_VDDCX 1
+#define SDM632_VDDCX_AO 2
+#define SDM632_VDDCX_VFL 3
+#define SDM632_VDDMX 4
+#define SDM632_VDDMX_AO 5
+
/* SDM660 Power Domains */
#define SDM660_VDDCX RPMPD_VDDCX
#define SDM660_VDDCX_AO RPMPD_VDDCX_AO
--
2.53.0
On Fri, Mar 27, 2026 at 09:11:43PM +0100, Barnabás Czémán wrote: > Remove modem related bindings from MSM8953 rpmpd because MSM8953 MSS > is using mss-supply as a regulator usually it is pm8953_s1. > Split SDM632 bindings from MSM8953 because SDM632 is using mss-supply > as a pm domain. > > Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org> > --- > .../devicetree/bindings/power/qcom,rpmpd.yaml | 1 + > include/dt-bindings/power/qcom-rpmpd.h | 20 +++++++++++++------- > 2 files changed, 14 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml > index 8174ceeab572..659936d6a46e 100644 > --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml > +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml > @@ -48,6 +48,7 @@ properties: > - qcom,sc7280-rpmhpd > - qcom,sc8180x-rpmhpd > - qcom,sc8280xp-rpmhpd > + - qcom,sdm632-rpmpd > - qcom,sdm660-rpmpd > - qcom,sdm670-rpmhpd > - qcom,sdm845-rpmhpd > diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h > index 4371ac941f29..2d82434b993c 100644 > --- a/include/dt-bindings/power/qcom-rpmpd.h > +++ b/include/dt-bindings/power/qcom-rpmpd.h > @@ -84,13 +84,11 @@ > #define QM215_VDDMX_AO MSM8917_VDDMX_AO > > /* MSM8953 Power Domain Indexes */ > -#define MSM8953_VDDMD 0 ABI break / impact and due to two changes combined I don't really understand why. Why MSS using mss-supply makes this ABI invalid/wrong? > -#define MSM8953_VDDMD_AO 1 > -#define MSM8953_VDDCX 2 > -#define MSM8953_VDDCX_AO 3 > -#define MSM8953_VDDCX_VFL 4 > -#define MSM8953_VDDMX 5 > -#define MSM8953_VDDMX_AO 6 > +#define MSM8953_VDDCX RPMPD_VDDCX > +#define MSM8953_VDDCX_AO RPMPD_VDDCX_AO > +#define MSM8953_VDDCX_VFL RPMPD_VDDCX_VFL > +#define MSM8953_VDDMX RPMPD_VDDMX > +#define MSM8953_VDDMX_AO RPMPD_VDDMX_AO I don't see how this is related to new compatible and SDM632. > > /* MSM8974 Power Domain Indexes */ > #define MSM8974_VDDCX 0 > @@ -156,6 +154,14 @@ > #define QCS404_LPIMX 5 > #define QCS404_LPIMX_VFL 6 Best regards, Krzysztof
On Fri, Mar 27, 2026 at 09:11:43PM +0100, Barnabás Czémán wrote: > Remove modem related bindings from MSM8953 rpmpd because MSM8953 MSS > is using mss-supply as a regulator usually it is pm8953_s1. > Split SDM632 bindings from MSM8953 because SDM632 is using mss-supply > as a pm domain. > > Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org> > --- > .../devicetree/bindings/power/qcom,rpmpd.yaml | 1 + > include/dt-bindings/power/qcom-rpmpd.h | 20 +++++++++++++------- > 2 files changed, 14 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml > index 8174ceeab572..659936d6a46e 100644 > --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml > +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml > @@ -48,6 +48,7 @@ properties: > - qcom,sc7280-rpmhpd > - qcom,sc8180x-rpmhpd > - qcom,sc8280xp-rpmhpd > + - qcom,sdm632-rpmpd > - qcom,sdm660-rpmpd > - qcom,sdm670-rpmhpd > - qcom,sdm845-rpmhpd > diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h > index 4371ac941f29..2d82434b993c 100644 > --- a/include/dt-bindings/power/qcom-rpmpd.h > +++ b/include/dt-bindings/power/qcom-rpmpd.h > @@ -84,13 +84,11 @@ > #define QM215_VDDMX_AO MSM8917_VDDMX_AO > > /* MSM8953 Power Domain Indexes */ > -#define MSM8953_VDDMD 0 > -#define MSM8953_VDDMD_AO 1 > -#define MSM8953_VDDCX 2 > -#define MSM8953_VDDCX_AO 3 > -#define MSM8953_VDDCX_VFL 4 > -#define MSM8953_VDDMX 5 > -#define MSM8953_VDDMX_AO 6 > +#define MSM8953_VDDCX RPMPD_VDDCX > +#define MSM8953_VDDCX_AO RPMPD_VDDCX_AO > +#define MSM8953_VDDCX_VFL RPMPD_VDDCX_VFL > +#define MSM8953_VDDMX RPMPD_VDDMX > +#define MSM8953_VDDMX_AO RPMPD_VDDMX_AO Well, no. This is an ABI break. It will make previous DT to stop from working. You can drop unused indices, but you can not change the values used by the existing domains. > > /* MSM8974 Power Domain Indexes */ > #define MSM8974_VDDCX 0 > @@ -156,6 +154,14 @@ > #define QCS404_LPIMX 5 > #define QCS404_LPIMX_VFL 6 > > +/* SDM632 Power Domain Indexes */ > +#define SDM632_VDDMD 0 > +#define SDM632_VDDCX 1 > +#define SDM632_VDDCX_AO 2 > +#define SDM632_VDDCX_VFL 3 > +#define SDM632_VDDMX 4 > +#define SDM632_VDDMX_AO 5 Please use RPMHPD_* instead of introducing new entries. > + > /* SDM660 Power Domains */ > #define SDM660_VDDCX RPMPD_VDDCX > #define SDM660_VDDCX_AO RPMPD_VDDCX_AO > > -- > 2.53.0 > -- With best wishes Dmitry
On 2026-03-27 21:26, Dmitry Baryshkov wrote: > On Fri, Mar 27, 2026 at 09:11:43PM +0100, Barnabás Czémán wrote: >> Remove modem related bindings from MSM8953 rpmpd because MSM8953 MSS >> is using mss-supply as a regulator usually it is pm8953_s1. >> Split SDM632 bindings from MSM8953 because SDM632 is using mss-supply >> as a pm domain. >> >> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org> >> --- >> .../devicetree/bindings/power/qcom,rpmpd.yaml | 1 + >> include/dt-bindings/power/qcom-rpmpd.h | 20 >> +++++++++++++------- >> 2 files changed, 14 insertions(+), 7 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml >> b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml >> index 8174ceeab572..659936d6a46e 100644 >> --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml >> +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml >> @@ -48,6 +48,7 @@ properties: >> - qcom,sc7280-rpmhpd >> - qcom,sc8180x-rpmhpd >> - qcom,sc8280xp-rpmhpd >> + - qcom,sdm632-rpmpd >> - qcom,sdm660-rpmpd >> - qcom,sdm670-rpmhpd >> - qcom,sdm845-rpmhpd >> diff --git a/include/dt-bindings/power/qcom-rpmpd.h >> b/include/dt-bindings/power/qcom-rpmpd.h >> index 4371ac941f29..2d82434b993c 100644 >> --- a/include/dt-bindings/power/qcom-rpmpd.h >> +++ b/include/dt-bindings/power/qcom-rpmpd.h >> @@ -84,13 +84,11 @@ >> #define QM215_VDDMX_AO MSM8917_VDDMX_AO >> >> /* MSM8953 Power Domain Indexes */ >> -#define MSM8953_VDDMD 0 >> -#define MSM8953_VDDMD_AO 1 >> -#define MSM8953_VDDCX 2 >> -#define MSM8953_VDDCX_AO 3 >> -#define MSM8953_VDDCX_VFL 4 >> -#define MSM8953_VDDMX 5 >> -#define MSM8953_VDDMX_AO 6 >> +#define MSM8953_VDDCX RPMPD_VDDCX >> +#define MSM8953_VDDCX_AO RPMPD_VDDCX_AO >> +#define MSM8953_VDDCX_VFL RPMPD_VDDCX_VFL >> +#define MSM8953_VDDMX RPMPD_VDDMX >> +#define MSM8953_VDDMX_AO RPMPD_VDDMX_AO > > Well, no. This is an ABI break. It will make previous DT to stop from > working. You can drop unused indices, but you can not change the values > used by the existing domains. Do these indices never can be changed? > >> >> /* MSM8974 Power Domain Indexes */ >> #define MSM8974_VDDCX 0 >> @@ -156,6 +154,14 @@ >> #define QCS404_LPIMX 5 >> #define QCS404_LPIMX_VFL 6 >> >> +/* SDM632 Power Domain Indexes */ >> +#define SDM632_VDDMD 0 >> +#define SDM632_VDDCX 1 >> +#define SDM632_VDDCX_AO 2 >> +#define SDM632_VDDCX_VFL 3 >> +#define SDM632_VDDMX 4 >> +#define SDM632_VDDMX_AO 5 > > Please use RPMHPD_* instead of introducing new entries. I do not understand completely, should I use RPHPD bindings in rpmpd driver or I should use rpmhpd driver for SDM632? > >> + >> /* SDM660 Power Domains */ >> #define SDM660_VDDCX RPMPD_VDDCX >> #define SDM660_VDDCX_AO RPMPD_VDDCX_AO >> >> -- >> 2.53.0 >>
On 3/28/26 9:22 AM, Barnabás Czémán wrote: > On 2026-03-27 21:26, Dmitry Baryshkov wrote: >> On Fri, Mar 27, 2026 at 09:11:43PM +0100, Barnabás Czémán wrote: >>> Remove modem related bindings from MSM8953 rpmpd because MSM8953 MSS >>> is using mss-supply as a regulator usually it is pm8953_s1. >>> Split SDM632 bindings from MSM8953 because SDM632 is using mss-supply >>> as a pm domain. >>> >>> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org> >>> --- >>> .../devicetree/bindings/power/qcom,rpmpd.yaml | 1 + >>> include/dt-bindings/power/qcom-rpmpd.h | 20 +++++++++++++------- >>> 2 files changed, 14 insertions(+), 7 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml >>> index 8174ceeab572..659936d6a46e 100644 >>> --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml >>> +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml >>> @@ -48,6 +48,7 @@ properties: >>> - qcom,sc7280-rpmhpd >>> - qcom,sc8180x-rpmhpd >>> - qcom,sc8280xp-rpmhpd >>> + - qcom,sdm632-rpmpd >>> - qcom,sdm660-rpmpd >>> - qcom,sdm670-rpmhpd >>> - qcom,sdm845-rpmhpd >>> diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h >>> index 4371ac941f29..2d82434b993c 100644 >>> --- a/include/dt-bindings/power/qcom-rpmpd.h >>> +++ b/include/dt-bindings/power/qcom-rpmpd.h >>> @@ -84,13 +84,11 @@ >>> #define QM215_VDDMX_AO MSM8917_VDDMX_AO >>> >>> /* MSM8953 Power Domain Indexes */ >>> -#define MSM8953_VDDMD 0 >>> -#define MSM8953_VDDMD_AO 1 >>> -#define MSM8953_VDDCX 2 >>> -#define MSM8953_VDDCX_AO 3 >>> -#define MSM8953_VDDCX_VFL 4 >>> -#define MSM8953_VDDMX 5 >>> -#define MSM8953_VDDMX_AO 6 >>> +#define MSM8953_VDDCX RPMPD_VDDCX >>> +#define MSM8953_VDDCX_AO RPMPD_VDDCX_AO >>> +#define MSM8953_VDDCX_VFL RPMPD_VDDCX_VFL >>> +#define MSM8953_VDDMX RPMPD_VDDMX >>> +#define MSM8953_VDDMX_AO RPMPD_VDDMX_AO >> >> Well, no. This is an ABI break. It will make previous DT to stop from >> working. You can drop unused indices, but you can not change the values >> used by the existing domains. > Do these indices never can be changed? Yes, values in include/dt-bindings are supposed to never change Here you're e.g. changing the "msm8953 domain 0" from translating into VDDMD to translating into VDDCX (because RPMPD_VDDCX is defined as 0) Some other older platforms were converted to use these macros, because the indices happened to match Konrad
On Sat, Mar 28, 2026 at 09:22:19AM +0100, Barnabás Czémán wrote: > On 2026-03-27 21:26, Dmitry Baryshkov wrote: > > On Fri, Mar 27, 2026 at 09:11:43PM +0100, Barnabás Czémán wrote: > > > Remove modem related bindings from MSM8953 rpmpd because MSM8953 MSS > > > is using mss-supply as a regulator usually it is pm8953_s1. > > > Split SDM632 bindings from MSM8953 because SDM632 is using mss-supply > > > as a pm domain. > > > > > > Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org> > > > --- > > > .../devicetree/bindings/power/qcom,rpmpd.yaml | 1 + > > > include/dt-bindings/power/qcom-rpmpd.h | 20 > > > +++++++++++++------- > > > 2 files changed, 14 insertions(+), 7 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml > > > b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml > > > index 8174ceeab572..659936d6a46e 100644 > > > --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml > > > +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml > > > @@ -48,6 +48,7 @@ properties: > > > - qcom,sc7280-rpmhpd > > > - qcom,sc8180x-rpmhpd > > > - qcom,sc8280xp-rpmhpd > > > + - qcom,sdm632-rpmpd > > > - qcom,sdm660-rpmpd > > > - qcom,sdm670-rpmhpd > > > - qcom,sdm845-rpmhpd > > > diff --git a/include/dt-bindings/power/qcom-rpmpd.h > > > b/include/dt-bindings/power/qcom-rpmpd.h > > > index 4371ac941f29..2d82434b993c 100644 > > > --- a/include/dt-bindings/power/qcom-rpmpd.h > > > +++ b/include/dt-bindings/power/qcom-rpmpd.h > > > @@ -84,13 +84,11 @@ > > > #define QM215_VDDMX_AO MSM8917_VDDMX_AO > > > > > > /* MSM8953 Power Domain Indexes */ > > > -#define MSM8953_VDDMD 0 > > > -#define MSM8953_VDDMD_AO 1 > > > -#define MSM8953_VDDCX 2 > > > -#define MSM8953_VDDCX_AO 3 > > > -#define MSM8953_VDDCX_VFL 4 > > > -#define MSM8953_VDDMX 5 > > > -#define MSM8953_VDDMX_AO 6 > > > +#define MSM8953_VDDCX RPMPD_VDDCX > > > +#define MSM8953_VDDCX_AO RPMPD_VDDCX_AO > > > +#define MSM8953_VDDCX_VFL RPMPD_VDDCX_VFL > > > +#define MSM8953_VDDMX RPMPD_VDDMX > > > +#define MSM8953_VDDMX_AO RPMPD_VDDMX_AO > > > > Well, no. This is an ABI break. It will make previous DT to stop from > > working. You can drop unused indices, but you can not change the values > > used by the existing domains. > Do these indices never can be changed? You can add new indices and you can (with some care) drop existing incorrecr or unused ones. You can't reassign indices though. The rule of thumb is that old DTs should continue to work without rebuilding. > > > > > > > > /* MSM8974 Power Domain Indexes */ > > > #define MSM8974_VDDCX 0 > > > @@ -156,6 +154,14 @@ > > > #define QCS404_LPIMX 5 > > > #define QCS404_LPIMX_VFL 6 > > > > > > +/* SDM632 Power Domain Indexes */ > > > +#define SDM632_VDDMD 0 > > > +#define SDM632_VDDCX 1 > > > +#define SDM632_VDDCX_AO 2 > > > +#define SDM632_VDDCX_VFL 3 > > > +#define SDM632_VDDMX 4 > > > +#define SDM632_VDDMX_AO 5 > > > > Please use RPMHPD_* instead of introducing new entries. > I do not understand completely, should I use RPHPD bindings in rpmpd driver > or > I should use rpmhpd driver for SDM632? Sorry, I meant RPMPD_* > > > > > + > > > /* SDM660 Power Domains */ > > > #define SDM660_VDDCX RPMPD_VDDCX > > > #define SDM660_VDDCX_AO RPMPD_VDDCX_AO > > > > > > -- > > > 2.53.0 > > > -- With best wishes Dmitry
© 2016 - 2026 Red Hat, Inc.