gpio: kill dev-sync-probe

[PATCH 0/4] gpio: kill dev-sync-probe

Bartosz Golaszewski posted 4 patches 6 days, 5 hours ago

Download series mbox

drivers/gpio/Kconfig           |  6 ---
drivers/gpio/Makefile          |  3 --
drivers/gpio/dev-sync-probe.c  | 97 ------------------------------------------
drivers/gpio/dev-sync-probe.h  | 25 -----------
drivers/gpio/gpio-aggregator.c | 38 +++++++++--------
drivers/gpio/gpio-sim.c        | 49 ++++++++++++---------
drivers/gpio/gpio-virtuser.c   | 30 ++++++++-----
7 files changed, 70 insertions(+), 178 deletions(-)

Expand all Fold all

[PATCH 0/4] gpio: kill dev-sync-probe

Posted by Bartosz Golaszewski 6 days, 5 hours ago

I came up with this elaborate mechanism to synchronously wait for the
platform devices activated over configs to probe, involving notifiers
and completions (which was later factored out into what is today the
dev-sync-probe module) because I didn't know any better. It turns out
there's an idiomatic way of achieving the same goal with much less LOC.
Port the three drivers to using a combination of wait_for_probe() and
device_is_bound() and remove the dev-sync-probe module.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
Bartosz Golaszewski (4):
      gpio: sim: stop using dev-sync-probe
      gpio: aggregator: stop using dev-sync-probe
      gpio: virtuser: stop using dev-sync-probe
      gpio: remove dev-sync-probe

 drivers/gpio/Kconfig           |  6 ---
 drivers/gpio/Makefile          |  3 --
 drivers/gpio/dev-sync-probe.c  | 97 ------------------------------------------
 drivers/gpio/dev-sync-probe.h  | 25 -----------
 drivers/gpio/gpio-aggregator.c | 38 +++++++++--------
 drivers/gpio/gpio-sim.c        | 49 ++++++++++++---------
 drivers/gpio/gpio-virtuser.c   | 30 ++++++++-----
 7 files changed, 70 insertions(+), 178 deletions(-)
---
base-commit: e77a5a5cfe43b4c25bd44a3818e487033287517f
change-id: 20260327-gpio-kill-dev-sync-probe-4027fab0c0a6

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

Re: [PATCH 0/4] gpio: kill dev-sync-probe

Posted by Linus Walleij 6 days, 2 hours ago

On Fri, Mar 27, 2026 at 11:31 AM Bartosz Golaszewski
<bartosz.golaszewski@oss.qualcomm.com> wrote:

> I came up with this elaborate mechanism to synchronously wait for the
> platform devices activated over configs to probe, involving notifiers
> and completions (which was later factored out into what is today the
> dev-sync-probe module) because I didn't know any better. It turns out
> there's an idiomatic way of achieving the same goal with much less LOC.
> Port the three drivers to using a combination of wait_for_probe() and
> device_is_bound() and remove the dev-sync-probe module.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

That looks way better!
Reviewed-by: Linus Walleij <linusw@kernel.org>

Yours,
Linus Walleij