[v1] media: rzg2l-cru: Rework slot programming for V2H/G3E

[PATCH 07/14] media: rzg2l-cru: Remove wrong locking comment

Posted by Jacopo Mondi 5 days, 22 hours ago

From: Jacopo Mondi <jacopo.mondi+renesas@ideasonboard.com>

A function documented as "need to hold qlock before calling" actually
takes the lock itself.

Drop the comment and prepare to replace it with proper annotations where
appropriate.

Signed-off-by: Jacopo Mondi <jacopo.mondi+renesas@ideasonboard.com>
---
 drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
index 2e94788c3a13..27079c17a54c 100644
--- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
+++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
@@ -106,7 +106,6 @@ __rzg2l_cru_read_constant(struct rzg2l_cru_dev *cru, u32 offset)
 	 __rzg2l_cru_read_constant(cru, offset) : \
 	 __rzg2l_cru_read(cru, offset))
 
-/* Need to hold qlock before calling */
 static void return_unused_buffers(struct rzg2l_cru_dev *cru,
 				  enum vb2_buffer_state state)
 {

-- 
2.53.0

Re: [PATCH 07/14] media: rzg2l-cru: Remove wrong locking comment

Posted by Lad, Prabhakar 2 days, 7 hours ago

On Fri, Mar 27, 2026 at 5:21 PM Jacopo Mondi
<jacopo.mondi@ideasonboard.com> wrote:
>
> From: Jacopo Mondi <jacopo.mondi+renesas@ideasonboard.com>
>
> A function documented as "need to hold qlock before calling" actually
> takes the lock itself.
>
> Drop the comment and prepare to replace it with proper annotations where
> appropriate.
>
> Signed-off-by: Jacopo Mondi <jacopo.mondi+renesas@ideasonboard.com>
> ---
>  drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 1 -
>  1 file changed, 1 deletion(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Cheers,
Prabhakar

> diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> index 2e94788c3a13..27079c17a54c 100644
> --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> @@ -106,7 +106,6 @@ __rzg2l_cru_read_constant(struct rzg2l_cru_dev *cru, u32 offset)
>          __rzg2l_cru_read_constant(cru, offset) : \
>          __rzg2l_cru_read(cru, offset))
>
> -/* Need to hold qlock before calling */
>  static void return_unused_buffers(struct rzg2l_cru_dev *cru,
>                                   enum vb2_buffer_state state)
>  {
>
> --
> 2.53.0
>
>

Re: [PATCH 07/14] media: rzg2l-cru: Remove wrong locking comment

Posted by Tommaso Merciai 3 days, 1 hour ago

Hi Jacopo,
Thanks for your patch.

On Fri, Mar 27, 2026 at 06:10:12PM +0100, Jacopo Mondi wrote:
> From: Jacopo Mondi <jacopo.mondi+renesas@ideasonboard.com>
> 
> A function documented as "need to hold qlock before calling" actually
> takes the lock itself.
> 
> Drop the comment and prepare to replace it with proper annotations where
> appropriate.
> 
> Signed-off-by: Jacopo Mondi <jacopo.mondi+renesas@ideasonboard.com>

Reviewed-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>

Kind Regards,
Tommaso

> ---
>  drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> index 2e94788c3a13..27079c17a54c 100644
> --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> @@ -106,7 +106,6 @@ __rzg2l_cru_read_constant(struct rzg2l_cru_dev *cru, u32 offset)
>  	 __rzg2l_cru_read_constant(cru, offset) : \
>  	 __rzg2l_cru_read(cru, offset))
>  
> -/* Need to hold qlock before calling */
>  static void return_unused_buffers(struct rzg2l_cru_dev *cru,
>  				  enum vb2_buffer_state state)
>  {
> 
> -- 
> 2.53.0
>

Re: [PATCH 07/14] media: rzg2l-cru: Remove wrong locking comment

Posted by Dan Scally 3 days, 8 hours ago

Hi Jacopo

On 27/03/2026 17:10, Jacopo Mondi wrote:
> From: Jacopo Mondi <jacopo.mondi+renesas@ideasonboard.com>
> 
> A function documented as "need to hold qlock before calling" actually
> takes the lock itself.
> 
> Drop the comment and prepare to replace it with proper annotations where
> appropriate.
> 
> Signed-off-by: Jacopo Mondi <jacopo.mondi+renesas@ideasonboard.com>
> ---

Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>


>   drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> index 2e94788c3a13..27079c17a54c 100644
> --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> @@ -106,7 +106,6 @@ __rzg2l_cru_read_constant(struct rzg2l_cru_dev *cru, u32 offset)
>   	 __rzg2l_cru_read_constant(cru, offset) : \
>   	 __rzg2l_cru_read(cru, offset))
>   
> -/* Need to hold qlock before calling */
>   static void return_unused_buffers(struct rzg2l_cru_dev *cru,
>   				  enum vb2_buffer_state state)
>   {
>