[PATCH v2] rust_binder: Downgrade startup warning to info

Carlos Llamas posted 1 patch 6 days, 18 hours ago
drivers/android/binder/rust_binder_main.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH v2] rust_binder: Downgrade startup warning to info
Posted by Carlos Llamas 6 days, 18 hours ago
From: Pedro Montes Alcalde <pedro.montes.alcalde@gmail.com>

The "Loaded Rust Binder." message is logged during normal
initialization and does not indicate an error/warning condition.

Logging it as a warning creates unnecessary noise and may
mislead developers when inspecting logs. Log it as info instead

Signed-off-by: Pedro Montes Alcalde <pedro.montes.alcalde@gmail.com>
Acked-by: Carlos Llamas <cmllamas@google.com>
Signed-off-by: Carlos Llamas <cmllamas@google.com>
---
v2: fixed patch formatting, added tags.

 drivers/android/binder/rust_binder_main.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/android/binder/rust_binder_main.rs b/drivers/android/binder/rust_binder_main.rs
index aa5f2a75adb4..3907291a33c9 100644
--- a/drivers/android/binder/rust_binder_main.rs
+++ b/drivers/android/binder/rust_binder_main.rs
@@ -292,7 +292,7 @@ fn init(_module: &'static kernel::ThisModule) -> Result<Self> {
         // SAFETY: The module initializer never runs twice, so we only call this once.
         unsafe { crate::context::CONTEXTS.init() };
 
-        pr_warn!("Loaded Rust Binder.");
+        pr_info!("Loaded Rust Binder.");
 
         BINDER_SHRINKER.register(c"android-binder")?;
 
-- 
2.53.0.1018.g2bb0e51243-goog
Re: [PATCH v2] rust_binder: Downgrade startup warning to info
Posted by Greg KH 6 days, 10 hours ago
On Thu, Mar 26, 2026 at 11:07:12PM +0000, Carlos Llamas wrote:
> From: Pedro Montes Alcalde <pedro.montes.alcalde@gmail.com>
> 
> The "Loaded Rust Binder." message is logged during normal
> initialization and does not indicate an error/warning condition.
> 
> Logging it as a warning creates unnecessary noise and may
> mislead developers when inspecting logs. Log it as info instead
> 
> Signed-off-by: Pedro Montes Alcalde <pedro.montes.alcalde@gmail.com>
> Acked-by: Carlos Llamas <cmllamas@google.com>
> Signed-off-by: Carlos Llamas <cmllamas@google.com>
> ---
> v2: fixed patch formatting, added tags.
> 
>  drivers/android/binder/rust_binder_main.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/android/binder/rust_binder_main.rs b/drivers/android/binder/rust_binder_main.rs
> index aa5f2a75adb4..3907291a33c9 100644
> --- a/drivers/android/binder/rust_binder_main.rs
> +++ b/drivers/android/binder/rust_binder_main.rs
> @@ -292,7 +292,7 @@ fn init(_module: &'static kernel::ThisModule) -> Result<Self> {
>          // SAFETY: The module initializer never runs twice, so we only call this once.
>          unsafe { crate::context::CONTEXTS.init() };
>  
> -        pr_warn!("Loaded Rust Binder.");
> +        pr_info!("Loaded Rust Binder.");

When drivers work properly, they are quiet, so why print anything out at
all here?

thanks,

greg k-h
Re: [PATCH v2] rust_binder: Downgrade startup warning to info
Posted by Alice Ryhl 6 days, 7 hours ago
On Fri, Mar 27, 2026 at 07:24:35AM +0100, Greg KH wrote:
> On Thu, Mar 26, 2026 at 11:07:12PM +0000, Carlos Llamas wrote:
> > From: Pedro Montes Alcalde <pedro.montes.alcalde@gmail.com>
> > 
> > The "Loaded Rust Binder." message is logged during normal
> > initialization and does not indicate an error/warning condition.
> > 
> > Logging it as a warning creates unnecessary noise and may
> > mislead developers when inspecting logs. Log it as info instead
> > 
> > Signed-off-by: Pedro Montes Alcalde <pedro.montes.alcalde@gmail.com>
> > Acked-by: Carlos Llamas <cmllamas@google.com>
> > Signed-off-by: Carlos Llamas <cmllamas@google.com>
> > ---
> > v2: fixed patch formatting, added tags.
> > 
> >  drivers/android/binder/rust_binder_main.rs | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/android/binder/rust_binder_main.rs b/drivers/android/binder/rust_binder_main.rs
> > index aa5f2a75adb4..3907291a33c9 100644
> > --- a/drivers/android/binder/rust_binder_main.rs
> > +++ b/drivers/android/binder/rust_binder_main.rs
> > @@ -292,7 +292,7 @@ fn init(_module: &'static kernel::ThisModule) -> Result<Self> {
> >          // SAFETY: The module initializer never runs twice, so we only call this once.
> >          unsafe { crate::context::CONTEXTS.init() };
> >  
> > -        pr_warn!("Loaded Rust Binder.");
> > +        pr_info!("Loaded Rust Binder.");
> 
> When drivers work properly, they are quiet, so why print anything out at
> all here?

Yeah let's just delete this. It's not needed anymore.

Alice