[v2] ASoC: qcom: audioreach: explicitly enable speaker protection modules

[PATCH v2] ASoC: qcom: audioreach: explicitly enable speaker protection modules

Posted by Ravi Hothi 1 week ago

Speaker protection and VI feedback modules are disabled by default.
Explicitly enable them when configuring speaker protection.

Fixes: 3e43a8c033c3 ("ASoC: qcom: audioreach: Add support for VI Sense module")
Fixes: 0db76f5b2235 ("ASoC: qcom: audioreach: Add support for Speaker Protection module")
Signed-off-by: Ravi Hothi <ravi.hothi@oss.qualcomm.com>
---
Changes in v2:
        - Added fixes tag suggested by Dmitry.
        - Link to v1: https://lore.kernel.org/all/20260325054408.1994556-1-ravi.hothi@oss.qualcomm.com/
---
 sound/soc/qcom/qdsp6/audioreach.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/sound/soc/qcom/qdsp6/audioreach.c b/sound/soc/qcom/qdsp6/audioreach.c
index 241c3b4479c6..ff8cd55b0d89 100644
--- a/sound/soc/qcom/qdsp6/audioreach.c
+++ b/sound/soc/qcom/qdsp6/audioreach.c
@@ -1365,9 +1365,14 @@ int audioreach_set_media_format(struct q6apm_graph *graph,
 	case MODULE_ID_SPEAKER_PROTECTION:
 		rc = audioreach_speaker_protection(graph, module,
 						   PARAM_ID_SP_OP_MODE_NORMAL);
+		if (!rc)
+			rc = audioreach_module_enable(graph, module, true);
+
 		break;
 	case MODULE_ID_SPEAKER_PROTECTION_VI:
 		rc = audioreach_speaker_protection_vi(graph, module, cfg);
+		if (!rc)
+			rc = audioreach_module_enable(graph, module, true);
 		break;
 
 	default:
-- 
2.34.1

Re: [PATCH v2] ASoC: qcom: audioreach: explicitly enable speaker protection modules

Posted by Srinivas Kandagatla 1 week ago

On 3/26/26 11:35 AM, Ravi Hothi wrote:
> Speaker protection and VI feedback modules are disabled by default.
> Explicitly enable them when configuring speaker protection.
> 
> Fixes: 3e43a8c033c3 ("ASoC: qcom: audioreach: Add support for VI Sense module")
> Fixes: 0db76f5b2235 ("ASoC: qcom: audioreach: Add support for Speaker Protection module")
> Signed-off-by: Ravi Hothi <ravi.hothi@oss.qualcomm.com>
> ---

lgtm,

Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>


> Changes in v2:
>         - Added fixes tag suggested by Dmitry.
>         - Link to v1: https://lore.kernel.org/all/20260325054408.1994556-1-ravi.hothi@oss.qualcomm.com/
> ---
>  sound/soc/qcom/qdsp6/audioreach.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/sound/soc/qcom/qdsp6/audioreach.c b/sound/soc/qcom/qdsp6/audioreach.c
> index 241c3b4479c6..ff8cd55b0d89 100644
> --- a/sound/soc/qcom/qdsp6/audioreach.c
> +++ b/sound/soc/qcom/qdsp6/audioreach.c
> @@ -1365,9 +1365,14 @@ int audioreach_set_media_format(struct q6apm_graph *graph,
>  	case MODULE_ID_SPEAKER_PROTECTION:
>  		rc = audioreach_speaker_protection(graph, module,
>  						   PARAM_ID_SP_OP_MODE_NORMAL);
> +		if (!rc)
> +			rc = audioreach_module_enable(graph, module, true);
> +
>  		break;
>  	case MODULE_ID_SPEAKER_PROTECTION_VI:
>  		rc = audioreach_speaker_protection_vi(graph, module, cfg);
> +		if (!rc)
> +			rc = audioreach_module_enable(graph, module, true);
>  		break;
>  
>  	default: