[v2] net: enetc: add more checks to enetc_set_rxfh()

[PATCH v2 net 0/2] net: enetc: add more checks to enetc_set_rxfh()

Wei Fang posted 2 patches 1 week ago

Diff against v1
Download series mbox

drivers/net/ethernet/freescale/enetc/enetc_ethtool.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)

Expand all Fold all

[PATCH v2 net 0/2] net: enetc: add more checks to enetc_set_rxfh()

Posted by Wei Fang 1 week ago

ENETC only supports Toeplitz algorithm, and VFs do not support setting
the RSS key, but enetc_set_rxfh() does not check these constraints and
silently accepts unsupported configurations. This may mislead users or
tools into believing that the requested RSS settings have been
successfully applied. So add checks to reject unsupported hash functions
and RSS key updates on VFs, and return "-EOPNOTSUPP" to user space.

---
v2:
1. Fix a typo in the commit message of patch 2.
2. Collect Reviewed-by tag.
---

Wei Fang (2):
  net: enetc: check whether the RSS algorithm is Toeplitz
  net: enetc: do not allow VF to configure the RSS key

 drivers/net/ethernet/freescale/enetc/enetc_ethtool.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

-- 
2.34.1