[PATCH v3 0/2] liveupdate: fix incoming error handling and teardown paths

Leo Timmins posted 2 patches 1 week ago
kernel/liveupdate/luo_flb.c     | 19 ++++++++++++++++++-
kernel/liveupdate/luo_session.c |  9 +++++++--
2 files changed, 25 insertions(+), 3 deletions(-)
[PATCH v3 0/2] liveupdate: fix incoming error handling and teardown paths
Posted by Leo Timmins 1 week ago
Hi,

This series fixes two issues in LUO's incoming-side error handling and
teardown paths.

The first patch makes session deserialization fail when file
deserialization fails, instead of silently continuing with a partially
restored session.

The second patch (formerly patch 3 on the v1) initializes incoming FLB
state before the finish pathdecrements its refcount, so the last-user
cleanup path does not run from an uninitialized count. (and now 
utilises pr_warn instead of WARN_ON)

Changes in v2:

  - drop the previous patch 2 after review
  - patch 2/2: replace WARN_ON(err) with pr_warn() in
    luo_flb_file_finish_one()

Changes in v3:

  - patch 2/2. minor change to formatting. removed braces from scopped_guard

Leo Timmins (2):
  liveupdate: propagate file deserialization failures
  liveupdate: initialize incoming FLB state before finish

 kernel/liveupdate/luo_flb.c     | 19 ++++++++++++++++++-
 kernel/liveupdate/luo_session.c |  9 +++++++--
 2 files changed, 25 insertions(+), 3 deletions(-)


base-commit: e3c33bc767b5512dbfec643a02abf58ce608f3b2
-- 
2.53.0
Re: [PATCH v3 0/2] liveupdate: fix incoming error handling and teardown paths
Posted by Andrew Morton 5 days, 21 hours ago
On Thu, 26 Mar 2026 12:25:33 +0800 Leo Timmins <leotimmins1974@gmail.com> wrote:

> This series fixes two issues in LUO's incoming-side error handling and
> teardown paths.
> 
> The first patch makes session deserialization fail when file
> deserialization fails, instead of silently continuing with a partially
> restored session.
> 
> The second patch (formerly patch 3 on the v1) initializes incoming FLB
> state before the finish pathdecrements its refcount, so the last-user
> cleanup path does not run from an uninitialized count. (and now 
> utilises pr_warn instead of WARN_ON)

I'm not clear how we want to schedule these two patches.  Into next
merge widow?  Into 7.0-rcX?  Into 7.0-rcX and cc:stable?

Thanks.
Re: [PATCH v3 0/2] liveupdate: fix incoming error handling and teardown paths
Posted by Pasha Tatashin 5 days, 20 hours ago
On Fri, Mar 27, 2026 at 8:32 PM Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Thu, 26 Mar 2026 12:25:33 +0800 Leo Timmins <leotimmins1974@gmail.com> wrote:
>
> > This series fixes two issues in LUO's incoming-side error handling and
> > teardown paths.
> >
> > The first patch makes session deserialization fail when file
> > deserialization fails, instead of silently continuing with a partially
> > restored session.
> >
> > The second patch (formerly patch 3 on the v1) initializes incoming FLB
> > state before the finish pathdecrements its refcount, so the last-user
> > cleanup path does not run from an uninitialized count. (and now
> > utilises pr_warn instead of WARN_ON)
>
> I'm not clear how we want to schedule these two patches.  Into next
> merge widow?  Into 7.0-rcX?  Into 7.0-rcX and cc:stable?

I think, there is no need to cc:stable live update feature is still
very new and actively being developed. However,  7.0-rcX, would be
appropriate.

Pasha

>
> Thanks.