Hi,
On Thu, Mar 26, 2026 at 12:31:58PM +0000, Brendan Jackman wrote:
> Fix 2 issues spotted by AI[0]:
>
> 1. Missing space after the full stop.
>
> 2. Wrong GFP flags are printed.
We should also initialize gfp_mask = priority inside the loop.
But this can be done as separate patch.
> And also switch to %pGg for the GFP flags. This produces nice readable
> output and decouples the format string from the size of gfp_t.
>
> [0] https://sashiko.dev/#/patchset/20260319-gfp64-v1-0-2c73b8d42b7f%40google.com
>
> Signed-off-by: Brendan Jackman <jackmanb@google.com>
Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>
> ---
> drivers/net/wireless/intel/iwlegacy/3945-mac.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/intel/iwlegacy/3945-mac.c b/drivers/net/wireless/intel/iwlegacy/3945-mac.c
> index c148654aa9533..88b31e0b9568c 100644
> --- a/drivers/net/wireless/intel/iwlegacy/3945-mac.c
> +++ b/drivers/net/wireless/intel/iwlegacy/3945-mac.c
> @@ -1002,9 +1002,9 @@ il3945_rx_allocate(struct il_priv *il, gfp_t priority)
> D_INFO("Failed to allocate SKB buffer.\n");
> if (rxq->free_count <= RX_LOW_WATERMARK &&
> net_ratelimit())
> - IL_ERR("Failed to allocate SKB buffer with %0x."
> + IL_ERR("Failed to allocate SKB buffer with %pGg. "
> "Only %u free buffers remaining.\n",
> - priority, rxq->free_count);
> + &gfp_mask, rxq->free_count);
> /* We don't reschedule replenish work here -- we will
> * call the restock method and if it still needs
> * more buffers it will schedule replenish */
>
> --
> 2.51.2
>