[PATCH v8 1/2] dt-bindings: iio: proximity: add ST VL53L1X ToF sensor

Siratul Islam posted 2 patches 1 week, 1 day ago
[PATCH v8 1/2] dt-bindings: iio: proximity: add ST VL53L1X ToF sensor
Posted by Siratul Islam 1 week, 1 day ago
Add device tree binding documentation for the STMicroelectronics
VL53L1X Time-of-Flight ranging sensor connected via I2C.

Signed-off-by: Siratul Islam <email@sirat.me>
---
 .../bindings/iio/proximity/st,vl53l0x.yaml    | 24 ++++++++++++++++---
 MAINTAINERS                                   |  6 +++++
 2 files changed, 27 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/iio/proximity/st,vl53l0x.yaml b/Documentation/devicetree/bindings/iio/proximity/st,vl53l0x.yaml
index 322befc41de6..9adb9b13ccc5 100644
--- a/Documentation/devicetree/bindings/iio/proximity/st,vl53l0x.yaml
+++ b/Documentation/devicetree/bindings/iio/proximity/st,vl53l0x.yaml
@@ -4,14 +4,17 @@
 $id: http://devicetree.org/schemas/iio/proximity/st,vl53l0x.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
-title: ST VL53L0X ToF ranging sensor
+title: ST VL53L0X/VL53L1X ToF ranging sensor
 
 maintainers:
   - Song Qiang <songqiang1304521@gmail.com>
+  - Siratul Islam <email@sirat.me>
 
 properties:
   compatible:
-    const: st,vl53l0x
+    enum:
+      - st,vl53l0x
+      - st,vl53l1x
 
   reg:
     maxItems: 1
@@ -21,6 +24,8 @@ properties:
 
   reset-gpios:
     maxItems: 1
+    description:
+      Phandle to the XSHUT GPIO. Used for hardware reset.
 
   vdd-supply: true
 
@@ -28,6 +33,18 @@ required:
   - compatible
   - reg
 
+# vdd-supply is not made globally required to maintain backwards compatibility
+# with existing st,vl53l0x devicetrees that do not specify it.
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: st,vl53l1x
+    then:
+      required:
+        - vdd-supply
+
 additionalProperties: false
 
 examples:
@@ -38,8 +55,9 @@ examples:
         #size-cells = <0>;
 
         proximity@29 {
-            compatible = "st,vl53l0x";
+            compatible = "st,vl53l1x";
             reg = <0x29>;
+            vdd-supply = <&reg_3v3>;
             interrupt-parent = <&gpio>;
             interrupts = <23 IRQ_TYPE_EDGE_FALLING>;
         };
diff --git a/MAINTAINERS b/MAINTAINERS
index 61bf550fd37c..a142a97be4cb 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -25093,6 +25093,12 @@ S:	Maintained
 F:	Documentation/devicetree/bindings/iio/proximity/st,vl53l0x.yaml
 F:	drivers/iio/proximity/vl53l0x-i2c.c
 
+ST VL53L1X ToF RANGER(I2C) IIO DRIVER
+M:	Siratul Islam <email@sirat.me>
+L:	linux-iio@vger.kernel.org
+S:	Maintained
+F:	Documentation/devicetree/bindings/iio/proximity/st,vl53l0x.yaml
+
 STABLE BRANCH
 M:	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 M:	Sasha Levin <sashal@kernel.org>
-- 
2.53.0
Re: [PATCH v8 1/2] dt-bindings: iio: proximity: add ST VL53L1X ToF sensor
Posted by Krzysztof Kozlowski 1 week ago
On Thu, Mar 26, 2026 at 02:19:41AM +0600, Siratul Islam wrote:
>    vdd-supply: true
>  
> @@ -28,6 +33,18 @@ required:
>    - compatible
>    - reg
>  
> +# vdd-supply is not made globally required to maintain backwards compatibility
> +# with existing st,vl53l0x devicetrees that do not specify it.

Commit should rather explain that, not code.

Anyway, regardless:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof
Re: [PATCH v8 1/2] dt-bindings: iio: proximity: add ST VL53L1X ToF sensor
Posted by Jonathan Cameron 1 week ago
On Thu, 26 Mar 2026 08:38:59 +0100
Krzysztof Kozlowski <krzk@kernel.org> wrote:

> On Thu, Mar 26, 2026 at 02:19:41AM +0600, Siratul Islam wrote:
> >    vdd-supply: true
> >  
> > @@ -28,6 +33,18 @@ required:
> >    - compatible
> >    - reg
> >  
> > +# vdd-supply is not made globally required to maintain backwards compatibility
> > +# with existing st,vl53l0x devicetrees that do not specify it.  
> 
> Commit should rather explain that, not code.
That was my suggestion. I'm not that tied to it though so moved to the commit message.
> 
> Anyway, regardless:
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Thanks,

J
> 
> Best regards,
> Krzysztof
>