[PATCH v4] staging: media: atomisp: pci: fix split GP_TIMER_BASE declaration

Anushka Badhe posted 1 patch 1 week, 1 day ago
drivers/staging/media/atomisp/pci/system_local.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
[PATCH v4] staging: media: atomisp: pci: fix split GP_TIMER_BASE declaration
Posted by Anushka Badhe 1 week, 1 day ago
Merge declaration of const GP_TIMER_BASE split across 2 lines to improve
readability.

Signed-off-by: Anushka Badhe <anushkabadhe@gmail.com>
---
Thank you so much for your review and guidance.

Changes in v4:
- Remove unrelated block comment style fixes

Changes in v3:
- Add commit description
- Fix subject prefix to staging: media: atomisp:

Changes in v2:
- Fix block comment style (move closing */ to its own line)
- Merge split GP_TIMER_BASE declaration onto a single line

Note:
* This patch is part of the GSoC2026 application process for device tree 
binding
s conversions
* https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device-Tree-Bindings

 drivers/staging/media/atomisp/pci/system_local.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/system_local.c b/drivers/staging/media/atomisp/pci/system_local.c
index a8a93760d5b1..69bcd557a821 100644
--- a/drivers/staging/media/atomisp/pci/system_local.c
+++ b/drivers/staging/media/atomisp/pci/system_local.c
@@ -86,8 +86,7 @@ const hrt_address GP_DEVICE_BASE[N_GP_DEVICE_ID] = {
 /*GP TIMER , all timer registers are inter-twined,
  * so, having multiple base addresses for
  * different timers does not help*/
-const hrt_address GP_TIMER_BASE =
-    (hrt_address)0x0000000000000600ULL;
+const hrt_address GP_TIMER_BASE = (hrt_address)0x0000000000000600ULL;
 
 /* GPIO */
 const hrt_address GPIO_BASE[N_GPIO_ID] = {
-- 
2.43.0
Re: [PATCH v4] staging: media: atomisp: pci: fix split GP_TIMER_BASE declaration
Posted by Andy Shevchenko 1 week ago
On Wed, Mar 25, 2026 at 06:54:34PM +0530, Anushka Badhe wrote:
> Merge declaration of const GP_TIMER_BASE split across 2 lines to improve
> readability.

Nice, but this constant is only used in one file, id est gp_timer.c.
Just move it there with the (fixed style of the) comment to there
and drop the mentioning in the rest of the files. With this being done,
the patch gains real value.

-- 
With Best Regards,
Andy Shevchenko