dt-bindings: display/msm: qcm2290-mdss: Fix missing ranges in example

[PATCH] dt-bindings: display/msm: qcm2290-mdss: Fix missing ranges in example

Posted by Krzysztof Kozlowski 1 week, 1 day ago

Device node has children with MMIO addressing, so must have ranges:

  msm/qcom,qcm2290-mdss.example.dtb: display-subsystem@5e00000 (qcom,qcm2290-mdss): 'ranges' is a required property

Fixes: 966a08c293cb ("dt-bindings: display: msm: qcm2290-mdss: Fix iommus property")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

---

Fix for commit taken by Bjorn (Qualcomm SoC).
---
 .../devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml       | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml
index 2772cdec7e42..bb09ecd1a5b4 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml
@@ -108,6 +108,7 @@ examples:
                              "cpu-cfg";
 
         iommus = <&apps_smmu 0x420 0x2>;
+        ranges;
 
         display-controller@5e01000 {
             compatible = "qcom,qcm2290-dpu";
-- 
2.51.0

Re: [PATCH] dt-bindings: display/msm: qcm2290-mdss: Fix missing ranges in example

Posted by Bjorn Andersson 3 days, 7 hours ago

On Wed, 25 Mar 2026 13:22:10 +0100, Krzysztof Kozlowski wrote:
> Device node has children with MMIO addressing, so must have ranges:
> 
>   msm/qcom,qcm2290-mdss.example.dtb: display-subsystem@5e00000 (qcom,qcm2290-mdss): 'ranges' is a required property
> 
> 

Applied, thanks!

[1/1] dt-bindings: display/msm: qcm2290-mdss: Fix missing ranges in example
      commit: 88bdac5443e5269bb39c4968d5ee0becbffe3f82

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH] dt-bindings: display/msm: qcm2290-mdss: Fix missing ranges in example

Posted by Dmitry Baryshkov 3 days, 5 hours ago

On Mon, Mar 30, 2026 at 11:01:21AM -0500, Bjorn Andersson wrote:
> 
> On Wed, 25 Mar 2026 13:22:10 +0100, Krzysztof Kozlowski wrote:
> > Device node has children with MMIO addressing, so must have ranges:
> > 
> >   msm/qcom,qcm2290-mdss.example.dtb: display-subsystem@5e00000 (qcom,qcm2290-mdss): 'ranges' is a required property
> > 
> > 
> 
> Applied, thanks!
> 
> [1/1] dt-bindings: display/msm: qcm2290-mdss: Fix missing ranges in example
>       commit: 88bdac5443e5269bb39c4968d5ee0becbffe3f82

Hmm? I don't really mind, but...

> 
> Best regards,
> -- 
> Bjorn Andersson <andersson@kernel.org>

-- 
With best wishes
Dmitry

Re: [PATCH] dt-bindings: display/msm: qcm2290-mdss: Fix missing ranges in example

Posted by Krzysztof Kozlowski 3 days, 5 hours ago

On 30/03/2026 20:50, Dmitry Baryshkov wrote:
> On Mon, Mar 30, 2026 at 11:01:21AM -0500, Bjorn Andersson wrote:
>>
>> On Wed, 25 Mar 2026 13:22:10 +0100, Krzysztof Kozlowski wrote:
>>> Device node has children with MMIO addressing, so must have ranges:
>>>
>>>   msm/qcom,qcm2290-mdss.example.dtb: display-subsystem@5e00000 (qcom,qcm2290-mdss): 'ranges' is a required property
>>>
>>>
>>
>> Applied, thanks!
>>
>> [1/1] dt-bindings: display/msm: qcm2290-mdss: Fix missing ranges in example
>>       commit: 88bdac5443e5269bb39c4968d5ee0becbffe3f82
> 
> Hmm? I don't really mind, but...
> 

Please read changelog in original patch. I was also mentioning this on
msm IRC (although not towards you), so this is not done silently.

Best regards,
Krzysztof

Re: [PATCH] dt-bindings: display/msm: qcm2290-mdss: Fix missing ranges in example

Posted by Dmitry Baryshkov 3 days, 4 hours ago

On Mon, Mar 30, 2026 at 08:55:04PM +0200, Krzysztof Kozlowski wrote:
> On 30/03/2026 20:50, Dmitry Baryshkov wrote:
> > On Mon, Mar 30, 2026 at 11:01:21AM -0500, Bjorn Andersson wrote:
> >>
> >> On Wed, 25 Mar 2026 13:22:10 +0100, Krzysztof Kozlowski wrote:
> >>> Device node has children with MMIO addressing, so must have ranges:
> >>>
> >>>   msm/qcom,qcm2290-mdss.example.dtb: display-subsystem@5e00000 (qcom,qcm2290-mdss): 'ranges' is a required property
> >>>
> >>>
> >>
> >> Applied, thanks!
> >>
> >> [1/1] dt-bindings: display/msm: qcm2290-mdss: Fix missing ranges in example
> >>       commit: 88bdac5443e5269bb39c4968d5ee0becbffe3f82
> > 
> > Hmm? I don't really mind, but...
> > 
> 
> Please read changelog in original patch. I was also mentioning this on
> msm IRC (although not towards you), so this is not done silently.

Okay.

-- 
With best wishes
Dmitry

Re: [PATCH] dt-bindings: display/msm: qcm2290-mdss: Fix missing ranges in example

Posted by Sumit Garg 1 week ago

On Wed, Mar 25, 2026 at 5:52 PM Krzysztof Kozlowski
<krzysztof.kozlowski@oss.qualcomm.com> wrote:
>
> Device node has children with MMIO addressing, so must have ranges:
>
>   msm/qcom,qcm2290-mdss.example.dtb: display-subsystem@5e00000 (qcom,qcm2290-mdss): 'ranges' is a required property
>
> Fixes: 966a08c293cb ("dt-bindings: display: msm: qcm2290-mdss: Fix iommus property")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>
> ---
>
> Fix for commit taken by Bjorn (Qualcomm SoC).
> ---
>  .../devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml       | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml
> index 2772cdec7e42..bb09ecd1a5b4 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml
> @@ -108,6 +108,7 @@ examples:
>                               "cpu-cfg";
>
>          iommus = <&apps_smmu 0x420 0x2>;
> +        ranges;


Ah, it was surely an oversight on my part, FWIW:

Reviewed-by: Sumit Garg <sumit.garg@oss.qualcomm.com>

-Sumit

>
>          display-controller@5e01000 {
>              compatible = "qcom,qcm2290-dpu";
> --
> 2.51.0
>