drivers/soc/qcom/ubwc_config.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-)
UBWC data for X1E80100 is exactly the same as one for SM8550, so reduce
code duplication by reusing older entry.
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
Changes in v2:
1. Drop patch 2/2, thus sending everything as new posting.
2. No changes here, except Rb tag.
---
drivers/soc/qcom/ubwc_config.c | 15 ++-------------
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/drivers/soc/qcom/ubwc_config.c b/drivers/soc/qcom/ubwc_config.c
index 1c25aaf55e52..63e77fceb6b8 100644
--- a/drivers/soc/qcom/ubwc_config.c
+++ b/drivers/soc/qcom/ubwc_config.c
@@ -217,17 +217,6 @@ static const struct qcom_ubwc_cfg_data sm8750_data = {
.macrotile_mode = true,
};
-static const struct qcom_ubwc_cfg_data x1e80100_data = {
- .ubwc_enc_version = UBWC_4_0,
- .ubwc_dec_version = UBWC_4_3,
- .ubwc_swizzle = UBWC_SWIZZLE_ENABLE_LVL2 |
- UBWC_SWIZZLE_ENABLE_LVL3,
- .ubwc_bank_spread = true,
- /* TODO: highest_bank_bit = 15 for LP_DDR4 */
- .highest_bank_bit = 16,
- .macrotile_mode = true,
-};
-
static const struct qcom_ubwc_cfg_data glymur_data = {
.ubwc_enc_version = UBWC_5_0,
.ubwc_dec_version = UBWC_5_0,
@@ -294,8 +283,8 @@ static const struct of_device_id qcom_ubwc_configs[] __maybe_unused = {
{ .compatible = "qcom,sm8550", .data = &sm8550_data, },
{ .compatible = "qcom,sm8650", .data = &sm8550_data, },
{ .compatible = "qcom,sm8750", .data = &sm8750_data, },
- { .compatible = "qcom,x1e80100", .data = &x1e80100_data, },
- { .compatible = "qcom,x1p42100", .data = &x1e80100_data, },
+ { .compatible = "qcom,x1e80100", .data = &sm8550_data, },
+ { .compatible = "qcom,x1p42100", .data = &sm8550_data, },
{ }
};
--
2.51.0
On Wed, 25 Mar 2026 13:08:47 +0100, Krzysztof Kozlowski wrote:
> UBWC data for X1E80100 is exactly the same as one for SM8550, so reduce
> code duplication by reusing older entry.
>
>
Applied, thanks!
[1/1] soc: qcom: ubwc: Remove redundant x1e80100_data
commit: 624a97208904ed50288f32e8b1ecc9ff9aeddf1b
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
On Wed, Mar 25, 2026 at 01:08:47PM +0100, Krzysztof Kozlowski wrote: > UBWC data for X1E80100 is exactly the same as one for SM8550, so reduce > code duplication by reusing older entry. > > Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > Cc: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> > > --- > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> -- With best wishes Dmitry
© 2016 - 2026 Red Hat, Inc.