[PATCH v3 00/14] ASoC: tegra: Add error logging for probe and callback failures

Sheetal posted 14 patches 1 week, 1 day ago
There is a newer version of this series
sound/soc/tegra/tegra186_asrc.c          |  7 ++--
sound/soc/tegra/tegra186_dspk.c          | 15 +++----
sound/soc/tegra/tegra210_admaif.c        | 18 ++++----
sound/soc/tegra/tegra210_adx.c           | 13 +++---
sound/soc/tegra/tegra210_ahub.c          | 18 ++++----
sound/soc/tegra/tegra210_amx.c           |  9 ++--
sound/soc/tegra/tegra210_dmic.c          | 14 +++----
sound/soc/tegra/tegra210_i2s.c           | 18 ++++----
sound/soc/tegra/tegra210_mbdrc.c         | 10 ++---
sound/soc/tegra/tegra210_mixer.c         |  7 ++--
sound/soc/tegra/tegra210_mvc.c           |  7 ++--
sound/soc/tegra/tegra210_ope.c           | 19 ++++-----
sound/soc/tegra/tegra210_peq.c           | 10 ++---
sound/soc/tegra/tegra210_sfc.c           |  7 ++--
sound/soc/tegra/tegra_asoc_machine.c     | 70 ++++++++++++++++----------------
sound/soc/tegra/tegra_audio_graph_card.c | 21 ++++++----
16 files changed, 128 insertions(+), 135 deletions(-)
[PATCH v3 00/14] ASoC: tegra: Add error logging for probe and callback failures
Posted by Sheetal 1 week, 1 day ago
Log errors in probe and runtime error paths across Tegra audio drivers.
Use dev_err_probe() in probe paths and dev_err() in runtime callbacks.
Skip redundant logging where the underlying API already reports errors.

Changes in v3:
- Split single patch into per-driver patch series for easier review
  and incremental merging.
- Drop dev_err() from tegra_ahub_put_value_enum() since the error path
  is userspace-triggerable and would allow log spamming.
- Drop dev_err() from tegra210_mixer_set_audio_cif() since the driver
  advertises S8 format support but this function doesn't handle it,
  creating a userspace-triggerable log spam path.

Changes in v2:
- Use dev_err_probe() in all probe error paths as a defensive measure,
  instead of only where -EPROBE_DEFER is currently known to be returned.
- Drop redundant error logging for devm_platform_ioremap_resource() and
  devm_ioremap_resource() since these APIs already log errors internally.

Sheetal (14):
  ASoC: tegra: Use dev_err_probe() in tegra186_asrc probe
  ASoC: tegra: Use dev_err_probe() in tegra186_dspk probe
  ASoC: tegra: Add error logging in tegra210_admaif driver
  ASoC: tegra: Add error logging in tegra210_adx driver
  ASoC: tegra: Use dev_err_probe() in tegra210_ahub probe
  ASoC: tegra: Add error logging in tegra210_amx driver
  ASoC: tegra: Use dev_err_probe() in tegra210_dmic probe
  ASoC: tegra: Add error logging in tegra210_i2s driver
  ASoC: tegra: Use dev_err_probe() in OPE, PEQ and MBDRC drivers
  ASoC: tegra: Use dev_err_probe() in tegra210_mixer probe
  ASoC: tegra: Use dev_err_probe() in tegra210_mvc probe
  ASoC: tegra: Use dev_err_probe() in tegra210_sfc probe
  ASoC: tegra: Use dev_err_probe() in tegra_asoc_machine probe
  ASoC: tegra: Use dev_err_probe() in tegra_audio_graph_card probe

 sound/soc/tegra/tegra186_asrc.c          |  7 ++--
 sound/soc/tegra/tegra186_dspk.c          | 15 +++----
 sound/soc/tegra/tegra210_admaif.c        | 18 ++++----
 sound/soc/tegra/tegra210_adx.c           | 13 +++---
 sound/soc/tegra/tegra210_ahub.c          | 18 ++++----
 sound/soc/tegra/tegra210_amx.c           |  9 ++--
 sound/soc/tegra/tegra210_dmic.c          | 14 +++----
 sound/soc/tegra/tegra210_i2s.c           | 18 ++++----
 sound/soc/tegra/tegra210_mbdrc.c         | 10 ++---
 sound/soc/tegra/tegra210_mixer.c         |  7 ++--
 sound/soc/tegra/tegra210_mvc.c           |  7 ++--
 sound/soc/tegra/tegra210_ope.c           | 19 ++++-----
 sound/soc/tegra/tegra210_peq.c           | 10 ++---
 sound/soc/tegra/tegra210_sfc.c           |  7 ++--
 sound/soc/tegra/tegra_asoc_machine.c     | 70 ++++++++++++++++----------------
 sound/soc/tegra/tegra_audio_graph_card.c | 21 ++++++----
 16 files changed, 128 insertions(+), 135 deletions(-)

-- 
2.17.1
Re: (subset) [PATCH v3 00/14] ASoC: tegra: Add error logging for probe and callback failures
Posted by Mark Brown 1 week, 1 day ago
On Wed, 25 Mar 2026 10:14:23 +0000, Sheetal wrote:
> ASoC: tegra: Add error logging for probe and callback failures
> 
> Log errors in probe and runtime error paths across Tegra audio drivers.
> Use dev_err_probe() in probe paths and dev_err() in runtime callbacks.
> Skip redundant logging where the underlying API already reports errors.
> 
> Changes in v3:
> - Split single patch into per-driver patch series for easier review
>   and incremental merging.
> - Drop dev_err() from tegra_ahub_put_value_enum() since the error path
>   is userspace-triggerable and would allow log spamming.
> - Drop dev_err() from tegra210_mixer_set_audio_cif() since the driver
>   advertises S8 format support but this function doesn't handle it,
>   creating a userspace-triggerable log spam path.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.1

Thanks!

[01/14] ASoC: tegra: Use dev_err_probe() in tegra186_asrc probe
        https://git.kernel.org/broonie/sound/c/884f3101d1ed
[02/14] ASoC: tegra: Use dev_err_probe() in tegra186_dspk probe
        https://git.kernel.org/broonie/sound/c/6205ca05227f
[04/14] ASoC: tegra: Add error logging in tegra210_adx driver
        https://git.kernel.org/broonie/sound/c/50e51b84a4b3
[05/14] ASoC: tegra: Use dev_err_probe() in tegra210_ahub probe
        https://git.kernel.org/broonie/sound/c/802d0d6c25b3
[06/14] ASoC: tegra: Add error logging in tegra210_amx driver
        https://git.kernel.org/broonie/sound/c/d310c08db2d8
[07/14] ASoC: tegra: Use dev_err_probe() in tegra210_dmic probe
        https://git.kernel.org/broonie/sound/c/ca069c3403ec
[08/14] ASoC: tegra: Add error logging in tegra210_i2s driver
        https://git.kernel.org/broonie/sound/c/67b7bcdd9798
[10/14] ASoC: tegra: Use dev_err_probe() in tegra210_mixer probe
        https://git.kernel.org/broonie/sound/c/3d027d4b93b9
[11/14] ASoC: tegra: Use dev_err_probe() in tegra210_mvc probe
        https://git.kernel.org/broonie/sound/c/f2067c1dba07
[12/14] ASoC: tegra: Use dev_err_probe() in tegra210_sfc probe
        https://git.kernel.org/broonie/sound/c/856ffd8f4aae
[13/14] ASoC: tegra: Use dev_err_probe() in tegra_asoc_machine probe
        https://git.kernel.org/broonie/sound/c/fa11e1cb2b77
[14/14] ASoC: tegra: Use dev_err_probe() in tegra_audio_graph_card probe
        https://git.kernel.org/broonie/sound/c/f7d9eb0291ef

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark