[PATCH v2] ARM: dts: r9a06g032: Add #address-cells in the GIC node

Herve Codina (Schneider Electric) posted 1 patch 1 week, 1 day ago
arch/arm/boot/dts/renesas/r9a06g032.dtsi | 1 +
1 file changed, 1 insertion(+)
[PATCH v2] ARM: dts: r9a06g032: Add #address-cells in the GIC node
Posted by Herve Codina (Schneider Electric) 1 week, 1 day ago
When checking dts involving the r9a06g032.dtsi file, the following kind
of warnings are reported:
   Missing property '#address-cells' in node xxx, using 0 as fallback

Indeed, #address-cells is not present in the GIC interrupt controller
node.

Fix it adding the missing property.

Value '0' is correct because:
1. GIC interrupt controller does not have children,
2. interrupt-map property in PCI node and in IRQ mux node consists of
   several components and the component related to "parent unit
   address", which size is defined by '#address-cells' of the node
   pointed to by the interrupt-parent component, is not used (=0)

No functional change.

Signed-off-by: Herve Codina (Schneider Electric) <herve.codina@bootlin.com>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Changes v1 -> v2
  v1: https://lore.kernel.org/all/20260303102029.147359-1-herve.codina@bootlin.com/

  Add details about value '0' in the commit log
  Add 'Reviewed-by: Wolfram Sang'
---
 arch/arm/boot/dts/renesas/r9a06g032.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/renesas/r9a06g032.dtsi b/arch/arm/boot/dts/renesas/r9a06g032.dtsi
index f4f760aff28b..6acf524174c7 100644
--- a/arch/arm/boot/dts/renesas/r9a06g032.dtsi
+++ b/arch/arm/boot/dts/renesas/r9a06g032.dtsi
@@ -507,6 +507,7 @@ gic: interrupt-controller@44101000 {
 			compatible = "arm,gic-400", "arm,cortex-a7-gic";
 			interrupt-controller;
 			#interrupt-cells = <3>;
+			#address-cells = <0>;
 			reg = <0x44101000 0x1000>, /* Distributer */
 			      <0x44102000 0x2000>, /* CPU interface */
 			      <0x44104000 0x2000>, /* Virt interface control */
-- 
2.53.0
Re: [PATCH v2] ARM: dts: r9a06g032: Add #address-cells in the GIC node
Posted by Geert Uytterhoeven 1 week, 1 day ago
On Wed, 25 Mar 2026 at 10:58, Herve Codina (Schneider Electric)
<herve.codina@bootlin.com> wrote:
> When checking dts involving the r9a06g032.dtsi file, the following kind
> of warnings are reported:
>    Missing property '#address-cells' in node xxx, using 0 as fallback
>
> Indeed, #address-cells is not present in the GIC interrupt controller
> node.
>
> Fix it adding the missing property.
>
> Value '0' is correct because:
> 1. GIC interrupt controller does not have children,
> 2. interrupt-map property in PCI node and in IRQ mux node consists of
>    several components and the component related to "parent unit
>    address", which size is defined by '#address-cells' of the node
>    pointed to by the interrupt-parent component, is not used (=0)
>
> No functional change.
>
> Signed-off-by: Herve Codina (Schneider Electric) <herve.codina@bootlin.com>
> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v7.1.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds