1. Patchew
  2. linux
  3. View series

[PATCH] mm/damon/core: validate goal nid before accessing node data

Josh Law posted 1 patch 1 week, 1 day ago
There is a newer version of this series
mm/damon/core.c | 8 ++++++++
1 file changed, 8 insertions(+)
[PATCH] mm/damon/core: validate goal nid before accessing node data
Posted by Josh Law 1 week, 1 day ago 
damos_get_node_mem_bp() and damos_get_node_memcg_used_bp() pass
goal->nid directly to si_meminfo_node() and NODE_DATA() without
checking that it refers to a valid, online NUMA node.  Since
goal->nid is set from userspace via sysfs with no validation, a
negative or out-of-range value causes an out-of-bounds access in
NODE_DATA(), and a valid but offline node gives undefined results.

Add bounds and node_online() checks before using the nid.

Fixes: 0e1c773b501f ("mm/damon/core: introduce damos quota goal metrics for memory node utilization")
Signed-off-by: Josh Law <objecting@objecting.org>
---
 mm/damon/core.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/mm/damon/core.c b/mm/damon/core.c
index 59b709f04975..6ee421141996 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -2227,6 +2227,10 @@ static __kernel_ulong_t damos_get_node_mem_bp(
 	struct sysinfo i;
 	__kernel_ulong_t numerator;
 
+	if (goal->nid < 0 || goal->nid >= MAX_NUMNODES ||
+	    !node_online(goal->nid))
+		return 0;
+
 	si_meminfo_node(&i, goal->nid);
 	if (goal->metric == DAMOS_QUOTA_NODE_MEM_USED_BP)
 		numerator = i.totalram - i.freeram;
@@ -2243,6 +2247,10 @@ static unsigned long damos_get_node_memcg_used_bp(
 	unsigned long used_pages, numerator;
 	struct sysinfo i;
 
+	if (goal->nid < 0 || goal->nid >= MAX_NUMNODES ||
+	    !node_online(goal->nid))
+		return 0;
+
 	memcg = mem_cgroup_get_from_id(goal->memcg_id);
 	if (!memcg) {
 		if (goal->metric == DAMOS_QUOTA_NODE_MEMCG_USED_BP)
-- 
2.34.1
Re: (sashiko review) [PATCH] mm/damon/core: validate goal nid before accessing node data
Posted by SeongJae Park 1 week, 1 day ago 
Forwarding Sashiko review for doing discussions via mails.

# review url: https://sashiko.dev/#/patchset/20260325073034.140353-1-objecting@objecting.org
# start of sashiko.dev inline review
commit 7e17cbe1dc95a0cd1a1410be38ab6964f78fb15c
Author: Josh Law <objecting@objecting.org>

mm/damon/core: validate goal nid before accessing node data

This commit adds bounds checking and node_online() validation for the
goal->nid in the DAMON quota metrics. It prevents out-of-bounds accesses
to NODE_DATA() when an invalid or offline NUMA node is provided by userspace.

> diff --git a/mm/damon/core.c b/mm/damon/core.c
> index db6c67e52d2b..81ce27baa1a1 100644
> --- a/mm/damon/core.c
> +++ b/mm/damon/core.c
> @@ -2245,6 +2245,10 @@ static __kernel_ulong_t damos_get_node_mem_bp(
>  	struct sysinfo i;
>  	__kernel_ulong_t numerator;
>  
> +	if (goal->nid < 0 || goal->nid >= MAX_NUMNODES ||
> +	    !node_online(goal->nid))
> +		return 0;
> +
>  	si_meminfo_node(&i, goal->nid);
>  	if (goal->metric == DAMOS_QUOTA_NODE_MEM_USED_BP)
>  		numerator = i.totalram - i.freeram;
>  	else	/* DAMOS_QUOTA_NODE_MEM_FREE_BP */
>  		numerator = i.freeram;
>  	return mult_frac(numerator, 10000, i.totalram);

Could this cause a division by zero if the node is online but memoryless?

For CPU-only compute nodes or nodes where all memory has been hot-removed,
node_online(goal->nid) will evaluate to true. When si_meminfo_node() is
called for these memoryless nodes, it populates the sysinfo struct with
i.totalram = 0.

The mult_frac() macro unconditionally performs integer division and modulo
by the third argument, which could trigger a kernel panic when dividing by
zero.

Would it be safer to check if i.totalram is zero before returning, or use
node_state(goal->nid, N_MEMORY) instead of node_online()?

[ ... ]

> @@ -2261,6 +2265,10 @@ static unsigned long damos_get_node_memcg_used_bp(
>  	unsigned long used_pages, numerator;
>  	struct sysinfo i;
>  
> +	if (goal->nid < 0 || goal->nid >= MAX_NUMNODES ||
> +	    !node_online(goal->nid))
> +		return 0;
> +
>  	memcg = mem_cgroup_get_from_id(goal->memcg_id);

The same division by zero risk exists here when mult_frac() is called at the
end of this function.


# end of sashiko.dev inline review
# review url: https://sashiko.dev/#/patchset/20260325073034.140353-1-objecting@objecting.org
#
# hkml [1] generated a draft of this mail.  It can be regenerated
# using below command:
#
#     hkml patch sashiko_dev --for_forwarding \
#             20260325073034.140353-1-objecting@objecting.org
#
# [1] https://github.com/sjp38/hackermail

Sent using hkml (https://github.com/sjp38/hackermail)
Re: (sashiko review) [PATCH] mm/damon/core: validate goal nid before accessing node data
Posted by SeongJae Park 1 week, 1 day ago 
On Wed, 25 Mar 2026 07:37:39 -0700 SeongJae Park <sj@kernel.org> wrote:

> Forwarding Sashiko review for doing discussions via mails.
> 
> # review url: https://sashiko.dev/#/patchset/20260325073034.140353-1-objecting@objecting.org
> # start of sashiko.dev inline review
> commit 7e17cbe1dc95a0cd1a1410be38ab6964f78fb15c
> Author: Josh Law <objecting@objecting.org>
> 
> mm/damon/core: validate goal nid before accessing node data
> 
> This commit adds bounds checking and node_online() validation for the
> goal->nid in the DAMON quota metrics. It prevents out-of-bounds accesses
> to NODE_DATA() when an invalid or offline NUMA node is provided by userspace.
> 
> > diff --git a/mm/damon/core.c b/mm/damon/core.c
> > index db6c67e52d2b..81ce27baa1a1 100644
> > --- a/mm/damon/core.c
> > +++ b/mm/damon/core.c
> > @@ -2245,6 +2245,10 @@ static __kernel_ulong_t damos_get_node_mem_bp(
> >  	struct sysinfo i;
> >  	__kernel_ulong_t numerator;
> >  
> > +	if (goal->nid < 0 || goal->nid >= MAX_NUMNODES ||
> > +	    !node_online(goal->nid))
> > +		return 0;
> > +
> >  	si_meminfo_node(&i, goal->nid);
> >  	if (goal->metric == DAMOS_QUOTA_NODE_MEM_USED_BP)
> >  		numerator = i.totalram - i.freeram;
> >  	else	/* DAMOS_QUOTA_NODE_MEM_FREE_BP */
> >  		numerator = i.freeram;
> >  	return mult_frac(numerator, 10000, i.totalram);
> 
> Could this cause a division by zero if the node is online but memoryless?
> 
> For CPU-only compute nodes or nodes where all memory has been hot-removed,
> node_online(goal->nid) will evaluate to true. When si_meminfo_node() is
> called for these memoryless nodes, it populates the sysinfo struct with
> i.totalram = 0.
> 
> The mult_frac() macro unconditionally performs integer division and modulo
> by the third argument, which could trigger a kernel panic when dividing by
> zero.
> 
> Would it be safer to check if i.totalram is zero before returning, or use
> node_state(goal->nid, N_MEMORY) instead of node_online()?
> 
> [ ... ]
> 
> > @@ -2261,6 +2265,10 @@ static unsigned long damos_get_node_memcg_used_bp(
> >  	unsigned long used_pages, numerator;
> >  	struct sysinfo i;
> >  
> > +	if (goal->nid < 0 || goal->nid >= MAX_NUMNODES ||
> > +	    !node_online(goal->nid))
> > +		return 0;
> > +
> >  	memcg = mem_cgroup_get_from_id(goal->memcg_id);
> 
> The same division by zero risk exists here when mult_frac() is called at the
> end of this function.

I think sashiko's comments make sense.  I also suggested using
node_state(N_MEMORY).  What do you think, Josh?


Thanks,
SJ

[...]
Re: (sashiko review) [PATCH] mm/damon/core: validate goal nid before accessing node data
Posted by Josh Law 1 week, 1 day ago 

On 25 March 2026 15:04:10 GMT, SeongJae Park <sj@kernel.org> wrote:
>On Wed, 25 Mar 2026 07:37:39 -0700 SeongJae Park <sj@kernel.org> wrote:
>
>> Forwarding Sashiko review for doing discussions via mails.
>> 
>> # review url: https://sashiko.dev/#/patchset/20260325073034.140353-1-objecting@objecting.org
>> # start of sashiko.dev inline review
>> commit 7e17cbe1dc95a0cd1a1410be38ab6964f78fb15c
>> Author: Josh Law <objecting@objecting.org>
>> 
>> mm/damon/core: validate goal nid before accessing node data
>> 
>> This commit adds bounds checking and node_online() validation for the
>> goal->nid in the DAMON quota metrics. It prevents out-of-bounds accesses
>> to NODE_DATA() when an invalid or offline NUMA node is provided by userspace.
>> 
>> > diff --git a/mm/damon/core.c b/mm/damon/core.c
>> > index db6c67e52d2b..81ce27baa1a1 100644
>> > --- a/mm/damon/core.c
>> > +++ b/mm/damon/core.c
>> > @@ -2245,6 +2245,10 @@ static __kernel_ulong_t damos_get_node_mem_bp(
>> >  	struct sysinfo i;
>> >  	__kernel_ulong_t numerator;
>> >  
>> > +	if (goal->nid < 0 || goal->nid >= MAX_NUMNODES ||
>> > +	    !node_online(goal->nid))
>> > +		return 0;
>> > +
>> >  	si_meminfo_node(&i, goal->nid);
>> >  	if (goal->metric == DAMOS_QUOTA_NODE_MEM_USED_BP)
>> >  		numerator = i.totalram - i.freeram;
>> >  	else	/* DAMOS_QUOTA_NODE_MEM_FREE_BP */
>> >  		numerator = i.freeram;
>> >  	return mult_frac(numerator, 10000, i.totalram);
>> 
>> Could this cause a division by zero if the node is online but memoryless?
>> 
>> For CPU-only compute nodes or nodes where all memory has been hot-removed,
>> node_online(goal->nid) will evaluate to true. When si_meminfo_node() is
>> called for these memoryless nodes, it populates the sysinfo struct with
>> i.totalram = 0.
>> 
>> The mult_frac() macro unconditionally performs integer division and modulo
>> by the third argument, which could trigger a kernel panic when dividing by
>> zero.
>> 
>> Would it be safer to check if i.totalram is zero before returning, or use
>> node_state(goal->nid, N_MEMORY) instead of node_online()?
>> 
>> [ ... ]
>> 
>> > @@ -2261,6 +2265,10 @@ static unsigned long damos_get_node_memcg_used_bp(
>> >  	unsigned long used_pages, numerator;
>> >  	struct sysinfo i;
>> >  
>> > +	if (goal->nid < 0 || goal->nid >= MAX_NUMNODES ||
>> > +	    !node_online(goal->nid))
>> > +		return 0;
>> > +
>> >  	memcg = mem_cgroup_get_from_id(goal->memcg_id);
>> 
>> The same division by zero risk exists here when mult_frac() is called at the
>> end of this function.
>
>I think sashiko's comments make sense.  I also suggested using
>node_state(N_MEMORY).  What do you think, Josh?
>
>
>Thanks,
>SJ
>
>[...]


Yep, will do
Re: [PATCH] mm/damon/core: validate goal nid before accessing node data
Posted by SeongJae Park 1 week, 1 day ago 
On Wed, 25 Mar 2026 07:30:34 +0000 Josh Law <objecting@objecting.org> wrote:

> damos_get_node_mem_bp() and damos_get_node_memcg_used_bp() pass
> goal->nid directly to si_meminfo_node() and NODE_DATA() without
> checking that it refers to a valid, online NUMA node.  Since
> goal->nid is set from userspace via sysfs with no validation, a
> negative or out-of-range value causes an out-of-bounds access in
> NODE_DATA(), and a valid but offline node gives undefined results.

Nice catch!

> 
> Add bounds and node_online() checks before using the nid.
> 
> Fixes: 0e1c773b501f ("mm/damon/core: introduce damos quota goal metrics for memory node utilization")

Let's add Cc: stable.

> Signed-off-by: Josh Law <objecting@objecting.org>
> ---
>  mm/damon/core.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/mm/damon/core.c b/mm/damon/core.c
> index 59b709f04975..6ee421141996 100644
> --- a/mm/damon/core.c
> +++ b/mm/damon/core.c
> @@ -2227,6 +2227,10 @@ static __kernel_ulong_t damos_get_node_mem_bp(
>  	struct sysinfo i;
>  	__kernel_ulong_t numerator;
>  
> +	if (goal->nid < 0 || goal->nid >= MAX_NUMNODES ||
> +	    !node_online(goal->nid))

Like damon_migrate_pages(), how about using node_state(goal->nid, N_MEMORY)
insted of node_online()?

> +		return 0;
> +
>  	si_meminfo_node(&i, goal->nid);
>  	if (goal->metric == DAMOS_QUOTA_NODE_MEM_USED_BP)
>  		numerator = i.totalram - i.freeram;
> @@ -2243,6 +2247,10 @@ static unsigned long damos_get_node_memcg_used_bp(
>  	unsigned long used_pages, numerator;
>  	struct sysinfo i;
>  
> +	if (goal->nid < 0 || goal->nid >= MAX_NUMNODES ||
> +	    !node_online(goal->nid))

Ditto.

> +		return 0;
> +
>  	memcg = mem_cgroup_get_from_id(goal->memcg_id);
>  	if (!memcg) {
>  		if (goal->metric == DAMOS_QUOTA_NODE_MEMCG_USED_BP)
> -- 
> 2.34.1


Thanks,
SJ

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.