[v1] ASoC: qcom: audioreach: explicitly enable speaker protection modules

[PATCH v1] ASoC: qcom: audioreach: explicitly enable speaker protection modules

Posted by Ravi Hothi 1 week, 1 day ago

Speaker protection and VI feedback modules are disabled by default.
Explicitly enable them when configuring speaker protection.

Signed-off-by: Ravi Hothi <ravi.hothi@oss.qualcomm.com>
---
 sound/soc/qcom/qdsp6/audioreach.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/sound/soc/qcom/qdsp6/audioreach.c b/sound/soc/qcom/qdsp6/audioreach.c
index 241c3b4479c6..ff8cd55b0d89 100644
--- a/sound/soc/qcom/qdsp6/audioreach.c
+++ b/sound/soc/qcom/qdsp6/audioreach.c
@@ -1365,9 +1365,14 @@ int audioreach_set_media_format(struct q6apm_graph *graph,
 	case MODULE_ID_SPEAKER_PROTECTION:
 		rc = audioreach_speaker_protection(graph, module,
 						   PARAM_ID_SP_OP_MODE_NORMAL);
+		if (!rc)
+			rc = audioreach_module_enable(graph, module, true);
+
 		break;
 	case MODULE_ID_SPEAKER_PROTECTION_VI:
 		rc = audioreach_speaker_protection_vi(graph, module, cfg);
+		if (!rc)
+			rc = audioreach_module_enable(graph, module, true);
 		break;
 
 	default:
-- 
2.34.1

Re: [PATCH v1] ASoC: qcom: audioreach: explicitly enable speaker protection modules

Posted by Dmitry Baryshkov 1 week, 1 day ago

On Wed, Mar 25, 2026 at 11:14:08AM +0530, Ravi Hothi wrote:
> Speaker protection and VI feedback modules are disabled by default.
> Explicitly enable them when configuring speaker protection.
> 
> Signed-off-by: Ravi Hothi <ravi.hothi@oss.qualcomm.com>

Fixes?

> ---
>  sound/soc/qcom/qdsp6/audioreach.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 

-- 
With best wishes
Dmitry

Re: [PATCH v1] ASoC: qcom: audioreach: explicitly enable speaker protection modules

Posted by Ravi Hothi 1 week ago


On 3/25/2026 1:00 PM, Dmitry Baryshkov wrote:
> On Wed, Mar 25, 2026 at 11:14:08AM +0530, Ravi Hothi wrote:
>> Speaker protection and VI feedback modules are disabled by default.
>> Explicitly enable them when configuring speaker protection.
>>
>> Signed-off-by: Ravi Hothi <ravi.hothi@oss.qualcomm.com>
> 
> Fixes?

ACK, Will add the fixes tag.

Best Regards,
Ravi Hothi

> 
>> ---
>>   sound/soc/qcom/qdsp6/audioreach.c | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>