[PATCH 1/2] dt-bindings: iio: amplifiers: ad8366: add adrf5702/3 support

Rodrigo Alencar via B4 Relay posted 2 patches 1 week, 1 day ago
There is a newer version of this series
[PATCH 1/2] dt-bindings: iio: amplifiers: ad8366: add adrf5702/3 support
Posted by Rodrigo Alencar via B4 Relay 1 week, 1 day ago
From: Rodrigo Alencar <rodrigo.alencar@analog.com>

Add compatible entries for ADRF5702 and ADRF5703 Digital Attenuators.

Signed-off-by: Rodrigo Alencar <rodrigo.alencar@analog.com>
---
 Documentation/devicetree/bindings/iio/amplifiers/adi,ad8366.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/iio/amplifiers/adi,ad8366.yaml b/Documentation/devicetree/bindings/iio/amplifiers/adi,ad8366.yaml
index 2719de1166a1..065637ce33a5 100644
--- a/Documentation/devicetree/bindings/iio/amplifiers/adi,ad8366.yaml
+++ b/Documentation/devicetree/bindings/iio/amplifiers/adi,ad8366.yaml
@@ -20,6 +20,8 @@ properties:
       - adi,ad8366
       - adi,ada4961
       - adi,adl5240
+      - adi,adrf5702
+      - adi,adrf5703
       - adi,adrf5720
       - adi,adrf5730
       - adi,adrf5731
@@ -66,6 +68,8 @@ allOf:
               anyOf:
                 - const: adi,ad8366
                 - const: adi,ada4961
+                - const: adi,adrf5702
+                - const: adi,adrf5703
                 - const: adi,adrf5720
                 - const: adi,adrf5730
                 - const: adi,adrf5731

-- 
2.43.0
Re: [PATCH 1/2] dt-bindings: iio: amplifiers: ad8366: add adrf5702/3 support
Posted by Jonathan Cameron 1 week, 1 day ago
On Wed, 25 Mar 2026 11:12:02 +0000
Rodrigo Alencar via B4 Relay <devnull+rodrigo.alencar.analog.com@kernel.org> wrote:

> From: Rodrigo Alencar <rodrigo.alencar@analog.com>
> 
> Add compatible entries for ADRF5702 and ADRF5703 Digital Attenuators.

Explain how they are different from the existing supported devices.

Something simple like the "Each device has its own gain range and step,
hence no fallback compatibles are used." that you had in the original patch
is what we need here.

> 
> Signed-off-by: Rodrigo Alencar <rodrigo.alencar@analog.com>
> ---
>  Documentation/devicetree/bindings/iio/amplifiers/adi,ad8366.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/amplifiers/adi,ad8366.yaml b/Documentation/devicetree/bindings/iio/amplifiers/adi,ad8366.yaml
> index 2719de1166a1..065637ce33a5 100644
> --- a/Documentation/devicetree/bindings/iio/amplifiers/adi,ad8366.yaml
> +++ b/Documentation/devicetree/bindings/iio/amplifiers/adi,ad8366.yaml
> @@ -20,6 +20,8 @@ properties:
>        - adi,ad8366
>        - adi,ada4961
>        - adi,adl5240
> +      - adi,adrf5702
> +      - adi,adrf5703
>        - adi,adrf5720
>        - adi,adrf5730
>        - adi,adrf5731
> @@ -66,6 +68,8 @@ allOf:
>                anyOf:
>                  - const: adi,ad8366
>                  - const: adi,ada4961
> +                - const: adi,adrf5702
> +                - const: adi,adrf5703
>                  - const: adi,adrf5720
>                  - const: adi,adrf5730
>                  - const: adi,adrf5731
>
Re: [PATCH 1/2] dt-bindings: iio: amplifiers: ad8366: add adrf5702/3 support
Posted by Conor Dooley 1 week, 1 day ago
On Wed, Mar 25, 2026 at 12:46:27PM +0000, Jonathan Cameron wrote:
> On Wed, 25 Mar 2026 11:12:02 +0000
> Rodrigo Alencar via B4 Relay <devnull+rodrigo.alencar.analog.com@kernel.org> wrote:
> 
> > From: Rodrigo Alencar <rodrigo.alencar@analog.com>
> > 
> > Add compatible entries for ADRF5702 and ADRF5703 Digital Attenuators.
> 
> Explain how they are different from the existing supported devices.
> 
> Something simple like the "Each device has its own gain range and step,
> hence no fallback compatibles are used." that you had in the original patch
> is what we need here.

Which means that this is a v2 that doesn't say it is a v2, or explain
what has changed?

> 
> > 
> > Signed-off-by: Rodrigo Alencar <rodrigo.alencar@analog.com>
> > ---
> >  Documentation/devicetree/bindings/iio/amplifiers/adi,ad8366.yaml | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/amplifiers/adi,ad8366.yaml b/Documentation/devicetree/bindings/iio/amplifiers/adi,ad8366.yaml
> > index 2719de1166a1..065637ce33a5 100644
> > --- a/Documentation/devicetree/bindings/iio/amplifiers/adi,ad8366.yaml
> > +++ b/Documentation/devicetree/bindings/iio/amplifiers/adi,ad8366.yaml
> > @@ -20,6 +20,8 @@ properties:
> >        - adi,ad8366
> >        - adi,ada4961
> >        - adi,adl5240
> > +      - adi,adrf5702
> > +      - adi,adrf5703
> >        - adi,adrf5720
> >        - adi,adrf5730
> >        - adi,adrf5731
> > @@ -66,6 +68,8 @@ allOf:
> >                anyOf:
> >                  - const: adi,ad8366
> >                  - const: adi,ada4961
> > +                - const: adi,adrf5702
> > +                - const: adi,adrf5703
> >                  - const: adi,adrf5720
> >                  - const: adi,adrf5730
> >                  - const: adi,adrf5731
> > 
> 

pw-bot: changes-requested
Re: [PATCH 1/2] dt-bindings: iio: amplifiers: ad8366: add adrf5702/3 support
Posted by Jonathan Cameron 1 week, 1 day ago
On Wed, 25 Mar 2026 18:13:45 +0000
Conor Dooley <conor@kernel.org> wrote:

> On Wed, Mar 25, 2026 at 12:46:27PM +0000, Jonathan Cameron wrote:
> > On Wed, 25 Mar 2026 11:12:02 +0000
> > Rodrigo Alencar via B4 Relay <devnull+rodrigo.alencar.analog.com@kernel.org> wrote:
> >   
> > > From: Rodrigo Alencar <rodrigo.alencar@analog.com>
> > > 
> > > Add compatible entries for ADRF5702 and ADRF5703 Digital Attenuators.  
> > 
> > Explain how they are different from the existing supported devices.
> > 
> > Something simple like the "Each device has its own gain range and step,
> > hence no fallback compatibles are used." that you had in the original patch
> > is what we need here.  
> 
> Which means that this is a v2 that doesn't say it is a v2, or explain
> what has changed?

I meant the original driver - which only landed recently and answered
the question of difference nicely.

This is adding more parts to that - but I believe is a v1.

J
> 
> >   
> > > 
> > > Signed-off-by: Rodrigo Alencar <rodrigo.alencar@analog.com>
> > > ---
> > >  Documentation/devicetree/bindings/iio/amplifiers/adi,ad8366.yaml | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/iio/amplifiers/adi,ad8366.yaml b/Documentation/devicetree/bindings/iio/amplifiers/adi,ad8366.yaml
> > > index 2719de1166a1..065637ce33a5 100644
> > > --- a/Documentation/devicetree/bindings/iio/amplifiers/adi,ad8366.yaml
> > > +++ b/Documentation/devicetree/bindings/iio/amplifiers/adi,ad8366.yaml
> > > @@ -20,6 +20,8 @@ properties:
> > >        - adi,ad8366
> > >        - adi,ada4961
> > >        - adi,adl5240
> > > +      - adi,adrf5702
> > > +      - adi,adrf5703
> > >        - adi,adrf5720
> > >        - adi,adrf5730
> > >        - adi,adrf5731
> > > @@ -66,6 +68,8 @@ allOf:
> > >                anyOf:
> > >                  - const: adi,ad8366
> > >                  - const: adi,ada4961
> > > +                - const: adi,adrf5702
> > > +                - const: adi,adrf5703
> > >                  - const: adi,adrf5720
> > >                  - const: adi,adrf5730
> > >                  - const: adi,adrf5731
> > >   
> >   
> 
> pw-bot: changes-requested
Re: [PATCH 1/2] dt-bindings: iio: amplifiers: ad8366: add adrf5702/3 support
Posted by Conor Dooley 1 week ago
On Wed, Mar 25, 2026 at 07:19:53PM +0000, Jonathan Cameron wrote:
> On Wed, 25 Mar 2026 18:13:45 +0000
> Conor Dooley <conor@kernel.org> wrote:
> 
> > On Wed, Mar 25, 2026 at 12:46:27PM +0000, Jonathan Cameron wrote:
> > > On Wed, 25 Mar 2026 11:12:02 +0000
> > > Rodrigo Alencar via B4 Relay <devnull+rodrigo.alencar.analog.com@kernel.org> wrote:
> > >   
> > > > From: Rodrigo Alencar <rodrigo.alencar@analog.com>
> > > > 
> > > > Add compatible entries for ADRF5702 and ADRF5703 Digital Attenuators.  
> > > 
> > > Explain how they are different from the existing supported devices.
> > > 
> > > Something simple like the "Each device has its own gain range and step,
> > > hence no fallback compatibles are used." that you had in the original patch
> > > is what we need here.  
> > 
> > Which means that this is a v2 that doesn't say it is a v2, or explain
> > what has changed?
> 
> I meant the original driver - which only landed recently and answered
> the question of difference nicely.

Ah I see. Wording confused me!