[PATCH v8 0/5] platform/x86: uniwill-laptop: More support for TUXEDO devices

Werner Sembach posted 5 patches 1 week, 2 days ago
.../ABI/testing/sysfs-driver-uniwill-laptop   |  27 ++
.../admin-guide/laptops/uniwill-laptop.rst    |  12 +
drivers/platform/x86/uniwill/uniwill-acpi.c   | 439 +++++++++++++++---
3 files changed, 408 insertions(+), 70 deletions(-)
[PATCH v8 0/5] platform/x86: uniwill-laptop: More support for TUXEDO devices
Posted by Werner Sembach 1 week, 2 days ago
v2: Incorporate Armins feedback.
v3: Incorporate more of Armins feedback.
    Rework USB-C power prio functions
v4: Readd system vendor SchenkerTechnologiesGmbH for XMG FUSION (L19)
    Replace for loops with if statements for USB-C power priority functions
    Add missing mutex in usb_c_power_priority_restore
v5: Restructure patch around new entry for XMG Fusion
    Add missing Reviewed-by and Tested-by
    Spelling fixes in documentation
v6: Fix small format error in docs
    Fix Reviewed-by line
v7: Variable rename to lowercase
v8: Move USB-C power priority init to after probe call
    Clarify documentation

Armin Wolf (1):
  platform/x86: uniwill-laptop: Rework hwmon feature defines

Werner Sembach (4):
  platform/x86: uniwill-laptop: Implement USB-C power priority setting
  platform/x86: uniwill-laptop: Fix XMG Fusion 15 (L19) entries
  platform/x86: uniwill-laptop: Apply features across all TUXEDO devices
  Documentation: laptops: Update documentation for uniwill laptops

 .../ABI/testing/sysfs-driver-uniwill-laptop   |  27 ++
 .../admin-guide/laptops/uniwill-laptop.rst    |  12 +
 drivers/platform/x86/uniwill/uniwill-acpi.c   | 439 +++++++++++++++---
 3 files changed, 408 insertions(+), 70 deletions(-)


base-commit: 1f318b96cc84d7c2ab792fcc0bfd42a7ca890681
-- 
2.43.0
Re: [PATCH v8 0/5] platform/x86: uniwill-laptop: More support for TUXEDO devices
Posted by Ilpo Järvinen 1 week, 1 day ago
On Tue, 24 Mar 2026, Werner Sembach wrote:

> v2: Incorporate Armins feedback.
> v3: Incorporate more of Armins feedback.
>     Rework USB-C power prio functions
> v4: Readd system vendor SchenkerTechnologiesGmbH for XMG FUSION (L19)
>     Replace for loops with if statements for USB-C power priority functions
>     Add missing mutex in usb_c_power_priority_restore
> v5: Restructure patch around new entry for XMG Fusion
>     Add missing Reviewed-by and Tested-by
>     Spelling fixes in documentation
> v6: Fix small format error in docs
>     Fix Reviewed-by line
> v7: Variable rename to lowercase
> v8: Move USB-C power priority init to after probe call
>     Clarify documentation

Hi,

Does this conflict with something that went through the fixes branch? I 
tried applying this through for-next and get fails so I guess I'll have 
to merge fixes to for-next before I can apply this.

It would be nice to mention any known conflicts in the coverletter.

-- 
 i.
Re: [PATCH v8 0/5] platform/x86: uniwill-laptop: More support for TUXEDO devices
Posted by Werner Sembach 1 week, 1 day ago
Hi,

Am 25.03.26 um 13:40 schrieb Ilpo Järvinen:
> On Tue, 24 Mar 2026, Werner Sembach wrote:
>
>> v2: Incorporate Armins feedback.
>> v3: Incorporate more of Armins feedback.
>>      Rework USB-C power prio functions
>> v4: Readd system vendor SchenkerTechnologiesGmbH for XMG FUSION (L19)
>>      Replace for loops with if statements for USB-C power priority functions
>>      Add missing mutex in usb_c_power_priority_restore
>> v5: Restructure patch around new entry for XMG Fusion
>>      Add missing Reviewed-by and Tested-by
>>      Spelling fixes in documentation
>> v6: Fix small format error in docs
>>      Fix Reviewed-by line
>> v7: Variable rename to lowercase
>> v8: Move USB-C power priority init to after probe call
>>      Clarify documentation
> Hi,
>
> Does this conflict with something that went through the fixes branch? I
> tried applying this through for-next and get fails so I guess I'll have
> to merge fixes to for-next before I can apply this.
>
> It would be nice to mention any known conflicts in the coverletter.

sorry, I thought the base-commit line was enough

it applies cleanly to v7.0-rc3 and v7.0-rc4

earlier rc versions of 7.0 are missing a required patch

maybe for-next is not yet rebased on the latest rc?

I will have a look

>
Re: [PATCH v8 0/5] platform/x86: uniwill-laptop: More support for TUXEDO devices
Posted by Ilpo Järvinen 1 week, 1 day ago
On Wed, 25 Mar 2026, Werner Sembach wrote:

> Hi,
> 
> Am 25.03.26 um 13:40 schrieb Ilpo Järvinen:
> > On Tue, 24 Mar 2026, Werner Sembach wrote:
> > 
> > > v2: Incorporate Armins feedback.
> > > v3: Incorporate more of Armins feedback.
> > >      Rework USB-C power prio functions
> > > v4: Readd system vendor SchenkerTechnologiesGmbH for XMG FUSION (L19)
> > >      Replace for loops with if statements for USB-C power priority
> > > functions
> > >      Add missing mutex in usb_c_power_priority_restore
> > > v5: Restructure patch around new entry for XMG Fusion
> > >      Add missing Reviewed-by and Tested-by
> > >      Spelling fixes in documentation
> > > v6: Fix small format error in docs
> > >      Fix Reviewed-by line
> > > v7: Variable rename to lowercase
> > > v8: Move USB-C power priority init to after probe call
> > >      Clarify documentation
> > Hi,
> > 
> > Does this conflict with something that went through the fixes branch? I
> > tried applying this through for-next and get fails so I guess I'll have
> > to merge fixes to for-next before I can apply this.
> > 
> > It would be nice to mention any known conflicts in the coverletter.
> 
> sorry, I thought the base-commit line was enough
> 
> it applies cleanly to v7.0-rc3 and v7.0-rc4
> 
> earlier rc versions of 7.0 are missing a required patch

Okay, so there's a dependency for some commit that went through 'fixes'?

> maybe for-next is not yet rebased on the latest rc?

'fixes' and 'for-next' are sort of independent normally. Both are based at 
-rc1.

I don't rebase 'for-next' from -rc1. If there's a conflict or some 'fixes' 
commit needed for a work to be done in 'for-next', I'll resolve those by 
merging 'fixes' changes back into 'for-next.

> I will have a look

-- 
 i.
Re: [PATCH v8 0/5] platform/x86: uniwill-laptop: More support for TUXEDO devices
Posted by Werner Sembach 1 week, 1 day ago
Hi,

Am 25.03.26 um 14:06 schrieb Ilpo Järvinen:
> On Wed, 25 Mar 2026, Werner Sembach wrote:
>
>> Hi,
>>
>> Am 25.03.26 um 13:40 schrieb Ilpo Järvinen:
>>> On Tue, 24 Mar 2026, Werner Sembach wrote:
>>>
>>>> v2: Incorporate Armins feedback.
>>>> v3: Incorporate more of Armins feedback.
>>>>       Rework USB-C power prio functions
>>>> v4: Readd system vendor SchenkerTechnologiesGmbH for XMG FUSION (L19)
>>>>       Replace for loops with if statements for USB-C power priority
>>>> functions
>>>>       Add missing mutex in usb_c_power_priority_restore
>>>> v5: Restructure patch around new entry for XMG Fusion
>>>>       Add missing Reviewed-by and Tested-by
>>>>       Spelling fixes in documentation
>>>> v6: Fix small format error in docs
>>>>       Fix Reviewed-by line
>>>> v7: Variable rename to lowercase
>>>> v8: Move USB-C power priority init to after probe call
>>>>       Clarify documentation
>>> Hi,
>>>
>>> Does this conflict with something that went through the fixes branch? I
>>> tried applying this through for-next and get fails so I guess I'll have
>>> to merge fixes to for-next before I can apply this.
>>>
>>> It would be nice to mention any known conflicts in the coverletter.
>> sorry, I thought the base-commit line was enough
>>
>> it applies cleanly to v7.0-rc3 and v7.0-rc4
>>
>> earlier rc versions of 7.0 are missing a required patch
> Okay, so there's a dependency for some commit that went through 'fixes'?
>
>> maybe for-next is not yet rebased on the latest rc?
> 'fixes' and 'for-next' are sort of independent normally. Both are based at
> -rc1.

Ah sorry didn't know that, thought for-next moves along the different rc 
releases and so I only checked if it applies to torvalds/master.

Quick checked the missing patchset is this one: 
https://lore.kernel.org/all/20260218005101.73680-1-W_Armin@gmx.de/ it came in 
between rc2 and rc3.

Best regards,

Werner

>
> I don't rebase 'for-next' from -rc1. If there's a conflict or some 'fixes'
> commit needed for a work to be done in 'for-next', I'll resolve those by
> merging 'fixes' changes back into 'for-next.
>
>> I will have a look
Re: [PATCH v8 0/5] platform/x86: uniwill-laptop: More support for TUXEDO devices
Posted by Ilpo Järvinen 1 week, 1 day ago
On Wed, 25 Mar 2026, Werner Sembach wrote:

> Hi,
> 
> Am 25.03.26 um 14:06 schrieb Ilpo Järvinen:
> > On Wed, 25 Mar 2026, Werner Sembach wrote:
> > 
> > > Hi,
> > > 
> > > Am 25.03.26 um 13:40 schrieb Ilpo Järvinen:
> > > > On Tue, 24 Mar 2026, Werner Sembach wrote:
> > > > 
> > > > > v2: Incorporate Armins feedback.
> > > > > v3: Incorporate more of Armins feedback.
> > > > >       Rework USB-C power prio functions
> > > > > v4: Readd system vendor SchenkerTechnologiesGmbH for XMG FUSION (L19)
> > > > >       Replace for loops with if statements for USB-C power priority
> > > > > functions
> > > > >       Add missing mutex in usb_c_power_priority_restore
> > > > > v5: Restructure patch around new entry for XMG Fusion
> > > > >       Add missing Reviewed-by and Tested-by
> > > > >       Spelling fixes in documentation
> > > > > v6: Fix small format error in docs
> > > > >       Fix Reviewed-by line
> > > > > v7: Variable rename to lowercase
> > > > > v8: Move USB-C power priority init to after probe call
> > > > >       Clarify documentation
> > > > Hi,
> > > > 
> > > > Does this conflict with something that went through the fixes branch? I
> > > > tried applying this through for-next and get fails so I guess I'll have
> > > > to merge fixes to for-next before I can apply this.
> > > > 
> > > > It would be nice to mention any known conflicts in the coverletter.
> > > sorry, I thought the base-commit line was enough
> > > 
> > > it applies cleanly to v7.0-rc3 and v7.0-rc4
> > > 
> > > earlier rc versions of 7.0 are missing a required patch
> > Okay, so there's a dependency for some commit that went through 'fixes'?
> > 
> > > maybe for-next is not yet rebased on the latest rc?
> > 'fixes' and 'for-next' are sort of independent normally. Both are based at
> > -rc1.
> 
> Ah sorry didn't know that, thought for-next moves along the different rc
> releases and so I only checked if it applies to torvalds/master.
> 
> Quick checked the missing patchset is this one:
> https://lore.kernel.org/all/20260218005101.73680-1-W_Armin@gmx.de/ it came in
> between rc2 and rc3.

Thanks, for taking a look. I assumed it that series might be the cause.

I'll pull fixes into for-next once Linus has pulled in the PR I just sent 
(so I know the commit IDs remain cast into the stone), and then apply your 
on top into for-next (a tentative plan).

> > I don't rebase 'for-next' from -rc1. If there's a conflict or some 'fixes'
> > commit needed for a work to be done in 'for-next', I'll resolve those by
> > merging 'fixes' changes back into 'for-next.
> > 
> > > I will have a look

-- 
 i.
Re: [PATCH v8 0/5] platform/x86: uniwill-laptop: More support for TUXEDO devices
Posted by Ilpo Järvinen 2 days, 17 hours ago
On Tue, 24 Mar 2026 21:32:07 +0100, Werner Sembach wrote:

> v2: Incorporate Armins feedback.
> v3: Incorporate more of Armins feedback.
>     Rework USB-C power prio functions
> v4: Readd system vendor SchenkerTechnologiesGmbH for XMG FUSION (L19)
>     Replace for loops with if statements for USB-C power priority functions
>     Add missing mutex in usb_c_power_priority_restore
> v5: Restructure patch around new entry for XMG Fusion
>     Add missing Reviewed-by and Tested-by
>     Spelling fixes in documentation
> v6: Fix small format error in docs
>     Fix Reviewed-by line
> v7: Variable rename to lowercase
> v8: Move USB-C power priority init to after probe call
>     Clarify documentation
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/5] platform/x86: uniwill-laptop: Rework hwmon feature defines
      commit: f3660b13495ae47d0ab2755a7b32999fb718ee5c
[2/5] platform/x86: uniwill-laptop: Implement USB-C power priority setting
      commit: 03ae0a0d0973b9e584a05136aab08fee2ef8e455
[3/5] platform/x86: uniwill-laptop: Fix XMG Fusion 15 (L19) entries
      commit: ab97e28be21181a7f08300de1088f48e9f8274a9
[4/5] platform/x86: uniwill-laptop: Apply features across all TUXEDO devices
      commit: a5ee4c959b0efc347cdf6565ebcbc81131ff3677
[5/5] Documentation: laptops: Update documentation for uniwill laptops
      commit: 9ec6bf62cf98e30c7126a0f51ee7cdf2e8d458b6

--
 i.