Change in v4:
- Address coding style comments for disp-tdshp binding. 
- Rebase ccorr driver patch on top of latest linux-next to fix conficts.

Jay Liu (6):
  dt-bindings: display: mediatek: gamma: Add support for MT8196
  dt-bindings: display: mediatek: dither: Add support for MT8196
  dt-bindings: display: mediatek: ccorr: Add support for MT8196
  dt-bindings: display: mediatek: disp-tdshp: Add support for MT8196
  drm/mediatek: Support multiple CCORR component
  drm/mediatek: Add TDSHP component support for MT8196

 .../display/mediatek/mediatek,ccorr.yaml      |  1 +
 .../display/mediatek/mediatek,disp-tdshp.yaml | 46 ++++++++++++++++
 .../display/mediatek/mediatek,dither.yaml     |  1 +
 .../display/mediatek/mediatek,gamma.yaml      |  1 +
 drivers/gpu/drm/mediatek/mtk_crtc.c           |  5 +-
 drivers/gpu/drm/mediatek/mtk_ddp_comp.c       | 52 ++++++++++++++++++-
 drivers/gpu/drm/mediatek/mtk_ddp_comp.h       |  8 +--
 drivers/gpu/drm/mediatek/mtk_disp_ccorr.c     |  6 ++-
 drivers/gpu/drm/mediatek/mtk_disp_drv.h       |  2 +-
 drivers/gpu/drm/mediatek/mtk_drm_drv.c        |  2 +
 10 files changed, 116 insertions(+), 8 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,disp-tdshp.yaml

-- 
2.46.0

On Tue, Mar 24, 2026 at 08:51:57PM +0800, Jay Liu wrote:
> Change in v4:
> - Address coding style comments for disp-tdshp binding. 

Coding style? Why so vague? So does that mean you ignored all important
changes but did the "style" things?

> - Rebase ccorr driver patch on top of latest linux-next to fix conficts.

Where is the rest of the changeglog?

Why aren't you using b4 to provide also lore links and solve above
problem?

Best regards,
Krzysztof

On Wed, 2026-03-25 at 09:17 +0100, Krzysztof Kozlowski wrote:
> On Tue, Mar 24, 2026 at 08:51:57PM +0800, Jay Liu wrote:
> > Change in v4:
> > - Address coding style comments for disp-tdshp binding. 
> 
> Coding style? Why so vague? So does that mean you ignored all
> important
> changes but did the "style" things?
> 
> > - Rebase ccorr driver patch on top of latest linux-next to fix
> > conficts.
> 
> Where is the rest of the changeglog?
> 
> Why aren't you using b4 to provide also lore links and solve above
> problem?
> 
> Best regards,
> Krzysztof
> 

Dear Krzysztof,

I sincerely apologize for the confusion caused by my vague changelog.
My intention was to be concise, but I realize it made it look like I
ignored your technical feedback, which was not the case.

I have actually implemented the changes you requested in v3. Here is
the detailed breakdown of what was fixed in v4:

1. Sibling description: Removed as suggested.
2. Enum: Dropped the items list and used enum directly.
3. Formatting: Removed the extra blank line and fixed the indentation
in the example section.

Regarding the Node Name (disp-tdshp):
This was the only item I hesitated to change. "tdshp" stands for "2D
sharpness", and I kept it to align with MediaTek's internal naming.
However, I understand the upstream requirement for generic names. Since
this is a sharpness engine, would you prefer "sharpness-processor" or
something similar?

And Thank you for the recommendation regarding b4. I will set it up for
future submissions to ensure lore links and changelogs are generated
correctly.

I will send a v5 with a proper changelog and the node name update once
we agree on the name.

Please let me know if I missed any other comments or if you have
further suggestions. I will do my best to address them.

Best regards,
Jay