NFC support for two Qualcomm SDM845 phones

[PATCH v2 1/2] arm64: dts: qcom: sdm845-oneplus: Enable NFC

Posted by David Heidelberg via B4 Relay 1 week, 5 days ago

From: biemster <l.j.beemster@gmail.com>

Enable NFC controller NXP PN553, which is part of the package NXP NQ330
(NFC + eSE).

Signed-off-by: biemster <l.j.beemster@gmail.com>
Co-developed-by: David Heidelberg <david@ixit.cz>
Signed-off-by: David Heidelberg <david@ixit.cz>
---
 .../arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 31 ++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
index 5b121ea5520f5..4fbce4233a773 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
@@ -392,6 +392,25 @@ &gpu_zap_shader {
 	firmware-name = "qcom/sdm845/OnePlus/enchilada/a630_zap.mbn";
 };
 
+&i2c3 {
+	clock-frequency = <400000>;
+
+	status = "okay";
+
+	nfc@28 {
+		compatible = "nxp,pn553", "nxp,nxp-nci-i2c";
+		reg = <0x28>;
+
+		interrupts-extended = <&tlmm 63 IRQ_TYPE_EDGE_RISING>;
+
+		enable-gpios = <&tlmm 12 GPIO_ACTIVE_HIGH>;
+		firmware-gpios = <&tlmm 62 GPIO_ACTIVE_HIGH>;
+
+		pinctrl-0 = <&nfc_default>;
+		pinctrl-names = "default";
+	};
+};
+
 &i2c10 {
 	status = "okay";
 	clock-frequency = <100000>;
@@ -594,6 +613,11 @@ &qupv3_id_0 {
 	status = "okay";
 };
 
+&qup_i2c3_default {
+	drive-strength = <2>;
+	bias-disable;
+};
+
 &qup_i2c10_default {
 	drive-strength = <2>;
 	bias-disable;
@@ -926,6 +950,13 @@ speaker_default: speaker-default-state {
 		bias-pull-up;
 		output-high;
 	};
+
+	nfc_default: nfc-default-state {
+		pins = "gpio12", "gpio62", "gpio63";
+		function = "gpio";
+		drive-strength = <6>;
+		bias-pull-up;
+	};
 };
 
 &venus {

-- 
2.53.0

Re: [PATCH v2 1/2] arm64: dts: qcom: sdm845-oneplus: Enable NFC

Posted by Krzysztof Kozlowski 1 week, 5 days ago

On 24/03/2026 00:20, David Heidelberg via B4 Relay wrote:
> From: biemster <l.j.beemster@gmail.com>
> 
> Enable NFC controller NXP PN553, which is part of the package NXP NQ330
> (NFC + eSE).
> 
> Signed-off-by: biemster <l.j.beemster@gmail.com>

Same comment as last time. We do not take anonymous contributions.

Best regards,
Krzysztof

Re: [PATCH v2 1/2] arm64: dts: qcom: sdm845-oneplus: Enable NFC

Posted by David Heidelberg 1 week, 5 days ago

On 24/03/2026 08:03, Krzysztof Kozlowski wrote:
> On 24/03/2026 00:20, David Heidelberg via B4 Relay wrote:
>> From: biemster <l.j.beemster@gmail.com>
>>
>> Enable NFC controller NXP PN553, which is part of the package NXP NQ330
>> (NFC + eSE).
>>
>> Signed-off-by: biemster <l.j.beemster@gmail.com>
> 
> Same comment as last time. We do not take anonymous contributions.

 > then you just add a line saying:
 >
 > Signed-off-by: Random J Developer <random@developer.example.org>
 >
 > using a known identity (sorry, no anonymous contributions.)

Quoting the kernel documentation, biemster is known contributor to us (hanging 
in sdm845-next chat room, I'm personally aware of his presence for more than ~ 2 
years).

I could switch Author / Co-developed-by with me in this case, but since biemster 
did the initial work, it feels right to keep the credit.

David

> 
> Best regards,
> Krzysztof

-- 
David Heidelberg

Re: [PATCH v2 1/2] arm64: dts: qcom: sdm845-oneplus: Enable NFC

Posted by Krzysztof Kozlowski 1 week, 5 days ago

On 24/03/2026 10:35, David Heidelberg wrote:
> On 24/03/2026 08:03, Krzysztof Kozlowski wrote:
>> On 24/03/2026 00:20, David Heidelberg via B4 Relay wrote:
>>> From: biemster <l.j.beemster@gmail.com>
>>>
>>> Enable NFC controller NXP PN553, which is part of the package NXP NQ330
>>> (NFC + eSE).
>>>
>>> Signed-off-by: biemster <l.j.beemster@gmail.com>
>>
>> Same comment as last time. We do not take anonymous contributions.
> 
>  > then you just add a line saying:
>  >
>  > Signed-off-by: Random J Developer <random@developer.example.org>
>  >
>  > using a known identity (sorry, no anonymous contributions.)
> 
> Quoting the kernel documentation, biemster is known contributor to us (hanging 
> in sdm845-next chat room, I'm personally aware of his presence for more than ~ 2 
> years).
> 
> I could switch Author / Co-developed-by with me in this case, but since biemster 
> did the initial work, it feels right to keep the credit.

Hanging in chat room is not a definition of a known contributor.
Absolutely anyone can be behind a nickname on IRC channel. Or Github repo.

The kernel docs is not asking for known contributors. We ask for *known
identity*.

Quoting:
"sorry, no anonymous contributions."

Best regards,
Krzysztof