On 3/24/26 12:48, Alexander Koskovich wrote:
> Use default instead of listing unsupported formats explicitly, so the
> switch statements don't need updating each time a new pixel format is
> added.
>
> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
> Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
> ---
> drivers/gpu/drm/meson/meson_dw_mipi_dsi.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c b/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c
> index 66c73c512b0e..4412bd678108 100644
> --- a/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c
> +++ b/drivers/gpu/drm/meson/meson_dw_mipi_dsi.c
> @@ -119,8 +119,7 @@ static int dw_mipi_dsi_phy_init(void *priv_data)
> dpi_data_format = DPI_COLOR_18BIT_CFG_2;
> venc_data_width = VENC_IN_COLOR_18B;
> break;
> - case MIPI_DSI_FMT_RGB666_PACKED:
> - case MIPI_DSI_FMT_RGB565:
> + default:
> return -EINVAL;
> }
>
> @@ -232,8 +231,7 @@ static int meson_dw_mipi_dsi_host_attach(void *priv_data,
> break;
> case MIPI_DSI_FMT_RGB666:
> break;
> - case MIPI_DSI_FMT_RGB666_PACKED:
> - case MIPI_DSI_FMT_RGB565:
> + default:
> dev_err(mipi_dsi->dev, "invalid pixel format %d\n", device->format);
> return -EINVAL;
> }
>
Feel free to merge it in msm-next or other drm branch:
Acked-by: Neil Armstrong <neil.armstrong@linaro.org>
Thanks,
Neil