Here are some fixes for rxrpc:
(1) Fix key quota calculation.
(2) Fix a memory leak.
(3) Fix rxrpc_new_client_call_for_sendmsg() to substitute NULL for an
empty key.
Might want to remove this substitution entirely or handle it in
rxrpc_init_client_call_security() instead.
(4) Not strictly a fix, but move on_list_rcu() from apparmor to list.h so
that (5) can use it as list_empty() is not sufficient. Also add an
on_list() function.
(5) Fix deletion of call->link to be RCU safe.
(6) Fix missing bounds checks when parsing RxGK tickets.
(7) Fix use of wrong skbuff to get challenge serial number. Also actually
substitute the newer response skbuff and release the older one.
(8) Fix unexpected RACK timer warning to report old mode.
(9) Fix server keyring refcount leak.
(10) Fix call key refcount leak.
With respect to the AI review[1]:
(*) The use of rcu_read_lock_held() to avoid deferring call cleanup off to
a worker thread needs more consideration and so is unaddressed here.
I don't want to defer the cleanup if I can avoid it, but I'm not sure
how better to do it.
(*) rxrpc_put_call() shouldn't now be called in irq or softirq contexts,
even from a timer; __refcount_inc_not_zero() and a spinlock are used
in rxrpc_poke_call() to render that unnecessary.
David
The patches can be found here also:
http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-fixes
Changes
=======
ver #2)
- AI review[1]:
- Added a patch to fix key quota calculation.
- Added a patch to fix a memory leak.
- Added a patch to use NULL instead of an empty key in rxrpc_sengmsg().
- Added a patch to use RCU-safe deletion on call->link.
- Modified the response packet selection patch to select the newer
response when there's an older response - and to release the older
response skbuff.
- Move on_list_rcu() and add on_list().
Link: https://sashiko.dev/#/patchset/20260319150150.4189381-1-dhowells%40redhat.com [1]
Alok Tiwari (2):
rxrpc: Fix use of wrong skb when comparing queued RESP challenge
serial
rxrpc: Fix rack timer warning to report unexpected mode
Anderson Nascimento (2):
rxrpc: Fix keyring reference count leak in rxrpc_setsockopt()
rxrpc: Fix key reference count leak from call->key
David Howells (5):
rxrpc: Fix key quota calculation for multitoken keys
rxrpc: Fix key parsing memleak
rxrpc: Fix anonymous key handling
list: Move on_list_rcu() to list.h and add on_list() also
rxrpc: Fix call removal to use RCU safe deletion
Oleh Konko (1):
rxrpc: Fix RxGK token loading to check bounds
include/linux/list.h | 26 ++++++++++++++++++++
include/trace/events/rxrpc.h | 1 +
net/rxrpc/af_rxrpc.c | 2 +-
net/rxrpc/call_object.c | 7 +++---
net/rxrpc/conn_event.c | 5 ++--
net/rxrpc/input_rack.c | 2 +-
net/rxrpc/key.c | 38 +++++++++++++++++-------------
net/rxrpc/sendmsg.c | 2 +-
security/apparmor/include/policy.h | 2 --
9 files changed, 59 insertions(+), 26 deletions(-)