[PATCH v6 09/15] arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes, change path

Paul Sajna posted 15 patches 1 week, 1 day ago
Only 12 patches received!
[PATCH v6 09/15] arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes, change path
Posted by Paul Sajna 1 week, 1 day ago
Add paths for Qualcomm firmware, including:
ipa, modem, venus, gpu

GPU and bluetooth are confirmed working, others may need more
testing/fixes

But regardless they will need the firmware paths specified here
and firmware added upstream before they will work, so might as well
get started on it now.

Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
---
 arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi |  2 ++
 arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts  | 16 ++++++++++++----
 2 files changed, 14 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
index a5a04ec11eb7..dd42ed0bf63e 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
@@ -464,6 +464,8 @@ &gpu {
 
 &ipa {
 	qcom,gsi-loader = "modem";
+	memory-region = <&ipa_fw_mem>;
+
 	status = "okay";
 };
 
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
index 46119630d721..7948fe3dbaa2 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
@@ -46,7 +46,7 @@ battery: battery {
 };
 
 &adsp_pas {
-	firmware-name = "qcom/sdm845/judyln/adsp.mbn";
+	firmware-name = "qcom/sdm845/LG/judyln/adsp.mbn";
 };
 
 &bluetooth {
@@ -58,11 +58,15 @@ &bluetooth {
 };
 
 &cdsp_pas {
-	firmware-name = "qcom/sdm845/judyln/cdsp.mbn";
+	firmware-name = "qcom/sdm845/LG/judyln/cdsp.mbn";
 };
 
 &gpu_zap_shader {
-	firmware-name = "qcom/sdm845/judyln/a630_zap.mbn";
+	firmware-name = "qcom/sdm845/LG/judyln/a630_zap.mbn";
+};
+
+&ipa {
+	firmware-name = "qcom/sdm845/LG/judyln/ipa_fws.mbn";
 };
 
 &mdss {
@@ -128,7 +132,7 @@ &lab {
 };
 
 &mss_pil {
-	firmware-name = "qcom/sdm845/judyln/mba.mbn", "qcom/sdm845/judyln/modem.mbn";
+	firmware-name = "qcom/sdm845/LG/judyln/mba.mbn", "qcom/sdm845/LG/judyln/modem.mbn";
 };
 
 &pmi8998_charger {
@@ -167,3 +171,7 @@ sde_te_active_sleep: sde-te-active-sleep-state {
 		bias-pull-down;
 	};
 };
+
+&venus {
+	firmware-name = "qcom/sdm845/LG/judyln/venus.mbn";
+};

-- 
2.53.0
Re: [PATCH v6 09/15] arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes, change path
Posted by Dmitry Baryshkov 1 week ago
On Mon, Mar 23, 2026 at 07:06:39PM -0700, Paul Sajna wrote:
> Add paths for Qualcomm firmware, including:
> ipa, modem, venus, gpu
> 
> GPU and bluetooth are confirmed working, others may need more
> testing/fixes
> 
> But regardless they will need the firmware paths specified here
> and firmware added upstream before they will work, so might as well
> get started on it now.

Please move this to become patch #2.

> 
> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> ---
>  arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi |  2 ++
>  arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts  | 16 ++++++++++++----
>  2 files changed, 14 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> index a5a04ec11eb7..dd42ed0bf63e 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> @@ -464,6 +464,8 @@ &gpu {
>  
>  &ipa {
>  	qcom,gsi-loader = "modem";
> +	memory-region = <&ipa_fw_mem>;
> +
>  	status = "okay";
>  };

This looks like a separate fix.

>  
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> index 46119630d721..7948fe3dbaa2 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> @@ -46,7 +46,7 @@ battery: battery {
>  };
>  
>  &adsp_pas {
> -	firmware-name = "qcom/sdm845/judyln/adsp.mbn";
> +	firmware-name = "qcom/sdm845/LG/judyln/adsp.mbn";
>  };
>  
>  &bluetooth {
> @@ -58,11 +58,15 @@ &bluetooth {
>  };
>  
>  &cdsp_pas {
> -	firmware-name = "qcom/sdm845/judyln/cdsp.mbn";
> +	firmware-name = "qcom/sdm845/LG/judyln/cdsp.mbn";
>  };
>  
>  &gpu_zap_shader {
> -	firmware-name = "qcom/sdm845/judyln/a630_zap.mbn";
> +	firmware-name = "qcom/sdm845/LG/judyln/a630_zap.mbn";
> +};
> +
> +&ipa {
> +	firmware-name = "qcom/sdm845/LG/judyln/ipa_fws.mbn";
>  };
>  
>  &mdss {
> @@ -128,7 +132,7 @@ &lab {
>  };
>  
>  &mss_pil {
> -	firmware-name = "qcom/sdm845/judyln/mba.mbn", "qcom/sdm845/judyln/modem.mbn";
> +	firmware-name = "qcom/sdm845/LG/judyln/mba.mbn", "qcom/sdm845/LG/judyln/modem.mbn";
>  };
>  
>  &pmi8998_charger {
> @@ -167,3 +171,7 @@ sde_te_active_sleep: sde-te-active-sleep-state {
>  		bias-pull-down;
>  	};
>  };
> +
> +&venus {
> +	firmware-name = "qcom/sdm845/LG/judyln/venus.mbn";
> +};
> 
> -- 
> 2.53.0
> 

-- 
With best wishes
Dmitry
Re: [PATCH v6 09/15] arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes, change path
Posted by Paul Sajna 1 week ago
March 24, 2026 at 8:56 PM, "Dmitry Baryshkov" <dmitry.baryshkov@oss.qualcomm.com mailto:dmitry.baryshkov@oss.qualcomm.com?to=%22Dmitry%20Baryshkov%22%20%3Cdmitry.baryshkov%40oss.qualcomm.com%3E > wrote:


> >  &ipa {
> >  qcom,gsi-loader = "modem";
> >  + memory-region = <&ipa_fw_mem>;
> >  +
> >  status = "okay";
> >  };
> > 
> This looks like a separate fix.

Should I put it in the gsi-loader commit, or keep it completely separate?
Re: [PATCH v6 09/15] arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes, change path
Posted by Dmitry Baryshkov 1 week ago
On Wed, Mar 25, 2026 at 02:03:47AM +0000, Paul Sajna wrote:
> March 24, 2026 at 8:56 PM, "Dmitry Baryshkov" <dmitry.baryshkov@oss.qualcomm.com mailto:dmitry.baryshkov@oss.qualcomm.com?to=%22Dmitry%20Baryshkov%22%20%3Cdmitry.baryshkov%40oss.qualcomm.com%3E > wrote:
> 
> 
> > >  &ipa {
> > >  qcom,gsi-loader = "modem";
> > >  + memory-region = <&ipa_fw_mem>;
> > >  +
> > >  status = "okay";
> > >  };
> > > 
> > This looks like a separate fix.
> 
> Should I put it in the gsi-loader commit, or keep it completely separate?

I think, together. 


-- 
With best wishes
Dmitry
Re: [PATCH v6 09/15] arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes, change path
Posted by Konrad Dybcio 1 week, 1 day ago
On 3/24/26 3:06 AM, Paul Sajna wrote:
> Add paths for Qualcomm firmware, including:
> ipa, modem, venus, gpu
> 
> GPU and bluetooth are confirmed working, others may need more
> testing/fixes
> 
> But regardless they will need the firmware paths specified here
> and firmware added upstream before they will work, so might as well
> get started on it now.

What about the other board (judyp)?

Konrad
Re: [PATCH v6 09/15] arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes, change path
Posted by Paul Sajna 1 week, 1 day ago
March 24, 2026 at 10:49 AM, "Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com mailto:konrad.dybcio@oss.qualcomm.com?to=%22Konrad%20Dybcio%22%20%3Ckonrad.dybcio%40oss.qualcomm.com%3E > wrote:
> What about the other board (judyp)?
> 
> Konrad
>

I don't have it.
Re: [PATCH v6 09/15] arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes, change path
Posted by Dmitry Baryshkov 1 week ago
On Tue, Mar 24, 2026 at 04:17:09PM +0000, Paul Sajna wrote:
> March 24, 2026 at 10:49 AM, "Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com mailto:konrad.dybcio@oss.qualcomm.com?to=%22Konrad%20Dybcio%22%20%3Ckonrad.dybcio%40oss.qualcomm.com%3E > wrote:
> > What about the other board (judyp)?
> > 
> > Konrad
> >
> 
> I don't have it.

You don't need it to define firmware paths.


-- 
With best wishes
Dmitry
Re: [PATCH v6 09/15] arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes, change path
Posted by Paul Sajna 1 week ago
March 24, 2026 at 8:55 PM, "Dmitry Baryshkov" <dmitry.baryshkov@oss.qualcomm.com mailto:dmitry.baryshkov@oss.qualcomm.com?to=%22Dmitry%20Baryshkov%22%20%3Cdmitry.baryshkov%40oss.qualcomm.com%3E > wrote:


> 
> On Tue, Mar 24, 2026 at 04:17:09PM +0000, Paul Sajna wrote:
> 
> > 
> > March 24, 2026 at 10:49 AM, "Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com mailto:konrad.dybcio@oss.qualcomm.com?to=%22Konrad%20Dybcio%22%20%3Ckonrad.dybcio%40oss.qualcomm.com%3E > wrote:
> >  What about the other board (judyp)?
> >  
> >  Konrad
> > 
> >  
> >  I don't have it.
> > 
> You don't need it to define firmware paths.
> 
> -- 
> With best wishes
> Dmitry
>

Should I put firmware-paths for both boards in 1 commit or 2?
Re: [PATCH v6 09/15] arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes, change path
Posted by Dmitry Baryshkov 1 week ago
On Wed, Mar 25, 2026 at 02:35:33AM +0000, Paul Sajna wrote:
> March 24, 2026 at 8:55 PM, "Dmitry Baryshkov" <dmitry.baryshkov@oss.qualcomm.com mailto:dmitry.baryshkov@oss.qualcomm.com?to=%22Dmitry%20Baryshkov%22%20%3Cdmitry.baryshkov%40oss.qualcomm.com%3E > wrote:
> 
> 
> > 
> > On Tue, Mar 24, 2026 at 04:17:09PM +0000, Paul Sajna wrote:
> > 
> > > 
> > > March 24, 2026 at 10:49 AM, "Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com mailto:konrad.dybcio@oss.qualcomm.com?to=%22Konrad%20Dybcio%22%20%3Ckonrad.dybcio%40oss.qualcomm.com%3E > wrote:
> > >  What about the other board (judyp)?
> > >  
> > >  Konrad
> > > 
> > >  
> > >  I don't have it.
> > > 
> > You don't need it to define firmware paths.
> > 
> > -- 
> > With best wishes
> > Dmitry
> >
> 
> Should I put firmware-paths for both boards in 1 commit or 2?

Either is fine. My slight preference would be towards two commits.

-- 
With best wishes
Dmitry