[PATCH v2 4/5] dt-bindings: usb: qcom,snps-dwc3: Add constraints for SM4250

Krzysztof Kozlowski posted 5 patches 1 week, 6 days ago
[PATCH v2 4/5] dt-bindings: usb: qcom,snps-dwc3: Add constraints for SM4250
Posted by Krzysztof Kozlowski 1 week, 6 days ago
The qcom,sm4250-dwc3 is already documented in top level part, but it
misses specific constraints for clocks.  The SoC is derivative of SM6115
(or vice versa), so the interrupts part is incorrectly placed and should
be same as for SM6115.

Closes: https://sashiko.dev/#/patchset/20260319092348.35237-2-krzysztof.kozlowski%40oss.qualcomm.com
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

---

Changes in v2:
1. New patch
---
 Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
index 94eda4fe48ad..e9e534f49183 100644
--- a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
@@ -355,6 +355,7 @@ allOf:
               - qcom,sar2130p-dwc3
               - qcom,sc8180x-dwc3
               - qcom,sc8180x-dwc3-mp
+              - qcom,sm4250-dwc3
               - qcom,sm6115-dwc3
               - qcom,sm6125-dwc3
               - qcom,sm6375-dwc3
@@ -452,6 +453,7 @@ allOf:
               - qcom,msm8996-dwc3
               - qcom,qcs404-dwc3
               - qcom,sdm660-dwc3
+              - qcom,sm4250-dwc3
               - qcom,sm6115-dwc3
               - qcom,sm6125-dwc3
     then:
@@ -530,7 +532,6 @@ allOf:
               - qcom,sdx55-dwc3
               - qcom,sdx65-dwc3
               - qcom,sdx75-dwc3
-              - qcom,sm4250-dwc3
               - qcom,sm6350-dwc3
               - qcom,sm6375-dwc3
               - qcom,sm8150-dwc3

-- 
2.51.0
Re: [PATCH v2 4/5] dt-bindings: usb: qcom,snps-dwc3: Add constraints for SM4250
Posted by Konrad Dybcio 1 week, 6 days ago
On 3/23/26 9:54 AM, Krzysztof Kozlowski wrote:
> The qcom,sm4250-dwc3 is already documented in top level part, but it
> misses specific constraints for clocks.  The SoC is derivative of SM6115
> (or vice versa), so the interrupts part is incorrectly placed and should
> be same as for SM6115.

They're the same SoC with a different speedbin fuse value for the CPU/GPU,
I'd say drop this binding altogether

Konrad
Re: [PATCH v2 4/5] dt-bindings: usb: qcom,snps-dwc3: Add constraints for SM4250
Posted by Krzysztof Kozlowski 1 week, 6 days ago
On 23/03/2026 12:01, Konrad Dybcio wrote:
> On 3/23/26 9:54 AM, Krzysztof Kozlowski wrote:
>> The qcom,sm4250-dwc3 is already documented in top level part, but it
>> misses specific constraints for clocks.  The SoC is derivative of SM6115
>> (or vice versa), so the interrupts part is incorrectly placed and should
>> be same as for SM6115.
> 
> They're the same SoC with a different speedbin fuse value for the CPU/GPU,
> I'd say drop this binding altogether

Sure, I also thought about it.

Best regards,
Krzysztof