[PATCH 1/6] riscv: dts: spacemit: add LEDs for Milk-V Jupiter board

Aurelien Jarno posted 6 patches 1 week, 5 days ago
[PATCH 1/6] riscv: dts: spacemit: add LEDs for Milk-V Jupiter board
Posted by Aurelien Jarno 1 week, 5 days ago
The Milk-V Jupiter board provides support for two LEDs through the front
panel header. The "Power LED" indicates the system is running, and the
"HDD LED" shows disk activity. Configure the corresponding LED triggers
accordingly.

Caveats:
- The LEDs are driven through a 4.7k series resistor, making them
  quite faint.
- The disk activity trigger requires a storage controller on the M.2 or
  PCIe interface. That said, it matches the purpose and the vendor
  kernel.

Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---
 .../boot/dts/spacemit/k1-milkv-jupiter.dts      | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts b/arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts
index 9959c8023ece0..3cd83c5924e4f 100644
--- a/arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts
+++ b/arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts
@@ -21,6 +21,23 @@ chosen {
 		stdout-path = "serial0";
 	};
 
+	leds {
+		compatible = "gpio-leds";
+
+		led1 {
+			label = "pwr-led";
+			gpios = <&gpio K1_GPIO(96) GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "default-on";
+			default-state = "on";
+		};
+
+		led2 {
+			label = "hdd-led";
+			gpios = <&gpio K1_GPIO(92) GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "disk-activity";
+		};
+	};
+
 	reg_dc_in: regulator-dc-in-12v {
 		compatible = "regulator-fixed";
 		regulator-name = "dc_in_12v";
-- 
2.51.0
Re: [PATCH 1/6] riscv: dts: spacemit: add LEDs for Milk-V Jupiter board
Posted by Javier Martinez Canillas 1 week, 3 days ago
Aurelien Jarno <aurelien@aurel32.net> writes:

Hello Aurelien,

> The Milk-V Jupiter board provides support for two LEDs through the front
> panel header. The "Power LED" indicates the system is running, and the
> "HDD LED" shows disk activity. Configure the corresponding LED triggers
> accordingly.
>
> Caveats:
> - The LEDs are driven through a 4.7k series resistor, making them
>   quite faint.
> - The disk activity trigger requires a storage controller on the M.2 or
>   PCIe interface. That said, it matches the purpose and the vendor
>   kernel.
>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---

Looks good to me.

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat