[PATCH v2 0/5] platform/x86: hp-wmi: Victus S fan control fixes

Emre Cecanpunar posted 5 patches 1 week, 5 days ago
drivers/platform/x86/hp/hp-wmi.c | 55 +++++++++++++++++++++-----------
1 file changed, 37 insertions(+), 18 deletions(-)
[PATCH v2 0/5] platform/x86: hp-wmi: Victus S fan control fixes
Posted by Emre Cecanpunar 1 week, 5 days ago
This series fixes several bugs in the Victus S fan control code.

Changes in v2:
- Patch 4: Drop the if (gpu_delta < 0) guard and pr_warn. A negative
  delta is valid firmware behavior on boards where CPU_RPM > GPU_RPM.
  Store gpu_delta as 'int' in struct hp_wmi_hwmon_priv so that the
  existing signed arithmetic and clamp_val() in hp_wmi_fan_speed_set()
  handle the negative case correctly without saturating at U8_MAX.

Emre Cecanpunar (5):
  platform/x86: hp-wmi: fix ignored return values in fan settings
  platform/x86: hp-wmi: avoid cancel_delayed_work_sync from work handler
  platform/x86: hp-wmi: use mod_delayed_work to reset keep-alive timer
  platform/x86: hp-wmi: fix u8 underflow in gpu_delta calculation
  platform/x86: hp-wmi: add locking for concurrent hwmon access

 drivers/platform/x86/hp/hp-wmi.c | 55 +++++++++++++++++++++-----------
 1 file changed, 37 insertions(+), 18 deletions(-)

-- 
2.53.0
Re: [PATCH v2 0/5] platform/x86: hp-wmi: Victus S fan control fixes
Posted by Ilpo Järvinen 1 week, 3 days ago
On Sun, 22 Mar 2026, Emre Cecanpunar wrote:

> This series fixes several bugs in the Victus S fan control code.
> 
> Changes in v2:
> - Patch 4: Drop the if (gpu_delta < 0) guard and pr_warn. A negative
>   delta is valid firmware behavior on boards where CPU_RPM > GPU_RPM.
>   Store gpu_delta as 'int' in struct hp_wmi_hwmon_priv so that the
>   existing signed arithmetic and clamp_val() in hp_wmi_fan_speed_set()
>   handle the negative case correctly without saturating at U8_MAX.
> 
> Emre Cecanpunar (5):
>   platform/x86: hp-wmi: fix ignored return values in fan settings
>   platform/x86: hp-wmi: avoid cancel_delayed_work_sync from work handler
>   platform/x86: hp-wmi: use mod_delayed_work to reset keep-alive timer
>   platform/x86: hp-wmi: fix u8 underflow in gpu_delta calculation
>   platform/x86: hp-wmi: add locking for concurrent hwmon access

You should all so add Fixes tags to these changes, they're currently 
missing from all of them.

-- 
 i.