[PATCH v3 7/8] dt-bindings: i2c: realtek,rtl9301-i2c: extend for RTL9607C support

Rustam Adilov posted 8 patches 1 week, 5 days ago
There is a newer version of this series
[PATCH v3 7/8] dt-bindings: i2c: realtek,rtl9301-i2c: extend for RTL9607C support
Posted by Rustam Adilov 1 week, 5 days ago
Add the "realtek,rtl9607-i2c" compatible for i2c controller on the
RTL9607C SoC series.

Add a clocks property to the properties to describe the i2c reference
clock and make it available for all the compatibles. This i2c reference
clock is assumed to be coming from switchcore region via Lexra bus as
the other SoC peripherals.

RTL9607C requires the "realtek,scl" to be specified the same way as
RTL9310 so add it to the same if check.

Signed-off-by: Rustam Adilov <adilov@disroot.org>
---
 .../devicetree/bindings/i2c/realtek,rtl9301-i2c.yaml   | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/i2c/realtek,rtl9301-i2c.yaml b/Documentation/devicetree/bindings/i2c/realtek,rtl9301-i2c.yaml
index f9a449fee2b0..4a83923fee15 100644
--- a/Documentation/devicetree/bindings/i2c/realtek,rtl9301-i2c.yaml
+++ b/Documentation/devicetree/bindings/i2c/realtek,rtl9301-i2c.yaml
@@ -15,6 +15,8 @@ description:
   assigned to either I2C controller.
   RTL9310 SoCs have equal capabilities but support 12 common SDA lines which
   can be assigned to either I2C controller.
+  RTL9607C SoCs have equal capabilities but each controller only supports 1
+  SCL/SDA line.
 
 properties:
   compatible:
@@ -34,6 +36,7 @@ properties:
       - enum:
           - realtek,rtl9301-i2c
           - realtek,rtl9310-i2c
+          - realtek,rtl9607-i2c
 
   reg:
     items:
@@ -51,6 +54,9 @@ properties:
       The SCL line number of this I2C controller.
     enum: [ 0, 1 ]
 
+  clocks:
+    maxItems: 1
+
 patternProperties:
   '^i2c@[0-9ab]$':
     $ref: /schemas/i2c/i2c-controller.yaml
@@ -69,7 +75,9 @@ allOf:
       properties:
         compatible:
           contains:
-            const: realtek,rtl9310-i2c
+            enum:
+              - realtek,rtl9310-i2c
+              - realtek,rtl9607-i2c
     then:
       required:
         - realtek,scl
-- 
2.53.0
Re: [PATCH v3 7/8] dt-bindings: i2c: realtek,rtl9301-i2c: extend for RTL9607C support
Posted by Krzysztof Kozlowski 1 week, 5 days ago
On 22/03/2026 13:34, Rustam Adilov wrote:
> Add the "realtek,rtl9607-i2c" compatible for i2c controller on the
> RTL9607C SoC series.
> 
> Add a clocks property to the properties to describe the i2c reference
> clock and make it available for all the compatibles. This i2c reference
> clock is assumed to be coming from switchcore region via Lexra bus as
> the other SoC peripherals.
> 

Why the clock is not required for rtl9607? I did not find explanation of
such change in the changelog/cover letter.

Best regards,
Krzysztof
Re: [PATCH v3 7/8] dt-bindings: i2c: realtek,rtl9301-i2c: extend for RTL9607C support
Posted by Rustam Adilov 1 week, 4 days ago
On 2026-03-22 21:02, Krzysztof Kozlowski wrote:
> On 22/03/2026 13:34, Rustam Adilov wrote:
>> Add the "realtek,rtl9607-i2c" compatible for i2c controller on the
>> RTL9607C SoC series.
>> 
>> Add a clocks property to the properties to describe the i2c reference
>> clock and make it available for all the compatibles. This i2c 
>> reference
>> clock is assumed to be coming from switchcore region via Lexra bus as
>> the other SoC peripherals.
>> 
> 
> Why the clock is not required for rtl9607? I did not find explanation 
> of
> such change in the changelog/cover letter.

I have apparently forgotten to include it back after moving 
"realtek,rtl9607-i2c" to another spot.
Will add it back in v4.

> Best regards,
> Krzysztof

Thanks,
Rustam