This series cleans up the rtw_joinbss_event_prehandle function in the
rtl8723bs staging driver.

The first patch removes dead code guarded by the REJOIN macro, which is
never defined in the kernel. This simplifies the function before the
subsequent refactor.

The second patch refactors the function using guard clauses and early
returns to reduce deep indentation, improving overall readability.

v4:
- Removed redundant return at the end of the void function.
- Fixed typo in v3 cover letter. ("Rmoed" -> "Removed")
- Picked up Reviewed-by tag from Luka Gejak.

v3:
- Removed the 'retry' variable which became dead after REJOIN
  removal.
- Removed the 'ignore_joinbss_callback' label and use direct
  returns.
- Preserve the original comment for the join_res <= 0 case.
- Keep the original newline for the netdev_dbg call.
- Moved the 's5' comment after the spin_unlock_bh call to match
  original placement.

v2:
- Split the original patch into a two-patch series.
- Changed the subject line.
- Removed all REJOIN-related dead code.
- Fixed a typo in the ptarget_sta comment.
- Avoided unnecessary changes.


Jose A. Perez de Azpillaga (2):
  staging: rtl8723bs: remove dead REJOIN code
  staging: rtl8723bs: refactor rtw_joinbss_event_prehandle to reduce
    indentation

 drivers/staging/rtl8723bs/core/rtw_mlme.c | 155 ++++++++++------------
 1 file changed, 68 insertions(+), 87 deletions(-)

--
2.53.0

On Sat, Mar 21, 2026 at 07:26:58PM +0100, Jose A. Perez de Azpillaga wrote:
> This series cleans up the rtw_joinbss_event_prehandle function in the
> rtl8723bs staging driver.
> 
> The first patch removes dead code guarded by the REJOIN macro, which is
> never defined in the kernel. This simplifies the function before the
> subsequent refactor.
> 
> The second patch refactors the function using guard clauses and early
> returns to reduce deep indentation, improving overall readability.
> 
> v4:
> - Removed redundant return at the end of the void function.
> - Fixed typo in v3 cover letter. ("Rmoed" -> "Removed")
> - Picked up Reviewed-by tag from Luka Gejak.

Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>

regards,
dan carpenter